[INFO] cloning repository https://github.com/CharonWu/Cover-Art-Changer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CharonWu/Cover-Art-Changer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCharonWu%2FCover-Art-Changer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCharonWu%2FCover-Art-Changer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 34257f890c50c7d7ee2e18d6f223fb105db614db [INFO] checking CharonWu/Cover-Art-Changer/34257f890c50c7d7ee2e18d6f223fb105db614db against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCharonWu%2FCover-Art-Changer" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CharonWu/Cover-Art-Changer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CharonWu/Cover-Art-Changer [INFO] finished tweaking git repo https://github.com/CharonWu/Cover-Art-Changer [INFO] tweaked toml for git repo https://github.com/CharonWu/Cover-Art-Changer written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CharonWu/Cover-Art-Changer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30eaa8beeb606d9e404bbd5c7ed2552320bbd1538d9ddd3f8ea1dd265c83edb4 [INFO] running `Command { std: "docker" "start" "-a" "30eaa8beeb606d9e404bbd5c7ed2552320bbd1538d9ddd3f8ea1dd265c83edb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30eaa8beeb606d9e404bbd5c7ed2552320bbd1538d9ddd3f8ea1dd265c83edb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30eaa8beeb606d9e404bbd5c7ed2552320bbd1538d9ddd3f8ea1dd265c83edb4", kill_on_drop: false }` [INFO] [stdout] 30eaa8beeb606d9e404bbd5c7ed2552320bbd1538d9ddd3f8ea1dd265c83edb4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c699bcca024bd40925e0bce215e0a2ed4b4f0a0b973569290dd634c763545c76 [INFO] running `Command { std: "docker" "start" "-a" "c699bcca024bd40925e0bce215e0a2ed4b4f0a0b973569290dd634c763545c76", kill_on_drop: false }` [INFO] [stderr] Checking cover_art_changer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/audio/flac.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `metadata_length` [INFO] [stdout] --> src/audio/flac.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | let metadata_length = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metadata_length` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_description` [INFO] [stdout] --> src/audio/flac.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | let pic_description = [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_description` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_width` [INFO] [stdout] --> src/audio/flac.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let pic_width = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_width` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_height` [INFO] [stdout] --> src/audio/flac.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let pic_height = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_depth` [INFO] [stdout] --> src/audio/flac.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | let color_depth = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_index` [INFO] [stdout] --> src/audio/flac.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | let color_index = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `audio_files` is never read [INFO] [stdout] --> src/audio/mod.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | let mut audio_files: Vec = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/image/mod.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | Err(e) => Err(ReadFileError::FilePathError( [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio/cover_art.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 29 | let file = match File::create(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match BufWriter::new(file).write_all(&stream[self.start..(self.start + self.length)]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio/flac.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 65 | let file = match File::create(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let mut buf_writer = BufWriter::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match buf_writer.write_all(&self.stream[self.image_block_end..self.stream.len()]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Image` should have a snake case name [INFO] [stdout] --> src/image/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Image { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `image` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cover_art_changer` (bin "cover_art_changer") due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/audio/flac.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `metadata_length` [INFO] [stdout] --> src/audio/flac.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | let metadata_length = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metadata_length` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_description` [INFO] [stdout] --> src/audio/flac.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | let pic_description = [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_description` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_width` [INFO] [stdout] --> src/audio/flac.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let pic_width = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_width` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pic_height` [INFO] [stdout] --> src/audio/flac.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | let pic_height = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pic_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_depth` [INFO] [stdout] --> src/audio/flac.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | let color_depth = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_depth` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color_index` [INFO] [stdout] --> src/audio/flac.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | let color_index = bytes_to_u32(&stream[pic_block_i..(pic_block_i + 4)]); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_color_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `audio_files` is never read [INFO] [stdout] --> src/audio/mod.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | let mut audio_files: Vec = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/image/mod.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | Err(e) => Err(ReadFileError::FilePathError( [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio/cover_art.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 29 | let file = match File::create(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match BufWriter::new(file).write_all(&stream[self.start..(self.start + self.length)]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio/flac.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 65 | let file = match File::create(file_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let mut buf_writer = BufWriter::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match buf_writer.write_all(&self.stream[self.image_block_end..self.stream.len()]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Image` should have a snake case name [INFO] [stdout] --> src/image/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Image { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `image` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cover_art_changer` (bin "cover_art_changer" test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c699bcca024bd40925e0bce215e0a2ed4b4f0a0b973569290dd634c763545c76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c699bcca024bd40925e0bce215e0a2ed4b4f0a0b973569290dd634c763545c76", kill_on_drop: false }` [INFO] [stdout] c699bcca024bd40925e0bce215e0a2ed4b4f0a0b973569290dd634c763545c76