[INFO] cloning repository https://github.com/Cerberuser/darkest_dungeon_mod_bundler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cerberuser/darkest_dungeon_mod_bundler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCerberuser%2Fdarkest_dungeon_mod_bundler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCerberuser%2Fdarkest_dungeon_mod_bundler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 242cf7ab1e092bea56cc8e8ed9a0190eb7674696 [INFO] checking Cerberuser/darkest_dungeon_mod_bundler/242cf7ab1e092bea56cc8e8ed9a0190eb7674696 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCerberuser%2Fdarkest_dungeon_mod_bundler" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Cerberuser/darkest_dungeon_mod_bundler on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Cerberuser/darkest_dungeon_mod_bundler [INFO] finished tweaking git repo https://github.com/Cerberuser/darkest_dungeon_mod_bundler [INFO] tweaked toml for git repo https://github.com/Cerberuser/darkest_dungeon_mod_bundler written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Cerberuser/darkest_dungeon_mod_bundler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 339bfc5943e6a9d576754a240d79b30e2aa182bb300179dd6327195e8a2b1cad [INFO] running `Command { std: "docker" "start" "-a" "339bfc5943e6a9d576754a240d79b30e2aa182bb300179dd6327195e8a2b1cad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "339bfc5943e6a9d576754a240d79b30e2aa182bb300179dd6327195e8a2b1cad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "339bfc5943e6a9d576754a240d79b30e2aa182bb300179dd6327195e8a2b1cad", kill_on_drop: false }` [INFO] [stdout] 339bfc5943e6a9d576754a240d79b30e2aa182bb300179dd6327195e8a2b1cad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9bff12129af16ee1bbf53f8fc2f33e8641bb9b8d083f6bb4d370efc64ef50faf [INFO] running `Command { std: "docker" "start" "-a" "9bff12129af16ee1bbf53f8fc2f33e8641bb9b8d083f6bb4d370efc64ef50faf", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling syn v1.0.31 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling proc-macro-hack v0.5.16 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.112 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Checking array-macro v1.0.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking signal-hook v0.1.15 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Compiling unindent v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.55 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking crossterm v0.17.5 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking bytes v0.5.5 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking simplelog v0.8.0 [INFO] [stderr] Checking combine v4.2.1 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.112 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling indoc-impl v0.3.6 [INFO] [stderr] Checking indoc v0.3.6 [INFO] [stderr] Checking enum-map v0.6.2 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling enumset_derive v0.5.0 [INFO] [stderr] Checking enumset v1.0.0 [INFO] [stderr] Checking cursive_core v0.1.0 [INFO] [stderr] Checking cursive v0.15.0 [INFO] [stderr] Checking serde-xml-rs v0.4.0 [INFO] [stderr] Checking darkest_dungeon_mod_bundler v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `indoc::indoc` [INFO] [stdout] --> src/bundler/deploy.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use indoc::indoc; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `indoc::indoc` [INFO] [stdout] --> src/bundler/deploy.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use indoc::indoc; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `MapPath` is never used [INFO] [stdout] --> src/bundler/structures.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | trait MapPath: Ord + Eq {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BTreeMappable` is never used [INFO] [stdout] --> src/bundler/structures.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | trait BTreeMappable: Sized { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DarkestEntry` is never constructed [INFO] [stdout] --> src/bundler/structures/darkest.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct DarkestEntry(Vec<(String, Vec)>); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DarkestEntry` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DarkestFile` is never constructed [INFO] [stdout] --> src/bundler/structures/darkest.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct DarkestFile(Vec<(String, DarkestEntry)>); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DarkestFile` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `key_value` is never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 69 | fn key_value( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comment` is never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | fn comment() -> impl Parser [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ItemsParser` is never constructed [INFO] [stdout] --> src/bundler/structures/darkest.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | struct ItemsParser(PhantomData); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 119 | impl ItemsParser { [INFO] [stdout] | ------------------------------ associated function in this implementation [INFO] [stdout] 120 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `ItemStepResult` is never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:125:10 [INFO] [stdout] | [INFO] [stdout] 125 | enum ItemStepResult { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `key`, `subkey`, `ident`, `value`, and `parser` are never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 201 | impl DarkestEntry { [INFO] [stdout] | ----------------- associated functions in this implementation [INFO] [stdout] 202 | fn key() -> impl Parser [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | fn subkey() -> impl Parser [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 218 | fn ident() -> impl Parser [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 229 | fn value() -> impl Parser [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 257 | fn parser() -> impl Parser [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `parser` is never used [INFO] [stdout] --> src/bundler/structures/darkest.rs:272:16 [INFO] [stdout] | [INFO] [stdout] 271 | impl DarkestFile { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 272 | pub fn parser() -> impl Parser [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `JsonFile` is never constructed [INFO] [stdout] --> src/bundler/structures/json.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | struct JsonFile(Value); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `flatten` is never used [INFO] [stdout] --> src/bundler/structures/json.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | fn flatten(prefix: JsonPath, value: &Value) -> Vec<(JsonPath, &Value)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `flatten_mut` is never used [INFO] [stdout] --> src/bundler/structures/json.rs:67:4 [INFO] [stdout] | [INFO] [stdout] 67 | fn flatten_mut(prefix: JsonPath, value: &mut Value) -> Vec<(JsonPath, &mut Value)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `flatten_owned` is never used [INFO] [stdout] --> src/bundler/structures/json.rs:98:4 [INFO] [stdout] | [INFO] [stdout] 98 | fn flatten_owned(prefix: JsonPath, value: Value) -> Vec<(JsonPath, Value)> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 200 | entry.and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | entry.metadata().map(|meta| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/deploy.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 91 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | / Dialog::around( [INFO] [stdout] 97 | | LinearLayout::vertical() [INFO] [stdout] 98 | | .child( [INFO] [stdout] 99 | | Panel::new( [INFO] [stdout] ... | [INFO] [stdout] 136 | | sender.send((name.to_string(), dir.to_string())).unwrap(); [INFO] [stdout] 137 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/deploy.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 156 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / Dialog::around(TextView::new(format!( [INFO] [stdout] 162 | | "Target directory {} already exists! [INFO] [stdout] 163 | | Choose your action: [INFO] [stdout] 164 | | - overwrite existing folder; [INFO] [stdout] ... | [INFO] [stdout] 171 | | .button("Cancel", send_choice(&sender, Cancel)) [INFO] [stdout] 172 | | .h_align(cursive::align::HAlign::Center), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/resolve.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 67 | text: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | options: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> T { [INFO] [stdout] 70 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let text = text.into(); [INFO] [stdout] 72 | let options: Vec<_> = options.into_iter().collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / receiver [INFO] [stdout] 93 | | .recv() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/resolve.rs:141:55 [INFO] [stdout] | [INFO] [stdout] 141 | .for_each(|(name, line)| layout.add_child(render_line_choice(line, name))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 70 | key: impl Parser, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | value: impl Parser, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | (key, skip_many1(space()), value).map(|(key, (), value)| (key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:223:32 [INFO] [stdout] | [INFO] [stdout] 223 | let in_ident = || (alpha_num(), exact_char('_')); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:277:37 [INFO] [stdout] | [INFO] [stdout] 277 | let skipped = || choice((one_of(" \t\r\n".chars()).map(|_| {}), comment())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | item.map_err(LoadModsError::Io).and_then(|entry| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 58 | item.map_err(LoadModsError::Io).and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let path = entry.path(); [INFO] [stdout] 60 | let file = std::fs::File::open(path.join("project.xml"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | match serde_xml_rs::from_reader::<_, Project>(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_view(&self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Some(f(&self.0)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 20 | fn with_view_mut(&mut self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Some(f(&mut self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `darkest_dungeon_mod_bundler` (lib) due to 13 previous errors; 16 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `MapPath` is never used [INFO] [stdout] --> src/bundler/structures.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | trait MapPath: Ord + Eq {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `map` and `map_mut` are never used [INFO] [stdout] --> src/bundler/structures.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 9 | trait BTreeMappable: Sized { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 13 | fn map(&self) -> BTreeMap; [INFO] [stdout] | ^^^ [INFO] [stdout] 14 | fn map_mut(&mut self) -> BTreeMap; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `flatten` is never used [INFO] [stdout] --> src/bundler/structures/json.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | fn flatten(prefix: JsonPath, value: &Value) -> Vec<(JsonPath, &Value)> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `flatten_mut` is never used [INFO] [stdout] --> src/bundler/structures/json.rs:67:4 [INFO] [stdout] | [INFO] [stdout] 67 | fn flatten_mut(prefix: JsonPath, value: &mut Value) -> Vec<(JsonPath, &mut Value)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 200 | entry.and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | entry.metadata().map(|meta| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/deploy.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 91 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | / Dialog::around( [INFO] [stdout] 97 | | LinearLayout::vertical() [INFO] [stdout] 98 | | .child( [INFO] [stdout] 99 | | Panel::new( [INFO] [stdout] ... | [INFO] [stdout] 136 | | sender.send((name.to_string(), dir.to_string())).unwrap(); [INFO] [stdout] 137 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/deploy.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 156 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / Dialog::around(TextView::new(format!( [INFO] [stdout] 162 | | "Target directory {} already exists! [INFO] [stdout] 163 | | Choose your action: [INFO] [stdout] 164 | | - overwrite existing folder; [INFO] [stdout] ... | [INFO] [stdout] 171 | | .button("Cancel", send_choice(&sender, Cancel)) [INFO] [stdout] 172 | | .h_align(cursive::align::HAlign::Center), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/resolve.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 67 | text: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | options: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> T { [INFO] [stdout] 70 | let (sender, receiver) = bounded(0); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let text = text.into(); [INFO] [stdout] 72 | let options: Vec<_> = options.into_iter().collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / receiver [INFO] [stdout] 93 | | .recv() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/resolve.rs:141:55 [INFO] [stdout] | [INFO] [stdout] 141 | .for_each(|(name, line)| layout.add_child(render_line_choice(line, name))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 70 | key: impl Parser, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | value: impl Parser, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | (key, skip_many1(space()), value).map(|(key, (), value)| (key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:223:32 [INFO] [stdout] | [INFO] [stdout] 223 | let in_ident = || (alpha_num(), exact_char('_')); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bundler/structures/darkest.rs:277:37 [INFO] [stdout] | [INFO] [stdout] 277 | let skipped = || choice((one_of(" \t\r\n".chars()).map(|_| {}), comment())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|item| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | item.map_err(LoadModsError::Io).and_then(|entry| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 58 | item.map_err(LoadModsError::Io).and_then(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let path = entry.path(); [INFO] [stdout] 60 | let file = std::fs::File::open(path.join("project.xml"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | match serde_xml_rs::from_reader::<_, Project>(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_view(&self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Some(f(&self.0)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/select.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 20 | fn with_view_mut(&mut self, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Some(f(&mut self.0)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `darkest_dungeon_mod_bundler` (lib test) due to 13 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9bff12129af16ee1bbf53f8fc2f33e8641bb9b8d083f6bb4d370efc64ef50faf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bff12129af16ee1bbf53f8fc2f33e8641bb9b8d083f6bb4d370efc64ef50faf", kill_on_drop: false }` [INFO] [stdout] 9bff12129af16ee1bbf53f8fc2f33e8641bb9b8d083f6bb4d370efc64ef50faf