[INFO] cloning repository https://github.com/Canadadry/rust-ray-tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Canadadry/rust-ray-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCanadadry%2Frust-ray-tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCanadadry%2Frust-ray-tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7de890816867a94e573cc4f3f2dcf4ba66946fd [INFO] checking Canadadry/rust-ray-tracer/c7de890816867a94e573cc4f3f2dcf4ba66946fd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCanadadry%2Frust-ray-tracer" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Canadadry/rust-ray-tracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Canadadry/rust-ray-tracer [INFO] finished tweaking git repo https://github.com/Canadadry/rust-ray-tracer [INFO] tweaked toml for git repo https://github.com/Canadadry/rust-ray-tracer written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Canadadry/rust-ray-tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7b1954231037d41ecb14505fe5adcc08f1fd3adc8245765ce62812433700745 [INFO] running `Command { std: "docker" "start" "-a" "c7b1954231037d41ecb14505fe5adcc08f1fd3adc8245765ce62812433700745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7b1954231037d41ecb14505fe5adcc08f1fd3adc8245765ce62812433700745", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7b1954231037d41ecb14505fe5adcc08f1fd3adc8245765ce62812433700745", kill_on_drop: false }` [INFO] [stdout] c7b1954231037d41ecb14505fe5adcc08f1fd3adc8245765ce62812433700745 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa262468ceed46e83a0d3402a11d8e466c81633d221b02a08629df12b588f388 [INFO] running `Command { std: "docker" "start" "-a" "fa262468ceed46e83a0d3402a11d8e466c81633d221b02a08629df12b588f388", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling proc-macro2 v1.0.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking rgb v0.8.14 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.6.2 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking lodepng v2.5.0 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking console v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stderr] Checking indicatif v0.11.0 [INFO] [stderr] Checking serde_yaml v0.8.9 [INFO] [stderr] Checking ray_tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/engine/tracer.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | (ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - (ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0) [INFO] [stdout] 42 + ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/engine/tracer.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | (ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - (ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0) [INFO] [stdout] 42 + ray.x >= 0.0 && ray.y >= 0.0 && ray.z >= 0.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add` and `project_on` are never used [INFO] [stdout] --> src/math/vector3.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | impl Vec3 { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 13 | pub fn add(&self, v: &Vec3) -> Vec3 [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn project_on(&self,v:&Vec3) -> Vec3 [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `identity`, `clone`, `add`, and `sub` are never used [INFO] [stdout] --> src/math/matrix3.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Mat3 { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn identity() -> Mat3 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn clone(&self) -> Mat3 [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn add(& self,m:&Mat3) -> Mat3 [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn sub(& self,m:&Mat3) -> Mat3 [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `translation`, `scale`, `clone`, and `add` are never used [INFO] [stdout] --> src/math/matrix4.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Mat4 { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn translation(v:&Vec3) -> Mat4 [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | pub fn scale(v:&Vec3) -> Mat4 [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | pub fn clone(&self) -> Mat4 [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub fn add(&self,m:&Mat4) -> Mat4 [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/engine/tracer.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Pixel(pub u8,pub u8,pub u8,pub u8); [INFO] [stdout] | ----- ^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Pixel` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `white`, `black`, and `blue` are never used [INFO] [stdout] --> src/engine/tracer.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Pixel { [INFO] [stdout] | ---------- associated functions in this implementation [INFO] [stdout] 11 | pub fn white() -> Pixel { Pixel(255,255,255,255)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | pub fn black() -> Pixel { Pixel( 0, 0, 0,255)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn blue() -> Pixel { Pixel(0,0,255,255)} [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | let mut ifile = File::open(&path).expect("unable to open path"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ifile.read_to_string(&mut input).expect("unable to read"); [INFO] [stdout] 53 | serde_yaml::from_str(&input).expect("invalid format") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/engine/tracer.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Pixel(pub u8,pub u8,pub u8,pub u8); [INFO] [stdout] | ----- ^^^^^^ ^^^^^^ ^^^^^^ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `Pixel` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `white`, `black`, and `blue` are never used [INFO] [stdout] --> src/engine/tracer.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Pixel { [INFO] [stdout] | ---------- associated functions in this implementation [INFO] [stdout] 11 | pub fn white() -> Pixel { Pixel(255,255,255,255)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | pub fn black() -> Pixel { Pixel( 0, 0, 0,255)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn blue() -> Pixel { Pixel(0,0,255,255)} [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | let mut ifile = File::open(&path).expect("unable to open path"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ifile.read_to_string(&mut input).expect("unable to read"); [INFO] [stdout] 53 | serde_yaml::from_str(&input).expect("invalid format") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray_tracer` (bin "ray_tracer") due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray_tracer` (bin "ray_tracer" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fa262468ceed46e83a0d3402a11d8e466c81633d221b02a08629df12b588f388", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa262468ceed46e83a0d3402a11d8e466c81633d221b02a08629df12b588f388", kill_on_drop: false }` [INFO] [stdout] fa262468ceed46e83a0d3402a11d8e466c81633d221b02a08629df12b588f388