[INFO] cloning repository https://github.com/CampbellOwen/advent-of-code-2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CampbellOwen/advent-of-code-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCampbellOwen%2Fadvent-of-code-2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCampbellOwen%2Fadvent-of-code-2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 285289d3ece4b969ad367c36176fdf01cc09a2db [INFO] checking CampbellOwen/advent-of-code-2022/285289d3ece4b969ad367c36176fdf01cc09a2db against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCampbellOwen%2Fadvent-of-code-2022" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CampbellOwen/advent-of-code-2022 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CampbellOwen/advent-of-code-2022 [INFO] finished tweaking git repo https://github.com/CampbellOwen/advent-of-code-2022 [INFO] tweaked toml for git repo https://github.com/CampbellOwen/advent-of-code-2022 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CampbellOwen/advent-of-code-2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c3f5ad0404cbd963c7771162a32a325676a8691d9ebfb24ffe6250d8787ef75 [INFO] running `Command { std: "docker" "start" "-a" "5c3f5ad0404cbd963c7771162a32a325676a8691d9ebfb24ffe6250d8787ef75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c3f5ad0404cbd963c7771162a32a325676a8691d9ebfb24ffe6250d8787ef75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c3f5ad0404cbd963c7771162a32a325676a8691d9ebfb24ffe6250d8787ef75", kill_on_drop: false }` [INFO] [stdout] 5c3f5ad0404cbd963c7771162a32a325676a8691d9ebfb24ffe6250d8787ef75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25073b05d947c31fb9f493cc677d345554b77ae08e7ee22911c9b423fea02f79 [INFO] running `Command { std: "docker" "start" "-a" "25073b05d947c31fb9f493cc677d345554b77ae08e7ee22911c9b423fea02f79", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.66 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking advent-of-code-2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/day3.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let second = &s[(s.len() / 2..)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - let second = &s[(s.len() / 2..)]; [INFO] [stdout] 19 + let second = &s[s.len() / 2..]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/day3.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let second = &s[(s.len() / 2..)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - let second = &s[(s.len() / 2..)]; [INFO] [stdout] 19 + let second = &s[s.len() / 2..]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `num` is never read [INFO] [stdout] --> src/day5.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 31 | struct Board { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 32 | num: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day3.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|line| Rucksack::from(line).common_item()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day4.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 53 | let min = nums.next().ok_or("Not enough numbers")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let max = nums.next().ok_or("Not enough numbers")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | Ok(Interval { min, max }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day4.rs:51:62 [INFO] [stdout] | [INFO] [stdout] 51 | let mut nums = s.split('-').take(2).filter_map(|num| num.parse().ok()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code-2022` (bin "advent-of-code-2022") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day3.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|line| Rucksack::from(line).common_item()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day4.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 53 | let min = nums.next().ok_or("Not enough numbers")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let max = nums.next().ok_or("Not enough numbers")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | Ok(Interval { min, max }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/day4.rs:51:62 [INFO] [stdout] | [INFO] [stdout] 51 | let mut nums = s.split('-').take(2).filter_map(|num| num.parse().ok()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code-2022` (bin "advent-of-code-2022" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "25073b05d947c31fb9f493cc677d345554b77ae08e7ee22911c9b423fea02f79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25073b05d947c31fb9f493cc677d345554b77ae08e7ee22911c9b423fea02f79", kill_on_drop: false }` [INFO] [stdout] 25073b05d947c31fb9f493cc677d345554b77ae08e7ee22911c9b423fea02f79