[INFO] cloning repository https://github.com/CaffeineDuck/jBREAD [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CaffeineDuck/jBREAD" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCaffeineDuck%2FjBREAD", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCaffeineDuck%2FjBREAD'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 234c64a9a3d207f4e013fc7b109c2b982dc800fe [INFO] checking CaffeineDuck/jBREAD/234c64a9a3d207f4e013fc7b109c2b982dc800fe against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCaffeineDuck%2FjBREAD" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CaffeineDuck/jBREAD on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CaffeineDuck/jBREAD [INFO] finished tweaking git repo https://github.com/CaffeineDuck/jBREAD [INFO] tweaked toml for git repo https://github.com/CaffeineDuck/jBREAD written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CaffeineDuck/jBREAD already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b408f58c9eed426c4ca255e11f537e6c5d56a7584001607726f8597b875dbef2 [INFO] running `Command { std: "docker" "start" "-a" "b408f58c9eed426c4ca255e11f537e6c5d56a7584001607726f8597b875dbef2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b408f58c9eed426c4ca255e11f537e6c5d56a7584001607726f8597b875dbef2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b408f58c9eed426c4ca255e11f537e6c5d56a7584001607726f8597b875dbef2", kill_on_drop: false }` [INFO] [stdout] b408f58c9eed426c4ca255e11f537e6c5d56a7584001607726f8597b875dbef2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbfc63676b70c886ba482b5750e272bae60d72feb33742e53b451e5e6f6f1dbf [INFO] running `Command { std: "docker" "start" "-a" "bbfc63676b70c886ba482b5750e272bae60d72feb33742e53b451e5e6f6f1dbf", kill_on_drop: false }` [INFO] [stderr] Checking j_bread v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `generate_ast::*` [INFO] [stdout] --> src/tool/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use generate_ast::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `scanner::*` [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub use scanner::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `generate_ast::*` [INFO] [stdout] --> src/tool/mod.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub use generate_ast::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `scanner::*` [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub use scanner::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:40:39 [INFO] [stdout] | [INFO] [stdout] 40 | fn visit_expr_variable(&mut self, expr: &crate::ast::Variable) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 44 | fn visit_expr_assign(&mut self, expr: &crate::ast::Assign) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | fn visit_stmt_expression(&mut self, expr: &crate::ast::Expression) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:56:36 [INFO] [stdout] | [INFO] [stdout] 56 | fn visit_stmt_print(&mut self, expr: &crate::ast::Print) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | fn visit_stmt_var(&mut self, expr: &crate::ast::Var) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | fn visit_stmt_block(&mut self, expr: &crate::ast::Block) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ParseTrait` is never used [INFO] [stdout] --> src/parser.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ParseTrait { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 130 | let mut initializer = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Stmt::Var(Var { name, initializer })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | self.consume(TokenTypes::Semicolon, "Expect ';' after expression.")?; [INFO] [stdout] 303 | Ok(Stmt::Expression(Expression { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | expression: Box::new(expr), [INFO] [stdout] 305 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:311:12 [INFO] [stdout] | [INFO] [stdout] 309 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | self.consume(TokenTypes::Semicolon, "Expect ';' after value.")?; [INFO] [stdout] 311 | Ok(Stmt::Print(Print { [INFO] [stdout] | ____________^ [INFO] [stdout] 312 | | expression: Box::new(expr), [INFO] [stdout] 313 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 329 | let mut statements = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | Ok(Stmt::Block(Block { statements })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:40:39 [INFO] [stdout] | [INFO] [stdout] 40 | fn visit_expr_variable(&mut self, expr: &crate::ast::Variable) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 44 | fn visit_expr_assign(&mut self, expr: &crate::ast::Assign) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | fn visit_stmt_expression(&mut self, expr: &crate::ast::Expression) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:56:36 [INFO] [stdout] | [INFO] [stdout] 56 | fn visit_stmt_print(&mut self, expr: &crate::ast::Print) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:60:34 [INFO] [stdout] | [INFO] [stdout] 60 | fn visit_stmt_var(&mut self, expr: &crate::ast::Var) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/tool/print_ast.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | fn visit_stmt_block(&mut self, expr: &crate::ast::Block) -> Self::Result { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `j_bread` (lib) due to 5 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `ParseTrait` is never used [INFO] [stdout] --> src/parser.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ParseTrait { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 130 | let mut initializer = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | Ok(Stmt::Var(Var { name, initializer })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | self.consume(TokenTypes::Semicolon, "Expect ';' after expression.")?; [INFO] [stdout] 303 | Ok(Stmt::Expression(Expression { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | expression: Box::new(expr), [INFO] [stdout] 305 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:311:12 [INFO] [stdout] | [INFO] [stdout] 309 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | self.consume(TokenTypes::Semicolon, "Expect ';' after value.")?; [INFO] [stdout] 311 | Ok(Stmt::Print(Print { [INFO] [stdout] | ____________^ [INFO] [stdout] 312 | | expression: Box::new(expr), [INFO] [stdout] 313 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 329 | let mut statements = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | Ok(Stmt::Block(Block { statements })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `j_bread` (lib test) due to 5 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bbfc63676b70c886ba482b5750e272bae60d72feb33742e53b451e5e6f6f1dbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbfc63676b70c886ba482b5750e272bae60d72feb33742e53b451e5e6f6f1dbf", kill_on_drop: false }` [INFO] [stdout] bbfc63676b70c886ba482b5750e272bae60d72feb33742e53b451e5e6f6f1dbf