[INFO] cloning repository https://github.com/BurntSushi/rucd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BurntSushi/rucd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurntSushi%2Frucd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurntSushi%2Frucd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ed9fa514ed44a8920a8cc336f35c1890b9161ee4 [INFO] checking BurntSushi/rucd/ed9fa514ed44a8920a8cc336f35c1890b9161ee4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurntSushi%2Frucd" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BurntSushi/rucd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BurntSushi/rucd [INFO] finished tweaking git repo https://github.com/BurntSushi/rucd [INFO] tweaked toml for git repo https://github.com/BurntSushi/rucd written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BurntSushi/rucd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7cdfb2ea8121ae56976c9e063eac23fbd44ebcd0c473b37869ec7b57b520cdad [INFO] running `Command { std: "docker" "start" "-a" "7cdfb2ea8121ae56976c9e063eac23fbd44ebcd0c473b37869ec7b57b520cdad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7cdfb2ea8121ae56976c9e063eac23fbd44ebcd0c473b37869ec7b57b520cdad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cdfb2ea8121ae56976c9e063eac23fbd44ebcd0c473b37869ec7b57b520cdad", kill_on_drop: false }` [INFO] [stdout] 7cdfb2ea8121ae56976c9e063eac23fbd44ebcd0c473b37869ec7b57b520cdad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15bfdf2c8470541c1c926d4afa23779ff8d0849ac11e18b35dad1a320a345e68 [INFO] running `Command { std: "docker" "start" "-a" "15bfdf2c8470541c1c926d4afa23779ff8d0849ac11e18b35dad1a320a345e68", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.39 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling regex v0.2.9 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking regex-syntax v0.5.3 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking tabwriter v1.0.4 [INFO] [stderr] Checking fst v0.3.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking rucd v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/name.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | static ref NAMES_WITH_ALIASES: BTreeMap = { [INFO] [stdout] 11 | | let mut map = BTreeMap::new(); [INFO] [stdout] 12 | | let mut stream = NAMES.stream(); [INFO] [stdout] ... | [INFO] [stdout] 26 | | }; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/tables/fst/names.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | pub static ref NAMES: ::fst::Map = [INFO] [stdout] 11 | | ::fst::Map::from(::fst::raw::Fst::from_static_slice( [INFO] [stdout] 12 | | include_bytes!("names.fst")).unwrap()); [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 35 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/name.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | static ref NAMES_WITH_ALIASES: BTreeMap = { [INFO] [stdout] 11 | | let mut map = BTreeMap::new(); [INFO] [stdout] 12 | | let mut stream = NAMES.stream(); [INFO] [stdout] ... | [INFO] [stdout] 26 | | }; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/tables/fst/names.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | pub static ref NAMES: ::fst::Map = [INFO] [stdout] 11 | | ::fst::Map::from(::fst::raw::Fst::from_static_slice( [INFO] [stdout] 12 | | include_bytes!("names.fst")).unwrap()); [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/error.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | fn cause(&self) -> Option<&error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 35 | fn cause(&self) -> Option<&dyn error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:30:39 [INFO] [stdout] | [INFO] [stdout] 30 | Error::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:30:39 [INFO] [stdout] | [INFO] [stdout] 30 | Error::Io(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/name.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | let mut entry = map.entry(cp).or_insert(Names::default()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/name.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | let mut entry = map.entry(cp).or_insert(Names::default()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 44 | let cmd_search = SubCommand::with_name("search") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let cmd_list_properties = SubCommand::with_name("list-properties") [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let cmd_list_property_values = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / App::new("rucd") [INFO] [stdout] 79 | | .author(crate_authors!()) [INFO] [stdout] 80 | | .version(crate_version!()) [INFO] [stdout] 81 | | .about(ABOUT) [INFO] [stdout] ... | [INFO] [stdout] 85 | | .subcommand(cmd_search) [INFO] [stdout] 86 | | .subcommand(cmd_list_properties) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(wtr: W) -> ShortWriter { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ShortWriter { [INFO] [stdout] 17 | wtr: TabWriter::new(io::BufWriter::new(wtr)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/name.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | let mut entry = map.entry(cp).or_insert(Names::default()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/name.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | let mut entry = map.entry(cp).or_insert(Names::default()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 118 | let source = match self.pattern { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let re = RegexBuilder::new(pattern) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Search { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | source: source, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 44 | let cmd_search = SubCommand::with_name("search") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let cmd_list_properties = SubCommand::with_name("list-properties") [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let cmd_list_property_values = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / App::new("rucd") [INFO] [stdout] 79 | | .author(crate_authors!()) [INFO] [stdout] 80 | | .version(crate_version!()) [INFO] [stdout] 81 | | .about(ABOUT) [INFO] [stdout] ... | [INFO] [stdout] 85 | | .subcommand(cmd_search) [INFO] [stdout] 86 | | .subcommand(cmd_list_properties) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(wtr: W) -> ShortWriter { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ShortWriter { [INFO] [stdout] 17 | wtr: TabWriter::new(io::BufWriter::new(wtr)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 118 | let source = match self.pattern { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let re = RegexBuilder::new(pattern) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Search { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | source: source, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rucd` (bin "rucd" test) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rucd` (bin "rucd") due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "15bfdf2c8470541c1c926d4afa23779ff8d0849ac11e18b35dad1a320a345e68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15bfdf2c8470541c1c926d4afa23779ff8d0849ac11e18b35dad1a320a345e68", kill_on_drop: false }` [INFO] [stdout] 15bfdf2c8470541c1c926d4afa23779ff8d0849ac11e18b35dad1a320a345e68