[INFO] cloning repository https://github.com/BurningBlueFox/rust-dungeon-crawler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BurningBlueFox/rust-dungeon-crawler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurningBlueFox%2Frust-dungeon-crawler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurningBlueFox%2Frust-dungeon-crawler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 649b1e1e51ef25d86399f8e94d43bc6a6a0d6418 [INFO] checking BurningBlueFox/rust-dungeon-crawler/649b1e1e51ef25d86399f8e94d43bc6a6a0d6418 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBurningBlueFox%2Frust-dungeon-crawler" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BurningBlueFox/rust-dungeon-crawler on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BurningBlueFox/rust-dungeon-crawler [INFO] finished tweaking git repo https://github.com/BurningBlueFox/rust-dungeon-crawler [INFO] tweaked toml for git repo https://github.com/BurningBlueFox/rust-dungeon-crawler written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BurningBlueFox/rust-dungeon-crawler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db1a5596a7be07ffef6a62eea96c0f02b0df90835e8a49b79da9e0c27205ffe2 [INFO] running `Command { std: "docker" "start" "-a" "db1a5596a7be07ffef6a62eea96c0f02b0df90835e8a49b79da9e0c27205ffe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db1a5596a7be07ffef6a62eea96c0f02b0df90835e8a49b79da9e0c27205ffe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db1a5596a7be07ffef6a62eea96c0f02b0df90835e8a49b79da9e0c27205ffe2", kill_on_drop: false }` [INFO] [stdout] db1a5596a7be07ffef6a62eea96c0f02b0df90835e8a49b79da9e0c27205ffe2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22e4b2b064fc7d4c460e51ad313e13f832e3a85cb1f575f1e71f678eb485c8d2 [INFO] running `Command { std: "docker" "start" "-a" "22e4b2b064fc7d4c460e51ad313e13f832e3a85cb1f575f1e71f678eb485c8d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Compiling syn v1.0.71 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking bytemuck v1.5.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Checking wide v0.5.5 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling wayland-sys v0.28.5 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Compiling wayland-scanner v0.28.5 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling glow v0.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking getrandom v0.2.2 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking ultraviolet v0.7.5 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking bracket-color v0.8.2 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling wayland-client v0.28.5 [INFO] [stderr] Compiling wayland-protocols v0.28.5 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking object-pool v0.5.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking bracket-geometry v0.8.2 [INFO] [stderr] Checking bracket-algorithm-traits v0.8.2 [INFO] [stderr] Checking bracket-pathfinding v0.8.4 [INFO] [stderr] Checking regex v1.5.3 [INFO] [stderr] Checking bracket-random v0.8.2 [INFO] [stderr] Checking bracket-noise v0.8.2 [INFO] [stderr] Checking wayland-commons v0.28.5 [INFO] [stderr] Checking ctrlc v3.1.9 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-cursor v0.28.5 [INFO] [stderr] Checking wayland-egl v0.28.5 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling thiserror v1.0.24 [INFO] [stderr] Compiling legion_codegen v0.3.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking erased-serde v0.3.13 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking legion v0.3.1 [INFO] [stderr] Checking winit v0.24.0 [INFO] [stderr] Checking glutin v0.26.0 [INFO] [stderr] Checking bracket-terminal v0.8.2 [INFO] [stderr] Checking bracket-lib v0.8.1 [INFO] [stderr] Checking dungeoncrawler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/combat.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/player_input.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | input_systems: build_input_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | player_systems: build_player_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | npcs_systems: build_npcs_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | main_loop(context, State::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dungeoncrawler` (bin "dungeoncrawler") due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/combat.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/systems/player_input.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | if let Ok(mut health) = ecs [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | input_systems: build_input_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:29 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | player_systems: build_player_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:60:27 [INFO] [stdout] | [INFO] [stdout] 39 | let mut ecs = World::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut resources = Resources::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | npcs_systems: build_npcs_scheduler(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | main_loop(context, State::new()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dungeoncrawler` (bin "dungeoncrawler" test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "22e4b2b064fc7d4c460e51ad313e13f832e3a85cb1f575f1e71f678eb485c8d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22e4b2b064fc7d4c460e51ad313e13f832e3a85cb1f575f1e71f678eb485c8d2", kill_on_drop: false }` [INFO] [stdout] 22e4b2b064fc7d4c460e51ad313e13f832e3a85cb1f575f1e71f678eb485c8d2