[INFO] cloning repository https://github.com/Buchimi/NES [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Buchimi/NES" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuchimi%2FNES", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuchimi%2FNES'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 87bb0556c82c901164873d9fc8a2a0e19eec669b [INFO] checking Buchimi/NES/87bb0556c82c901164873d9fc8a2a0e19eec669b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBuchimi%2FNES" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Buchimi/NES on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Buchimi/NES [INFO] finished tweaking git repo https://github.com/Buchimi/NES [INFO] tweaked toml for git repo https://github.com/Buchimi/NES written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Buchimi/NES already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cedcb3664aa4917aadc8facf69869eee6d65fe84008b009bb510ca2f60d38cf0 [INFO] running `Command { std: "docker" "start" "-a" "cedcb3664aa4917aadc8facf69869eee6d65fe84008b009bb510ca2f60d38cf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cedcb3664aa4917aadc8facf69869eee6d65fe84008b009bb510ca2f60d38cf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cedcb3664aa4917aadc8facf69869eee6d65fe84008b009bb510ca2f60d38cf0", kill_on_drop: false }` [INFO] [stdout] cedcb3664aa4917aadc8facf69869eee6d65fe84008b009bb510ca2f60d38cf0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20241bc5560c51916fe1359d189d5de0eb028deba4e9ce44c85a0f6accde2532 [INFO] running `Command { std: "docker" "start" "-a" "20241bc5560c51916fe1359d189d5de0eb028deba4e9ce44c85a0f6accde2532", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling version-compare v0.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking NES v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `chr_rom`, `mapper`, and `screen_mirroring` are never read [INFO] [stdout] --> src/cartridge.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Rom { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 14 | pub prg_rom: Vec, [INFO] [stdout] 15 | pub chr_rom: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub mapper: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | pub screen_mirroring: Mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestRom` is never constructed [INFO] [stdout] --> src/cartridge.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | struct TestRom { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_rom` is never used [INFO] [stdout] --> src/cartridge.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | fn create_rom(rom: TestRom) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_rom` is never used [INFO] [stdout] --> src/cartridge.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn test_rom() -> Rom { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `load_and_run`, `load`, and `run` are never used [INFO] [stdout] --> src/cpu.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 94 | impl CPU { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 246 | pub fn load_and_run(&mut self, program: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | pub fn load(&mut self, program: Vec) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 549 | pub fn run(&mut self) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnemonic` and `cycles` are never read [INFO] [stdout] --> src/opcodes.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct OpCode { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 5 | pub code: u8, [INFO] [stdout] 6 | pub mnemonic: &'static str, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub len: u8, [INFO] [stdout] 8 | pub cycles: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 29 | let sdl_content = sdl2::init().expect("SDL couldn't be initialized"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let video_subsystem = sdl_content [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut canvas = window.into_canvas().present_vsync().build().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let mut event_pump = sdl_content.event_pump().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let creator = canvas.texture_creator(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let mut texture = creator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | cpu.run_with_callback(move |cpu| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 74 | | //read user input [INFO] [stdout] 75 | | handle_user_input(cpu, &mut event_pump); [INFO] [stdout] ... | [INFO] [stdout] 89 | | ::std::thread::sleep(std::time::Duration::new(0, 70_000)) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mnemonic` and `cycles` are never read [INFO] [stdout] --> src/opcodes.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct OpCode { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 5 | pub code: u8, [INFO] [stdout] 6 | pub mnemonic: &'static str, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | pub len: u8, [INFO] [stdout] 8 | pub cycles: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 29 | let sdl_content = sdl2::init().expect("SDL couldn't be initialized"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let video_subsystem = sdl_content [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut canvas = window.into_canvas().present_vsync().build().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let mut event_pump = sdl_content.event_pump().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let creator = canvas.texture_creator(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let mut texture = creator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | cpu.run_with_callback(move |cpu| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 74 | | //read user input [INFO] [stdout] 75 | | handle_user_input(cpu, &mut event_pump); [INFO] [stdout] ... | [INFO] [stdout] 89 | | ::std::thread::sleep(std::time::Duration::new(0, 70_000)) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `NES` (bin "NES") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `NES` (bin "NES" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "20241bc5560c51916fe1359d189d5de0eb028deba4e9ce44c85a0f6accde2532", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20241bc5560c51916fe1359d189d5de0eb028deba4e9ce44c85a0f6accde2532", kill_on_drop: false }` [INFO] [stdout] 20241bc5560c51916fe1359d189d5de0eb028deba4e9ce44c85a0f6accde2532