[INFO] cloning repository https://github.com/Brychlikov/bartosz [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Brychlikov/bartosz" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrychlikov%2Fbartosz", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrychlikov%2Fbartosz'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d700e9153c79b9e600f76d3d41b08631d1f9e5f [INFO] checking Brychlikov/bartosz/7d700e9153c79b9e600f76d3d41b08631d1f9e5f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrychlikov%2Fbartosz" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Brychlikov/bartosz on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Brychlikov/bartosz [INFO] finished tweaking git repo https://github.com/Brychlikov/bartosz [INFO] tweaked toml for git repo https://github.com/Brychlikov/bartosz written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Brychlikov/bartosz already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b85d551b2c6dc10e374337b80afb431135e42ff4c7cfd24afc4b48534567ec8 [INFO] running `Command { std: "docker" "start" "-a" "5b85d551b2c6dc10e374337b80afb431135e42ff4c7cfd24afc4b48534567ec8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b85d551b2c6dc10e374337b80afb431135e42ff4c7cfd24afc4b48534567ec8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b85d551b2c6dc10e374337b80afb431135e42ff4c7cfd24afc4b48534567ec8", kill_on_drop: false }` [INFO] [stdout] 5b85d551b2c6dc10e374337b80afb431135e42ff4c7cfd24afc4b48534567ec8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0bf59f695e834394c7e09dbb741783997a6c9c2dbce27d3ec060151635a0a36d [INFO] running `Command { std: "docker" "start" "-a" "0bf59f695e834394c7e09dbb741783997a6c9c2dbce27d3ec060151635a0a36d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking aho-corasick v0.7.9 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking backtrace v0.3.44 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking rustyline v6.0.0 [INFO] [stderr] Checking calculator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser.rs:126:61 [INFO] [stdout] | [INFO] [stdout] 126 | Some(Ok(Punctuation(c))) if c == ")" => (ast), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 126 - Some(Ok(Punctuation(c))) if c == ")" => (ast), [INFO] [stdout] 126 + Some(Ok(Punctuation(c))) if c == ")" => ast, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser.rs:126:61 [INFO] [stdout] | [INFO] [stdout] 126 | Some(Ok(Punctuation(c))) if c == ")" => (ast), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 126 - Some(Ok(Punctuation(c))) if c == ")" => (ast), [INFO] [stdout] 126 + Some(Ok(Punctuation(c))) if c == ")" => ast, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/parser.rs:237:25 [INFO] [stdout] | [INFO] [stdout] 237 | let n = self.input.next(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:187:44 [INFO] [stdout] | [INFO] [stdout] 187 | .chain_err(|| Error::from_kind(ErrorKind::EOF))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:287:15 [INFO] [stdout] | [INFO] [stdout] 286 | fn maybe_mul(&mut self, left: Box) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | match self.peek_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/parser.rs:237:25 [INFO] [stdout] | [INFO] [stdout] 237 | let n = self.input.next(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:187:44 [INFO] [stdout] | [INFO] [stdout] 187 | .chain_err(|| Error::from_kind(ErrorKind::EOF))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:287:15 [INFO] [stdout] | [INFO] [stdout] 286 | fn maybe_mul(&mut self, left: Box) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | match self.peek_clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:331:15 [INFO] [stdout] | [INFO] [stdout] 327 | let mut calc = Calculator::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | match calc.eval("(1+2)(3+4)(5+6)") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:348:15 [INFO] [stdout] | [INFO] [stdout] 347 | let mut calc = Calculator::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | match calc.eval("x = y = 5") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:370:15 [INFO] [stdout] | [INFO] [stdout] 357 | let mut calc = Calculator::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | match calc.eval("2 * 2 * 2 + 2 * 2 * 2") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:380:15 [INFO] [stdout] | [INFO] [stdout] 379 | let mut calc = Calculator::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | match calc.eval("32 / 2 /2 /2 /2") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 389 | let mut calc = Calculator::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | match calc.eval("2 * 2 * 2 + 2 = 2") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0bf59f695e834394c7e09dbb741783997a6c9c2dbce27d3ec060151635a0a36d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bf59f695e834394c7e09dbb741783997a6c9c2dbce27d3ec060151635a0a36d", kill_on_drop: false }` [INFO] [stdout] 0bf59f695e834394c7e09dbb741783997a6c9c2dbce27d3ec060151635a0a36d