[INFO] cloning repository https://github.com/BruceBrown/async_machine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BruceBrown/async_machine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBruceBrown%2Fasync_machine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBruceBrown%2Fasync_machine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 65b564b755f92d10c1860b7d05a893719a4e0954 [INFO] checking BruceBrown/async_machine/65b564b755f92d10c1860b7d05a893719a4e0954 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBruceBrown%2Fasync_machine" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BruceBrown/async_machine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BruceBrown/async_machine [INFO] finished tweaking git repo https://github.com/BruceBrown/async_machine [INFO] tweaked toml for git repo https://github.com/BruceBrown/async_machine written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BruceBrown/async_machine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0523cc46d641533654b7ab3a936733338034b8a5ac353bfa2a0d01437eeecd87 [INFO] running `Command { std: "docker" "start" "-a" "0523cc46d641533654b7ab3a936733338034b8a5ac353bfa2a0d01437eeecd87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0523cc46d641533654b7ab3a936733338034b8a5ac353bfa2a0d01437eeecd87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0523cc46d641533654b7ab3a936733338034b8a5ac353bfa2a0d01437eeecd87", kill_on_drop: false }` [INFO] [stdout] 0523cc46d641533654b7ab3a936733338034b8a5ac353bfa2a0d01437eeecd87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 224d699053814fa2a2b79d284f94bceed56955a5e8cb02b965014146bb536b77 [INFO] running `Command { std: "docker" "start" "-a" "224d699053814fa2a2b79d284f94bceed56955a5e8cb02b965014146bb536b77", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Checking cache-padded v1.1.1 [INFO] [stderr] Checking futures-io v0.3.13 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking fastrand v1.4.0 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking event-listener v2.5.1 [INFO] [stderr] Checking once_cell v1.7.0 [INFO] [stderr] Checking vec-arena v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Checking async-task v4.0.3 [INFO] [stderr] Compiling signal-hook v0.3.6 [INFO] [stderr] Checking atomic-waker v1.0.0 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking async-lock v2.3.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking async-channel v1.6.1 [INFO] [stderr] Checking futures-lite v1.11.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-queue v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking polling v2.0.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking blocking v1.0.2 [INFO] [stderr] Checking async-executor v1.4.0 [INFO] [stderr] Checking crossbeam v0.8.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking nb-connect v1.0.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking async-fs v1.5.0 [INFO] [stderr] Checking async-io v1.3.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking async-process v1.0.2 [INFO] [stderr] Checking async-net v1.5.0 [INFO] [stderr] Checking simplelog v0.8.0 [INFO] [stderr] Checking smol v1.2.5 [INFO] [stderr] Compiling smart-default v0.6.0 [INFO] [stderr] Checking async_machine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `sender` and `executor` are never read [INFO] [stdout] --> src/test_message.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct MachineSenderTestMessage { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 46 | sender: smol::channel::Sender, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 47 | executor: std::sync::Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MachineSenderTestMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:42:6 [INFO] [stdout] | [INFO] [stdout] 27 | let handles: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let (s, r) = smol::channel::unbounded::<()>(); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut send_executors: Vec>> = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | (send_executors.clone(), handles, s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:38:50 [INFO] [stdout] | [INFO] [stdout] 38 | catch_unwind(|| future::block_on(e.run(async { r.recv().await }))).ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 246 | machine: Arc>, executor: Arc>, receiver: smol::channel::Receiver, [INFO] [stdout] | -------------------------------------- -------------------------------------- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | ..Self::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chaos_monkey.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 53 | let mut forwarders: Vec> = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | smol::block_on(async { [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | // we're going to create N machines, each having N senders, plus a notifier. [INFO] [stdout] 56 | | for idx in 1 ..= self.machine_count { [INFO] [stdout] 57 | | let (f, s) = if self.bound_queue { [INFO] [stdout] ... | [INFO] [stdout] 83 | | self.forwarders = forwarders; [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async_machine` (bin "async_machine") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `sender` and `executor` are never read [INFO] [stdout] --> src/test_message.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct MachineSenderTestMessage { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 46 | sender: smol::channel::Sender, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 47 | executor: std::sync::Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MachineSenderTestMessage` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:42:6 [INFO] [stdout] | [INFO] [stdout] 27 | let handles: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let (s, r) = smol::channel::unbounded::<()>(); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut send_executors: Vec>> = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | (send_executors.clone(), handles, s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:38:50 [INFO] [stdout] | [INFO] [stdout] 38 | catch_unwind(|| future::block_on(e.run(async { r.recv().await }))).ok(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/machine_adapter.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 246 | machine: Arc>, executor: Arc>, receiver: smol::channel::Receiver, [INFO] [stdout] | -------------------------------------- -------------------------------------- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | ..Self::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chaos_monkey.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 53 | let mut forwarders: Vec> = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | smol::block_on(async { [INFO] [stdout] | ________________________^ [INFO] [stdout] 55 | | // we're going to create N machines, each having N senders, plus a notifier. [INFO] [stdout] 56 | | for idx in 1 ..= self.machine_count { [INFO] [stdout] 57 | | let (f, s) = if self.bound_queue { [INFO] [stdout] ... | [INFO] [stdout] 83 | | self.forwarders = forwarders; [INFO] [stdout] 84 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `async_machine` (bin "async_machine" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "224d699053814fa2a2b79d284f94bceed56955a5e8cb02b965014146bb536b77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "224d699053814fa2a2b79d284f94bceed56955a5e8cb02b965014146bb536b77", kill_on_drop: false }` [INFO] [stdout] 224d699053814fa2a2b79d284f94bceed56955a5e8cb02b965014146bb536b77