[INFO] cloning repository https://github.com/Browsers-software/browsers [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Browsers-software/browsers" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrowsers-software%2Fbrowsers", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrowsers-software%2Fbrowsers'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 938b07bff42e720bf8d5bf4b8daf005bca16c2aa [INFO] checking Browsers-software/browsers/938b07bff42e720bf8d5bf4b8daf005bca16c2aa against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrowsers-software%2Fbrowsers" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Browsers-software/browsers on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Browsers-software/browsers [INFO] finished tweaking git repo https://github.com/Browsers-software/browsers [INFO] tweaked toml for git repo https://github.com/Browsers-software/browsers written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Browsers-software/browsers already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5f13b863da1e6ba38c051db3f45eda0fcddfcff828780034b48545a2df1a019 [INFO] running `Command { std: "docker" "start" "-a" "c5f13b863da1e6ba38c051db3f45eda0fcddfcff828780034b48545a2df1a019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5f13b863da1e6ba38c051db3f45eda0fcddfcff828780034b48545a2df1a019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5f13b863da1e6ba38c051db3f45eda0fcddfcff828780034b48545a2df1a019", kill_on_drop: false }` [INFO] [stdout] c5f13b863da1e6ba38c051db3f45eda0fcddfcff828780034b48545a2df1a019 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c3456e26e86c1e07fe868ca01f2d38dbffc4e7ad8fe220471f9fbd352f54fb3 [INFO] running `Command { std: "docker" "start" "-a" "5c3456e26e86c1e07fe868ca01f2d38dbffc4e7ad8fe220471f9fbd352f54fb3", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling gio v0.16.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_spanned v0.6.7 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking unic-ucd-bidi v0.9.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking unic-bidi v0.9.0 [INFO] [stderr] Checking kurbo v0.9.5 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling glib-macros v0.16.8 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling glib-sys v0.16.3 [INFO] [stderr] Compiling gobject-sys v0.16.3 [INFO] [stderr] Compiling gio-sys v0.16.3 [INFO] [stderr] Compiling cairo-sys-rs v0.16.3 [INFO] [stderr] Compiling pango-sys v0.16.3 [INFO] [stderr] Compiling atk-sys v0.16.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling gdk-sys v0.16.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.16.3 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling gtk-sys v0.16.0 [INFO] [stderr] Compiling pangocairo-sys v0.16.3 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking unic-langid-impl v0.9.5 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking unic-langid v0.9.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling temp-dir v0.1.13 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling gettext-sys v0.21.4 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking piet v0.6.2 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking glib v0.16.9 [INFO] [stderr] Compiling gtk v0.16.2 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking type-map v0.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Compiling gtk3-macros v0.16.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling druid-shell v0.8.3 (https://github.com/browsers-software/druid.git?branch=browsers#d03ea912) [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking self_cell v0.10.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking locale_config v0.3.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ordered-multimap v0.7.3 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking intl-memoizer v0.5.2 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking intl_pluralrules v7.0.2 [INFO] [stderr] Checking fluent-langneg v0.13.0 [INFO] [stderr] Checking fluent-syntax v0.11.1 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking keyboard-types v0.6.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling dark-light v1.1.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking fluent-bundle v0.15.3 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking rust-ini v0.20.0 [INFO] [stderr] Checking gettext-rs v0.7.1 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking cairo-rs v0.16.7 [INFO] [stderr] Checking atk v0.16.0 [INFO] [stderr] Compiling druid-derive v0.5.1 (https://github.com/browsers-software/druid.git?branch=browsers#d03ea912) [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking dconf_rs v0.3.0 [INFO] [stderr] Compiling doctest-file v1.0.0 [INFO] [stderr] Checking widestring v0.4.3 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking detect-desktop-environment v0.2.0 [INFO] [stderr] Compiling browsers v0.5.8 (/opt/rustwide/workdir) [INFO] [stderr] Checking textdistance v1.0.2 [INFO] [stdout] warning: function `copy_file_to_target_dir` is never used [INFO] [stdout] --> build.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn copy_file_to_target_dir(target_build_path: &Path, file_path_relative: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `copy_resource` is never used [INFO] [stdout] --> build.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn copy_resource(target_build_path: &Path, file_path_relative: &str) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `copy_resources` is never used [INFO] [stdout] --> build.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn copy_resources() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking interprocess v2.2.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking freedesktop-desktop-entry v0.7.4 [INFO] [stderr] Checking xdg-mime v0.4.0 [INFO] [stderr] Checking single-instance v0.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking freedesktop-icons v0.2.6 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Checking rolling-file v0.2.0 (https://github.com/browsers-software/rolling-file-rs.git?branch=browsers#1e187f7a) [INFO] [stderr] Checking naive-cityhash v0.2.0 [INFO] [stderr] Checking pango v0.16.5 [INFO] [stderr] Checking gdk-pixbuf v0.16.7 [INFO] [stderr] Checking pangocairo v0.16.3 [INFO] [stderr] Checking gdk v0.16.2 [INFO] [stderr] Checking piet-cairo v0.6.2 [INFO] [stderr] Checking piet-common v0.6.2 [INFO] [stderr] Checking druid v0.8.3 (https://github.com/browsers-software/druid.git?branch=browsers#d03ea912) [INFO] [stdout] warning: unused import: `std::slice::Split` [INFO] [stdout] --> src/linux/linux_utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::slice::Split; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::slice::Split` [INFO] [stdout] --> src/linux/linux_utils.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::slice::Split; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/paths.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 139 | return PathBuf::from("./resources"); [INFO] [stdout] | ----------------------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 147 | return linux_utils::get_this_app_resources_dir(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/paths.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 139 | return PathBuf::from("./resources"); [INFO] [stdout] | ----------------------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 147 | return linux_utils::get_this_app_resources_dir(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_id` [INFO] [stdout] --> src/paths.rs:93:40 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_user_home_for_sandboxed_app(app_id: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_id` [INFO] [stdout] --> src/paths.rs:93:40 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_user_home_for_sandboxed_app(app_id: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_id` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/linux/linux_utils.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut desktop_file_paths_by_filename: BTreeMap<_, PathBuf> = Iter::new(all_search_paths) [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/linux/linux_utils.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | let mut desktop_file_paths_by_filename: BTreeMap<_, PathBuf> = Iter::new(all_search_paths) [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `enterprise_workspace_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let enterprise_workspace_url_pattern = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_enterprise_workspace_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slack_gov_workspace_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let slack_gov_workspace_url_pattern = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_slack_gov_workspace_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | let app_url_pattern = format!("app.slack.com/**/{}/**", workspace.id.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `domain_name` [INFO] [stdout] --> src/slack_profiles_parser.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for (domain_name, workspace) in workspaces_map { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_domain_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `enterprise_workspace_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let enterprise_workspace_url_pattern = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_enterprise_workspace_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `slack_gov_workspace_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | let slack_gov_workspace_url_pattern = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_slack_gov_workspace_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app_url_pattern` [INFO] [stdout] --> src/slack_profiles_parser.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | let app_url_pattern = format!("app.slack.com/**/{}/**", workspace.id.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_url_pattern` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `domain_name` [INFO] [stdout] --> src/slack_profiles_parser.rs:110:14 [INFO] [stdout] | [INFO] [stdout] 110 | for (domain_name, workspace) in workspaces_map { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_domain_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `app` is never read [INFO] [stdout] --> src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct GenericApp { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 51 | app: BrowserCommon, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Palette` is never constructed [INFO] [stdout] --> src/gui/ui_theme.rs:365:8 [INFO] [stdout] | [INFO] [stdout] 365 | struct Palette {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `start` is never used [INFO] [stdout] --> src/browser_repository.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 78 | impl SupportedAppRepository { [INFO] [stdout] | --------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 207 | fn start(&mut self) -> &mut SupportedAppRepository { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mac_bundle_id` and `windows_app_id` are never read [INFO] [stdout] --> src/browser_repository.rs:714:5 [INFO] [stdout] | [INFO] [stdout] 713 | pub struct AppIdentifier { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 714 | mac_bundle_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 715 | linux_desktop_id: String, [INFO] [stdout] 716 | windows_app_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppIdentifier` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/browser_repository.rs:720:8 [INFO] [stdout] | [INFO] [stdout] 719 | impl AppIdentifier { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 720 | fn new(mac_bundle_id: &str, linux_desktop_id: &str, windows_app_id: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mac_config_dir_relative` and `windows_config_dir_relative` are never read [INFO] [stdout] --> src/browser_repository.rs:777:5 [INFO] [stdout] | [INFO] [stdout] 775 | struct AppConfigDir { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 776 | root_path: PathBuf, [INFO] [stdout] 777 | mac_config_dir_relative: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 778 | linux_config_dir_relative: PathBuf, [INFO] [stdout] 779 | windows_config_dir_relative: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `convert_mimestream_uri` is never used [INFO] [stdout] --> src/browser_repository.rs:830:4 [INFO] [stdout] | [INFO] [stdout] 830 | fn convert_mimestream_uri(_: &CommonBrowserProfile, url_str: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_this_app_xdg_data_dir` is never used [INFO] [stdout] --> src/linux/linux_utils.rs:390:4 [INFO] [stdout] | [INFO] [stdout] 390 | fn get_this_app_xdg_data_dir() -> PathBuf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `icon_68` and `icon_88` are never read [INFO] [stdout] --> src/slack_profiles_parser.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct SlackWorkspace { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 139 | pub icon_68: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 140 | pub icon_88: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `url_str_matches` is never used [INFO] [stdout] --> src/url_rule.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl UrlGlobMatcher { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn url_str_matches(&self, url_str: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/main_window.rs:193:62 [INFO] [stdout] | [INFO] [stdout] 193 | let browsers_list = List::new(move || create_browser(ImageBuf::empty(), ImageBuf::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/main_window.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | let browsers_list = List::new(move || create_browser(ImageBuf::empty(), ImageBuf::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/mod.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 91 | fn view_switcher(browsers_arc: Arc>) -> ViewSwitcher { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / move |selector, _data, _env| match selector { [INFO] [stdout] 95 | | SettingsTab::GENERAL => { [INFO] [stdout] 96 | | settings_view_container("settings-tab-general", general_view::general_content()) [INFO] [stdout] 97 | | } [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/mod.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 146 | let string = LocalizedString::new(key); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | [INFO] [stdout] 148 | let painter = Painter::new(move |ctx, active_tab, env| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / Flex::column() [INFO] [stdout] 163 | | .cross_axis_alignment(CrossAxisAlignment::Start) [INFO] [stdout] 164 | | .with_child( [INFO] [stdout] 165 | | Label::new(string) [INFO] [stdout] ... | [INFO] [stdout] 194 | | .with_size(data.size);*/ [INFO] [stdout] 195 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:334:32 [INFO] [stdout] | [INFO] [stdout] 329 | let save_command_clone0 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | ctx.submit_command(save_command_clone0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 339 | fn item_profile(b: &UIBrowser, save_command: Command) -> MenuItem> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let save_command_clone1 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | [INFO] [stdout] 347 | / MenuItem::new(profile_full_name) [INFO] [stdout] 348 | | .selected_if(move |opener: &Option, _env| { [INFO] [stdout] 349 | | opener.is_some() && opener.as_ref().unwrap().profile == profile_id [INFO] [stdout] 350 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:352:13 [INFO] [stdout] | [INFO] [stdout] 339 | fn item_profile(b: &UIBrowser, save_command: Command) -> MenuItem> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let save_command_clone1 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | / move |ctx: &mut MenuEventCtx, opener: &mut Option, _env| { [INFO] [stdout] 353 | | // if it's already an app, then change only the profile [INFO] [stdout] 354 | | if opener.is_some() { [INFO] [stdout] 355 | | opener.as_mut().unwrap().profile = profile_id_clone.clone(); [INFO] [stdout] ... | [INFO] [stdout] 364 | | ctx.submit_command(save_command_clone2.clone()) [INFO] [stdout] 365 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:364:36 [INFO] [stdout] | [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | ctx.submit_command(save_command_clone2.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:115:42 [INFO] [stdout] | [INFO] [stdout] 115 | restricted_url_matchers: Arc::new(p.get_restricted_url_matchers().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:149:26 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | main_sender: main_sender.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:152:32 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | filtered_browsers: Arc::new(filtered_browsers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:153:38 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | restorable_app_profiles: Arc::new(restorable_app_profiles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `app` is never read [INFO] [stdout] --> src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct GenericApp { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 51 | app: BrowserCommon, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Palette` is never constructed [INFO] [stdout] --> src/gui/ui_theme.rs:365:8 [INFO] [stdout] | [INFO] [stdout] 365 | struct Palette {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `start` is never used [INFO] [stdout] --> src/browser_repository.rs:207:8 [INFO] [stdout] | [INFO] [stdout] 78 | impl SupportedAppRepository { [INFO] [stdout] | --------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 207 | fn start(&mut self) -> &mut SupportedAppRepository { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mac_bundle_id` and `windows_app_id` are never read [INFO] [stdout] --> src/browser_repository.rs:714:5 [INFO] [stdout] | [INFO] [stdout] 713 | pub struct AppIdentifier { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 714 | mac_bundle_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 715 | linux_desktop_id: String, [INFO] [stdout] 716 | windows_app_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AppIdentifier` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/browser_repository.rs:720:8 [INFO] [stdout] | [INFO] [stdout] 719 | impl AppIdentifier { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 720 | fn new(mac_bundle_id: &str, linux_desktop_id: &str, windows_app_id: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mac_config_dir_relative` and `windows_config_dir_relative` are never read [INFO] [stdout] --> src/browser_repository.rs:777:5 [INFO] [stdout] | [INFO] [stdout] 775 | struct AppConfigDir { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 776 | root_path: PathBuf, [INFO] [stdout] 777 | mac_config_dir_relative: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 778 | linux_config_dir_relative: PathBuf, [INFO] [stdout] 779 | windows_config_dir_relative: PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `convert_mimestream_uri` is never used [INFO] [stdout] --> src/browser_repository.rs:830:4 [INFO] [stdout] | [INFO] [stdout] 830 | fn convert_mimestream_uri(_: &CommonBrowserProfile, url_str: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_this_app_xdg_data_dir` is never used [INFO] [stdout] --> src/linux/linux_utils.rs:390:4 [INFO] [stdout] | [INFO] [stdout] 390 | fn get_this_app_xdg_data_dir() -> PathBuf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `icon_68` and `icon_88` are never read [INFO] [stdout] --> src/slack_profiles_parser.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct SlackWorkspace { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 139 | pub icon_68: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 140 | pub icon_88: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/main_window.rs:193:62 [INFO] [stdout] | [INFO] [stdout] 193 | let browsers_list = List::new(move || create_browser(ImageBuf::empty(), ImageBuf::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/main_window.rs:193:81 [INFO] [stdout] | [INFO] [stdout] 193 | let browsers_list = List::new(move || create_browser(ImageBuf::empty(), ImageBuf::empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/mod.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 91 | fn view_switcher(browsers_arc: Arc>) -> ViewSwitcher { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | / move |selector, _data, _env| match selector { [INFO] [stdout] 95 | | SettingsTab::GENERAL => { [INFO] [stdout] 96 | | settings_view_container("settings-tab-general", general_view::general_content()) [INFO] [stdout] 97 | | } [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/mod.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 146 | let string = LocalizedString::new(key); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | [INFO] [stdout] 148 | let painter = Painter::new(move |ctx, active_tab, env| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / Flex::column() [INFO] [stdout] 163 | | .cross_axis_alignment(CrossAxisAlignment::Start) [INFO] [stdout] 164 | | .with_child( [INFO] [stdout] 165 | | Label::new(string) [INFO] [stdout] ... | [INFO] [stdout] 194 | | .with_size(data.size);*/ [INFO] [stdout] 195 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:334:32 [INFO] [stdout] | [INFO] [stdout] 329 | let save_command_clone0 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | ctx.submit_command(save_command_clone0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 339 | fn item_profile(b: &UIBrowser, save_command: Command) -> MenuItem> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let save_command_clone1 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | [INFO] [stdout] 347 | / MenuItem::new(profile_full_name) [INFO] [stdout] 348 | | .selected_if(move |opener: &Option, _env| { [INFO] [stdout] 349 | | opener.is_some() && opener.as_ref().unwrap().profile == profile_id [INFO] [stdout] 350 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:352:13 [INFO] [stdout] | [INFO] [stdout] 339 | fn item_profile(b: &UIBrowser, save_command: Command) -> MenuItem> { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let save_command_clone1 = save_command.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | / move |ctx: &mut MenuEventCtx, opener: &mut Option, _env| { [INFO] [stdout] 353 | | // if it's already an app, then change only the profile [INFO] [stdout] 354 | | if opener.is_some() { [INFO] [stdout] 355 | | opener.as_mut().unwrap().profile = profile_id_clone.clone(); [INFO] [stdout] ... | [INFO] [stdout] 364 | | ctx.submit_command(save_command_clone2.clone()) [INFO] [stdout] 365 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/settings_window/rules_view.rs:364:36 [INFO] [stdout] | [INFO] [stdout] 345 | let save_command_clone2 = save_command_clone1.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | ctx.submit_command(save_command_clone2.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:115:42 [INFO] [stdout] | [INFO] [stdout] 115 | restricted_url_matchers: Arc::new(p.get_restricted_url_matchers().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:149:26 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | main_sender: main_sender.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:152:32 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | filtered_browsers: Arc::new(filtered_browsers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui/ui.rs:153:38 [INFO] [stdout] | [INFO] [stdout] 137 | main_sender: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | url: &str, [INFO] [stdout] 139 | ui_browsers: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | restorable_app_profiles: Vec, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | show_set_as_default: bool, [INFO] [stdout] 142 | ui_settings: UISettings, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Self { [INFO] [stdout] 144 | let ui_browsers = Arc::new(ui_browsers); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let filtered_browsers = get_filtered_browsers(&url, &ui_browsers); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | restorable_app_profiles: Arc::new(restorable_app_profiles), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `browsers` (lib) due to 13 previous errors; 18 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 12 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `browsers` (lib test) due to 13 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5c3456e26e86c1e07fe868ca01f2d38dbffc4e7ad8fe220471f9fbd352f54fb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c3456e26e86c1e07fe868ca01f2d38dbffc4e7ad8fe220471f9fbd352f54fb3", kill_on_drop: false }` [INFO] [stdout] 5c3456e26e86c1e07fe868ca01f2d38dbffc4e7ad8fe220471f9fbd352f54fb3