[INFO] cloning repository https://github.com/Brianpan/rs-redis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Brianpan/rs-redis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrianpan%2Frs-redis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrianpan%2Frs-redis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e58bcc318b13e6764adc297b3d2acccc443a30cc [INFO] checking Brianpan/rs-redis/e58bcc318b13e6764adc297b3d2acccc443a30cc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBrianpan%2Frs-redis" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Brianpan/rs-redis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Brianpan/rs-redis [INFO] finished tweaking git repo https://github.com/Brianpan/rs-redis [INFO] tweaked toml for git repo https://github.com/Brianpan/rs-redis written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Brianpan/rs-redis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ce7848299c8c5b05e6047d982ce13b966f7bfcc8977d08359516c77f812e625 [INFO] running `Command { std: "docker" "start" "-a" "9ce7848299c8c5b05e6047d982ce13b966f7bfcc8977d08359516c77f812e625", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ce7848299c8c5b05e6047d982ce13b966f7bfcc8977d08359516c77f812e625", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ce7848299c8c5b05e6047d982ce13b966f7bfcc8977d08359516c77f812e625", kill_on_drop: false }` [INFO] [stdout] 9ce7848299c8c5b05e6047d982ce13b966f7bfcc8977d08359516c77f812e625 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 909602abbab28de206040feef4b51c021ae2e355f5e313226bc85b890e3f4647 [INFO] running `Command { std: "docker" "start" "-a" "909602abbab28de206040feef4b51c021ae2e355f5e313226bc85b890e3f4647", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.5 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling tokio v1.23.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking priority-queue v2.0.2 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking redis-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/engine/parser.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/engine/parser.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse_value_encoding` is never used [INFO] [stdout] --> src/rdb/loader.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub trait RDBLoader { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 50 | fn parse_value_encoding(&self, reader: &mut R) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_slave_node` is never used [INFO] [stdout] --> src/store/master_engine.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait MasterEngine { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 26 | fn get_slave_node(&self, host: String) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:104:73 [INFO] [stdout] | [INFO] [stdout] 100 | while let Ok((socket, addr)) = listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let cdb = db.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | tokio::spawn(async move { handle_connection(&cdb, socket, addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (bin "redis-starter-rust") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `parse_value_encoding` is never used [INFO] [stdout] --> src/rdb/loader.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub trait RDBLoader { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 50 | fn parse_value_encoding(&self, reader: &mut R) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_slave_node` is never used [INFO] [stdout] --> src/store/master_engine.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub trait MasterEngine { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 26 | fn get_slave_node(&self, host: String) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:104:73 [INFO] [stdout] | [INFO] [stdout] 100 | while let Ok((socket, addr)) = listener.accept().await { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let cdb = db.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | tokio::spawn(async move { handle_connection(&cdb, socket, addr).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (bin "redis-starter-rust" test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "909602abbab28de206040feef4b51c021ae2e355f5e313226bc85b890e3f4647", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "909602abbab28de206040feef4b51c021ae2e355f5e313226bc85b890e3f4647", kill_on_drop: false }` [INFO] [stdout] 909602abbab28de206040feef4b51c021ae2e355f5e313226bc85b890e3f4647