[INFO] cloning repository https://github.com/Bonstra/tropico5-hpk-unpacker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bonstra/tropico5-hpk-unpacker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBonstra%2Ftropico5-hpk-unpacker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBonstra%2Ftropico5-hpk-unpacker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aa068b65b5df18a14aa172fcb6acf1cc0b9234e1 [INFO] checking Bonstra/tropico5-hpk-unpacker/aa068b65b5df18a14aa172fcb6acf1cc0b9234e1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBonstra%2Ftropico5-hpk-unpacker" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Bonstra/tropico5-hpk-unpacker on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Bonstra/tropico5-hpk-unpacker [INFO] finished tweaking git repo https://github.com/Bonstra/tropico5-hpk-unpacker [INFO] tweaked toml for git repo https://github.com/Bonstra/tropico5-hpk-unpacker written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Bonstra/tropico5-hpk-unpacker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7618360db76ae02be9069d3c312728c2e922d4132e0430846d64443b3e80bcae [INFO] running `Command { std: "docker" "start" "-a" "7618360db76ae02be9069d3c312728c2e922d4132e0430846d64443b3e80bcae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7618360db76ae02be9069d3c312728c2e922d4132e0430846d64443b3e80bcae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7618360db76ae02be9069d3c312728c2e922d4132e0430846d64443b3e80bcae", kill_on_drop: false }` [INFO] [stdout] 7618360db76ae02be9069d3c312728c2e922d4132e0430846d64443b3e80bcae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa93f445b55d5f79a97d711a4c0875cb02bcc1130eae62e368630a06113ba624 [INFO] running `Command { std: "docker" "start" "-a" "aa93f445b55d5f79a97d711a4c0875cb02bcc1130eae62e368630a06113ba624", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking rle-decode-fast v1.0.1 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking miniz_oxide v0.4.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking tropico5-hpk-unpacker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / error_chain! { [INFO] [stdout] 16 | | foreign_links { [INFO] [stdout] 17 | | Fmt(::std::fmt::Error); [INFO] [stdout] 18 | | Io(::std::io::Error) #[cfg(unix)]; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / error_chain! { [INFO] [stdout] 16 | | foreign_links { [INFO] [stdout] 17 | | Fmt(::std::fmt::Error); [INFO] [stdout] 18 | | Io(::std::io::Error) #[cfg(unix)]; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / error_chain! { [INFO] [stdout] 16 | | foreign_links { [INFO] [stdout] 17 | | Fmt(::std::fmt::Error); [INFO] [stdout] 18 | | Io(::std::io::Error) #[cfg(unix)]; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / error_chain! { [INFO] [stdout] 16 | | foreign_links { [INFO] [stdout] 17 | | Fmt(::std::fmt::Error); [INFO] [stdout] 18 | | Io(::std::io::Error) #[cfg(unix)]; [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 129 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 130 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 129 | unimplemented!(); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 130 | Ok(()) [INFO] [stdout] | ^^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hpk.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hpk.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expanded_size` [INFO] [stdout] --> src/hpk.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 225 | let expanded_size: u64; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expanded_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `blocksize` [INFO] [stdout] --> src/hpk.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | let blocksize: u64; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_blocksize` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hpk.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expanded_size` [INFO] [stdout] --> src/hpk.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 225 | let expanded_size: u64; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expanded_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `blocksize` [INFO] [stdout] --> src/hpk.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | let blocksize: u64; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_blocksize` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hpk.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `display_path` [INFO] [stdout] --> src/main.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | let mut display_path = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `display_path` [INFO] [stdout] --> src/main.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | let mut display_path = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let mut display_path = String::new(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let mut display_path = String::new(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | let mut opts = Options::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | let mut opts = Options::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_archive` is never used [INFO] [stdout] --> src/main.rs:125:4 [INFO] [stdout] | [INFO] [stdout] 125 | fn list_archive(archive: &Archive) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `size` is never used [INFO] [stdout] --> src/hpk.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 84 | impl File { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn size(&self) -> u32 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_archive` is never used [INFO] [stdout] --> src/main.rs:125:4 [INFO] [stdout] | [INFO] [stdout] 125 | fn list_archive(archive: &Archive) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `size` is never used [INFO] [stdout] --> src/hpk.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 84 | impl File { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn size(&self) -> u32 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(FileDataPlain { [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | file: file, [INFO] [stdout] 115 | | size: fentry.size as u64, [INFO] [stdout] 116 | | base_offset: fentry.offset as u64, [INFO] [stdout] 117 | | cur_offset: 0, [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(FileDataPlain { [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | file: file, [INFO] [stdout] 115 | | size: fentry.size as u64, [INFO] [stdout] 116 | | base_offset: fentry.offset as u64, [INFO] [stdout] 117 | | cur_offset: 0, [INFO] [stdout] 118 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 223 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut plain = FileDataPlain::from(file, fentry)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(FileDataZlib { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | plain: plain, [INFO] [stdout] 235 | | size: expanded_size, [INFO] [stdout] 236 | | blocksize: blocksize, [INFO] [stdout] 237 | | cur_offset: 0u64, [INFO] [stdout] 238 | | cache: HashMap::new(), [INFO] [stdout] 239 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 223 | fn from(mut file: fs::File, fentry: &FileTableEntry) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut plain = FileDataPlain::from(file, fentry)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(FileDataZlib { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | plain: plain, [INFO] [stdout] 235 | | size: expanded_size, [INFO] [stdout] 236 | | blocksize: blocksize, [INFO] [stdout] 237 | | cur_offset: 0u64, [INFO] [stdout] 238 | | cache: HashMap::new(), [INFO] [stdout] 239 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/hpk.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | self.size - self.cur_offset; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 350 | let _ = self.size - self.cur_offset; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/hpk.rs:363:17 [INFO] [stdout] | [INFO] [stdout] 363 | / &mut buf[out_pos as usize..(out_pos + to_copy) as usize].copy_from_slice( [INFO] [stdout] 364 | | &blockdata[block_offset as usize..(block_offset + to_copy) as usize], [INFO] [stdout] 365 | | ); [INFO] [stdout] | |_________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 363 | let _ = &mut buf[out_pos as usize..(out_pos + to_copy) as usize].copy_from_slice( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/hpk.rs:436:40 [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = magic.into_iter(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = magic.iter(); [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = IntoIterator::into_iter(magic); [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:635:12 [INFO] [stdout] | [INFO] [stdout] 631 | let file = fs::File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | let basefile = file.try_clone()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 633 | let mut filereader = BufReader::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 634 | let filetbl_offset = ArchiveFile::read_header(&mut filereader)?; [INFO] [stdout] 635 | Ok(ArchiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 636 | | basefile: basefile, [INFO] [stdout] 637 | | reader: filereader, [INFO] [stdout] 638 | | filetbl_offset: filetbl_offset as u64, [INFO] [stdout] 639 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:647:12 [INFO] [stdout] | [INFO] [stdout] 645 | let mut file = ArchiveFile::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | let rootdir = file.read_rootdir()?; [INFO] [stdout] 647 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 648 | | file: file, [INFO] [stdout] 649 | | rootdir: rootdir, [INFO] [stdout] 650 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused arithmetic operation that must be used [INFO] [stdout] --> src/hpk.rs:350:13 [INFO] [stdout] | [INFO] [stdout] 350 | self.size - self.cur_offset; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the arithmetic operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 350 | let _ = self.size - self.cur_offset; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/hpk.rs:363:17 [INFO] [stdout] | [INFO] [stdout] 363 | / &mut buf[out_pos as usize..(out_pos + to_copy) as usize].copy_from_slice( [INFO] [stdout] 364 | | &blockdata[block_offset as usize..(block_offset + to_copy) as usize], [INFO] [stdout] 365 | | ); [INFO] [stdout] | |_________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 363 | let _ = &mut buf[out_pos as usize..(out_pos + to_copy) as usize].copy_from_slice( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&[T; N] as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to `<[T; N] as IntoIterator>::into_iter` in Rust 2021 [INFO] [stdout] --> src/hpk.rs:436:40 [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = magic.into_iter(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(array_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = magic.iter(); [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 436 | let mut magic_iter = IntoIterator::into_iter(magic); [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:635:12 [INFO] [stdout] | [INFO] [stdout] 631 | let file = fs::File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 632 | let basefile = file.try_clone()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 633 | let mut filereader = BufReader::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 634 | let filetbl_offset = ArchiveFile::read_header(&mut filereader)?; [INFO] [stdout] 635 | Ok(ArchiveFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 636 | | basefile: basefile, [INFO] [stdout] 637 | | reader: filereader, [INFO] [stdout] 638 | | filetbl_offset: filetbl_offset as u64, [INFO] [stdout] 639 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk.rs:647:12 [INFO] [stdout] | [INFO] [stdout] 645 | let mut file = ArchiveFile::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 646 | let rootdir = file.read_rootdir()?; [INFO] [stdout] 647 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 648 | | file: file, [INFO] [stdout] 649 | | rootdir: rootdir, [INFO] [stdout] 650 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tropico5-hpk-unpacker` (bin "tropico5-hpk-unpacker" test) due to 5 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tropico5-hpk-unpacker` (bin "tropico5-hpk-unpacker") due to 5 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa93f445b55d5f79a97d711a4c0875cb02bcc1130eae62e368630a06113ba624", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa93f445b55d5f79a97d711a4c0875cb02bcc1130eae62e368630a06113ba624", kill_on_drop: false }` [INFO] [stdout] aa93f445b55d5f79a97d711a4c0875cb02bcc1130eae62e368630a06113ba624