[INFO] cloning repository https://github.com/BoiseState/bookdata-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BoiseState/bookdata-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBoiseState%2Fbookdata-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBoiseState%2Fbookdata-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3305e9312ab258697b2f50580263c56ff7971562 [INFO] checking BoiseState/bookdata-tools/3305e9312ab258697b2f50580263c56ff7971562 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBoiseState%2Fbookdata-tools" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BoiseState/bookdata-tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BoiseState/bookdata-tools [INFO] finished tweaking git repo https://github.com/BoiseState/bookdata-tools [INFO] tweaked toml for git repo https://github.com/BoiseState/bookdata-tools written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BoiseState/bookdata-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 752849a3fe5e970db454784bf507cc4f9c0bc42ce5d9c6ca9a776a9af0fa0aa5 [INFO] running `Command { std: "docker" "start" "-a" "752849a3fe5e970db454784bf507cc4f9c0bc42ce5d9c6ca9a776a9af0fa0aa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "752849a3fe5e970db454784bf507cc4f9c0bc42ce5d9c6ca9a776a9af0fa0aa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "752849a3fe5e970db454784bf507cc4f9c0bc42ce5d9c6ca9a776a9af0fa0aa5", kill_on_drop: false }` [INFO] [stdout] 752849a3fe5e970db454784bf507cc4f9c0bc42ce5d9c6ca9a776a9af0fa0aa5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9070c87ed2d504ba2165c894e1b051ffaaea6327cbf8f72c9ec9d1700831bb44 [INFO] running `Command { std: "docker" "start" "-a" "9070c87ed2d504ba2165c894e1b051ffaaea6327cbf8f72c9ec9d1700831bb44", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling target-features v0.1.5 [INFO] [stderr] Checking array-init-cursor v0.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling polars-utils v0.37.0 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Compiling polars-arrow v0.37.0 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling polars-compute v0.37.0 [INFO] [stderr] Compiling polars-core v0.37.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling zstd-safe v7.0.0 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling polars-ops v0.37.0 [INFO] [stderr] Checking xxhash-rust v0.8.8 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking parquet-format-safe v0.2.4 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling indexmap v2.2.2 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling polars-plan v0.37.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking argminmax v0.6.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Compiling winnow v0.5.39 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling polars-lazy v0.37.0 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking proc-macro2 v1.0.78 [INFO] [stderr] Checking brotli v3.4.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling polars v0.37.0 [INFO] [stderr] Compiling zstd-sys v2.0.9+zstd.1.5.5 [INFO] [stderr] Compiling libz-ng-sys v1.1.15 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Compiling snmalloc-sys v0.3.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking friendly v0.1.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking cpu-time v1.0.0 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking relative-path v1.9.2 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.1 [INFO] [stderr] Compiling multiversion-macros v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking bytemuck v1.14.1 [INFO] [stderr] Checking multiversion v0.7.3 [INFO] [stderr] Compiling bd-macros v0.2.0 (/opt/rustwide/workdir/bd-macros) [INFO] [stderr] Compiling enum_dispatch v0.3.12 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Checking thiserror v1.0.56 [INFO] [stderr] Compiling test-log-macros v0.2.14 [INFO] [stderr] Compiling parse-display-derive v0.9.0 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking test-log v0.2.14 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking happylog v0.3.0-b7 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking parse-display v0.9.0 [INFO] [stderr] Checking zstd v0.13.0 [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking snmalloc-rs v0.3.4 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking polars-arrow-format v0.1.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rmp-serde v1.1.2 [INFO] [stderr] Checking serde_yaml v0.9.31 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking polars-error v0.37.0 [INFO] [stderr] Checking polars-row v0.37.0 [INFO] [stderr] Checking polars-parquet v0.37.0 [INFO] [stderr] Checking polars-time v0.37.0 [INFO] [stderr] Checking polars-io v0.37.0 [INFO] [stderr] Checking bookdata v3.0.0-dev (/opt/rustwide/workdir) [INFO] [stdout] warning: field `publication_day` is never read [INFO] [stdout] --> src/goodreads/book.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct RawBook { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub publication_day: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `read_at` and `started_at` are never read [INFO] [stdout] --> src/goodreads/review.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct RawReview { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | pub read_at: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 30 | pub started_at: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `original_publication_day` is never read [INFO] [stdout] --> src/goodreads/work.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct RawWork { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub original_publication_day: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fn_name` is never read [INFO] [stdout] --> src/ids/codes.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct NS<'a> { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn_name: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_interaction` and `save` are never used [INFO] [stdout] --> src/interactions/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub trait Dedup { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 23 | /// Save an item in the deduplciator. [INFO] [stdout] 24 | fn add_interaction(&mut self, act: I) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn save(&mut self, path: &Path) -> Result; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `input_files` is never used [INFO] [stdout] --> src/io/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait DataSink { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 29 | fn input_files(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/dfext.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn udf_clean_name(col: Series) -> PolarsResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let col = col.str()?; [INFO] [stdout] 9 | let res: StringChunked = col [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Some(res.into_series())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/dfext.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|f| ArrowField { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | is_nullable: df.column(&f.name).expect("missing column").null_count() > 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/reader.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn scan_parquet_file(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut reader = File::open(&path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let schema = infer_schema(&meta)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let reader = FileReader::new(reader, meta.row_groups, schema.clone(), None, None, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let pb = item_progress(row_count, &format!("{}", path.display())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let (send, receive) = bounded(5); [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(RecordIter { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | remaining: row_count, [INFO] [stdout] 100 | | channel: receive, [INFO] [stdout] 101 | | batch: None, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 34 | let frame = R::Frame::new(df)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(FrameRecordIter { [INFO] [stdout] | ________^ [INFO] [stdout] 36 | | frame, [INFO] [stdout] 37 | | size: df.height(), [INFO] [stdout] 38 | | pos: 0, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | res.ok_or(RowError::NullField(name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 295 | fn append_to_column(self, b: &mut Self::Builder) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | T::ColumnType::from(self).append_to_column(b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 304 | let val = T::ColumnType::read_from_column(name, a, pos)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | val.try_into() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/writer.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let schema = R::schema(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let writer = open_polars_writer(path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let writer = writer.batched(&schema)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let writer = writer.with_transform(vec_to_df); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let writer = ThreadObjectWriter::wrap(writer) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let writer = UnchunkWriter::with_size(writer, BATCH_SIZE); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let out_path = Some(path.to_path_buf()); [INFO] [stdout] 109 | Ok(TableWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | _phantom: PhantomData, [INFO] [stdout] 111 | | writer: Some(writer), [INFO] [stdout] 112 | | out_path, [INFO] [stdout] 113 | | row_count: 0, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/cluster/author_gender/clusters.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn all_clusters>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .ok_or(anyhow!("invalid unicode path"))?; [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let df = LazyFrame::scan_parquet(path, Default::default())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let df = df.select([col("cluster")]); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let clusters = df.collect()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(ids.into_iter().filter_map(identity).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 108 | let read = if src.path.ends_with(".csv") { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut counted: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(counted.expect("data frame with no columns")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 151 | .fold(None, |cur, df2| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Ok(cur [INFO] [stdout] | ____________________^ [INFO] [stdout] 153 | | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] 154 | | .or(Some(df2))) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:71 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:84 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/filter_marc.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 107 | send: Sender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let scanner = scan_parquet_file(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | let scanner = scanner; [INFO] [stdout] 115 | | let mut n = 0; [INFO] [stdout] 116 | | for rec in scanner { [INFO] [stdout] ... | [INFO] [stdout] 125 | | Ok(n) [INFO] [stdout] 126 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/goodreads/cluster.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 158 | fn project_and_sort(&self, frame: LazyFrame) -> LazyFrame { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | frame.select(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 160 | | col("user_id").alias("user"), [INFO] [stdout] 161 | | self.id_col().alias("item"), [INFO] [stdout] 162 | | (col("updated").cast(DataType::Int64)).alias("timestamp"), [INFO] [stdout] 163 | | col("rating"), [INFO] [stdout] 164 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/index_names.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 46 | send: Sender<(String, u32)>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let scanner = scan_parquet_file(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | let scanner = scanner; [INFO] [stdout] 53 | | let pb = item_progress(scanner.remaining() as u64, "fields"); [INFO] [stdout] 54 | | let mut n = 0; [INFO] [stdout] ... | [INFO] [stdout] 63 | | Ok(n) [INFO] [stdout] 64 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/author.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(AuthorWriter { writer, n_recs: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/book.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 91 | let id_out = TableWriter::open(ID_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let info_out = TableWriter::open(INFO_FILE)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let author_out = TableWriter::open(AUTHOR_FILE)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let series_out = TableWriter::open(SERIES_FILE)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok(BookWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | id_out, [INFO] [stdout] 97 | | info_out, [INFO] [stdout] 98 | | author_out, [INFO] [stdout] 99 | | series_out, [INFO] [stdout] 100 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/genres.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 39 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(BookGenreWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | genres: IdIndex::new(), [INFO] [stdout] 42 | | writer, [INFO] [stdout] 43 | | n_recs: 0, [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/interaction.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | let writer = TableWriter::open(OUT_FILE.resolve()?)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(IntWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | writer, [INFO] [stdout] 68 | | users: IdIndex::new(), [INFO] [stdout] 69 | | review_ids: HashSet::new(), [INFO] [stdout] 70 | | n_recs: 0, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/review.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 73 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let users = load_user_index()?.freeze(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let books = load_id_links()?; [INFO] [stdout] 76 | Ok(ReviewWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | writer, [INFO] [stdout] 78 | | users, [INFO] [stdout] 79 | | books, [INFO] [stdout] 80 | | n_recs: 0, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/work.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(WorkWriter { writer, n_recs: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:73:47 [INFO] [stdout] | [INFO] [stdout] 73 | let (_, v) = e.or_insert_with(|| (key.to_owned(), n + 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn load>(path: P, id_col: &str, key_col: &str) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let file = File::open(path.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let frame = ParquetReader::new(file).finish()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let iter = ic.into_iter().zip(kc.into_iter()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(IdIndex { map, frozen: false }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 177 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let input = csv::Reader::from_path(path)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let recs = input.into_deserialize(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | Ok(IdIndex { map, frozen: false }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/background.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(chan: R) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let (read, writer) = pipe()?; [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let jh = spawn(move || { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(ThreadRead { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | read, [INFO] [stdout] 43 | | handle: Some(jh), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/background.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new(chan: W) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let (read, writer) = pipe()?; [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let jh = spawn(move || { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(ThreadWrite { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | write: Some(writer), [INFO] [stdout] 79 | | handle: Some(jh), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/compress.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open_gzin_progress(path: &Path, pb: ProgressBar) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let read = open_progress(path, pb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let gzf = MultiGzDecoder::new(read); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let thr = ThreadRead::new(gzf)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let bfs = BufReader::new(thr); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Box::new(bfs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn open_gzip(path: &Path, pb: ProgressBar) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let read = open_gzin_progress(path, pb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(LineProcessor { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | reader: Box::new(read), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn records(self) -> Records { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Records { [INFO] [stdout] 76 | lines: self.reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn json_records(self) -> JSONRecords { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | JSONRecords { [INFO] [stdout] 84 | lines: self.reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/chunks.rs:64:20 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn with_size(delegate: W, size: usize) -> UnchunkWriter { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | chunk: Vec::with_capacity(size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/thread.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 86 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let (sender, receiver) = bounded(self.capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let pb = meter_bar(self.capacity, &format!("{} buffer", self.name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let rpb = pb.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let h = scope.spawn(move || ferry(receiver, self.writer, rpb)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | handle: WorkHandle::Scoped(h), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/thread.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn spawn(self) -> ThreadObjectWriter<'static, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let (sender, receiver) = bounded(self.capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let pb = meter_bar(self.capacity, &format!("{} buffer", self.name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let rpb = pb.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let h = spawn(move || ferry(receiver, self.writer, rpb)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | handle: WorkHandle::Static(h), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marc/book_fields.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 51 | let fields = TableWriter::open(ffn)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let fields = FieldOutput::new(fields); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let ids = TableWriter::open(idfn)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let isbns = TableWriter::open(isbnfn)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let authors = TableWriter::open(authfn)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok(BookOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | n_books: 0, [INFO] [stdout] 68 | | prefix: prefix.to_string(), [INFO] [stdout] 69 | | fields, [INFO] [stdout] ... | [INFO] [stdout] 72 | | authors, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marc/flat_fields.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let writer = TableWriter::open(path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Self::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/openlib/source.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 38 | let record = serde_json::from_str(data).map_err(|e| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Row { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | key: key.to_owned(), [INFO] [stdout] 47 | | record, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn data_progress(len: S) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | new_progress(len.try_into().expect("invalid length")).with_style( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn data_progress(len: S) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / ProgressStyle::default_bar() [INFO] [stdout] 84 | | .template(DATA_PROGRESS_TMPL) [INFO] [stdout] 85 | | .expect("template error"), [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn item_progress(len: S, name: &str) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let style = ProgressStyle::default_bar() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / new_progress(len.unwrap_or(0)) [INFO] [stdout] 107 | | .with_style(style) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn meter_bar(len: S, name: &str) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let style = ProgressStyle::default_bar() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | / new_progress(len.unwrap_or(0)) [INFO] [stdout] 123 | | .with_style(style) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `publication_day` is never read [INFO] [stdout] --> src/goodreads/book.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct RawBook { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 33 | pub publication_day: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `read_at` and `started_at` are never read [INFO] [stdout] --> src/goodreads/review.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct RawReview { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | pub read_at: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 30 | pub started_at: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `original_publication_day` is never read [INFO] [stdout] --> src/goodreads/work.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct RawWork { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub original_publication_day: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fn_name` is never read [INFO] [stdout] --> src/ids/codes.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct NS<'a> { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn_name: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_interaction` and `save` are never used [INFO] [stdout] --> src/interactions/mod.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub trait Dedup { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 23 | /// Save an item in the deduplciator. [INFO] [stdout] 24 | fn add_interaction(&mut self, act: I) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | fn save(&mut self, path: &Path) -> Result; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `input_files` is never used [INFO] [stdout] --> src/io/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait DataSink { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 29 | fn input_files(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/dfext.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn udf_clean_name(col: Series) -> PolarsResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let col = col.str()?; [INFO] [stdout] 9 | let res: StringChunked = col [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok(Some(res.into_series())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/dfext.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|f| ArrowField { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | is_nullable: df.column(&f.name).expect("missing column").null_count() > 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/reader.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn scan_parquet_file(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut reader = File::open(&path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | let schema = infer_schema(&meta)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let reader = FileReader::new(reader, meta.row_groups, schema.clone(), None, None, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let pb = item_progress(row_count, &format!("{}", path.display())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let (send, receive) = bounded(5); [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(RecordIter { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | remaining: row_count, [INFO] [stdout] 100 | | channel: receive, [INFO] [stdout] 101 | | batch: None, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 34 | let frame = R::Frame::new(df)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(FrameRecordIter { [INFO] [stdout] | ________^ [INFO] [stdout] 36 | | frame, [INFO] [stdout] 37 | | size: df.height(), [INFO] [stdout] 38 | | pos: 0, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 252 | res.ok_or(RowError::NullField(name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 295 | fn append_to_column(self, b: &mut Self::Builder) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | T::ColumnType::from(self).append_to_column(b) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/row.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 304 | let val = T::ColumnType::read_from_column(name, a, pos)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | val.try_into() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/writer.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let schema = R::schema(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let writer = open_polars_writer(path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let writer = writer.batched(&schema)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let writer = writer.with_transform(vec_to_df); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let writer = ThreadObjectWriter::wrap(writer) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let writer = UnchunkWriter::with_size(writer, BATCH_SIZE); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let out_path = Some(path.to_path_buf()); [INFO] [stdout] 109 | Ok(TableWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | _phantom: PhantomData, [INFO] [stdout] 111 | | writer: Some(writer), [INFO] [stdout] 112 | | out_path, [INFO] [stdout] 113 | | row_count: 0, [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/cluster/author_gender/clusters.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn all_clusters>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .ok_or(anyhow!("invalid unicode path"))?; [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let df = LazyFrame::scan_parquet(path, Default::default())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let df = df.select([col("cluster")]); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let clusters = df.collect()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(ids.into_iter().filter_map(identity).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 108 | let read = if src.path.ends_with(".csv") { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut counted: Option = None; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(counted.expect("data frame with no columns")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:152:20 [INFO] [stdout] | [INFO] [stdout] 151 | .fold(None, |cur, df2| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Ok(cur [INFO] [stdout] | ____________________^ [INFO] [stdout] 153 | | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] 154 | | .or(Some(df2))) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:58 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:71 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/collect_isbns.rs:153:84 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|df1: LazyFrame| df1.outer_join(df2.clone(), col("isbn"), col("isbn"))) [INFO] [stdout] | -------------- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/filter_marc.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 107 | send: Sender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let scanner = scan_parquet_file(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | let scanner = scanner; [INFO] [stdout] 115 | | let mut n = 0; [INFO] [stdout] 116 | | for rec in scanner { [INFO] [stdout] ... | [INFO] [stdout] 125 | | Ok(n) [INFO] [stdout] 126 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/goodreads/cluster.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 158 | fn project_and_sort(&self, frame: LazyFrame) -> LazyFrame { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | frame.select(&[ [INFO] [stdout] | _______________________^ [INFO] [stdout] 160 | | col("user_id").alias("user"), [INFO] [stdout] 161 | | self.id_col().alias("item"), [INFO] [stdout] 162 | | (col("updated").cast(DataType::Int64)).alias("timestamp"), [INFO] [stdout] 163 | | col("rating"), [INFO] [stdout] 164 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/index_names.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 46 | send: Sender<(String, u32)>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let scanner = scan_parquet_file(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | let scanner = scanner; [INFO] [stdout] 53 | | let pb = item_progress(scanner.remaining() as u64, "fields"); [INFO] [stdout] 54 | | let mut n = 0; [INFO] [stdout] ... | [INFO] [stdout] 63 | | Ok(n) [INFO] [stdout] 64 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/author.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(AuthorWriter { writer, n_recs: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/book.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 91 | let id_out = TableWriter::open(ID_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let info_out = TableWriter::open(INFO_FILE)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let author_out = TableWriter::open(AUTHOR_FILE)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let series_out = TableWriter::open(SERIES_FILE)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok(BookWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | id_out, [INFO] [stdout] 97 | | info_out, [INFO] [stdout] 98 | | author_out, [INFO] [stdout] 99 | | series_out, [INFO] [stdout] 100 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/genres.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 39 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(BookGenreWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | genres: IdIndex::new(), [INFO] [stdout] 42 | | writer, [INFO] [stdout] 43 | | n_recs: 0, [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/interaction.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 65 | let writer = TableWriter::open(OUT_FILE.resolve()?)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Ok(IntWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | writer, [INFO] [stdout] 68 | | users: IdIndex::new(), [INFO] [stdout] 69 | | review_ids: HashSet::new(), [INFO] [stdout] 70 | | n_recs: 0, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/review.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 73 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let users = load_user_index()?.freeze(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let books = load_id_links()?; [INFO] [stdout] 76 | Ok(ReviewWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | writer, [INFO] [stdout] 78 | | users, [INFO] [stdout] 79 | | books, [INFO] [stdout] 80 | | n_recs: 0, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/goodreads/work.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | let writer = TableWriter::open(OUT_FILE)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(WorkWriter { writer, n_recs: 0 }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:73:47 [INFO] [stdout] | [INFO] [stdout] 73 | let (_, v) = e.or_insert_with(|| (key.to_owned(), n + 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:168:12 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn load>(path: P, id_col: &str, key_col: &str) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let file = File::open(path.as_ref())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let frame = ParquetReader::new(file).finish()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let iter = ic.into_iter().zip(kc.into_iter()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | Ok(IdIndex { map, frozen: false }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ids/index.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 177 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let input = csv::Reader::from_path(path)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let recs = input.into_deserialize(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | [INFO] [stdout] 183 | let mut map = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | Ok(IdIndex { map, frozen: false }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/background.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(chan: R) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let (read, writer) = pipe()?; [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | let jh = spawn(move || { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(ThreadRead { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | read, [INFO] [stdout] 43 | | handle: Some(jh), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/background.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn new(chan: W) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let (read, writer) = pipe()?; [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let jh = spawn(move || { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Ok(ThreadWrite { [INFO] [stdout] | ____________^ [INFO] [stdout] 78 | | write: Some(writer), [INFO] [stdout] 79 | | handle: Some(jh), [INFO] [stdout] 80 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/compress.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn open_gzin_progress(path: &Path, pb: ProgressBar) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let read = open_progress(path, pb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let gzf = MultiGzDecoder::new(read); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let thr = ThreadRead::new(gzf)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let bfs = BufReader::new(thr); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Box::new(bfs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn open_gzip(path: &Path, pb: ProgressBar) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let read = open_gzin_progress(path, pb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(LineProcessor { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | reader: Box::new(read), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn records(self) -> Records { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Records { [INFO] [stdout] 76 | lines: self.reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/lines.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn json_records(self) -> JSONRecords { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | JSONRecords { [INFO] [stdout] 84 | lines: self.reader.lines(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/chunks.rs:64:20 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn with_size(delegate: W, size: usize) -> UnchunkWriter { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | chunk: Vec::with_capacity(size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/thread.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 86 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let (sender, receiver) = bounded(self.capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let pb = meter_bar(self.capacity, &format!("{} buffer", self.name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let rpb = pb.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let h = scope.spawn(move || ferry(receiver, self.writer, rpb)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | handle: WorkHandle::Scoped(h), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/object/thread.rs:123:21 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn spawn(self) -> ThreadObjectWriter<'static, T> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let (sender, receiver) = bounded(self.capacity); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let pb = meter_bar(self.capacity, &format!("{} buffer", self.name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let rpb = pb.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let h = spawn(move || ferry(receiver, self.writer, rpb)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | handle: WorkHandle::Static(h), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marc/book_fields.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 51 | let fields = TableWriter::open(ffn)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let fields = FieldOutput::new(fields); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let ids = TableWriter::open(idfn)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let isbns = TableWriter::open(isbnfn)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let authors = TableWriter::open(authfn)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok(BookOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | n_books: 0, [INFO] [stdout] 68 | | prefix: prefix.to_string(), [INFO] [stdout] 69 | | fields, [INFO] [stdout] ... | [INFO] [stdout] 72 | | authors, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marc/flat_fields.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let writer = TableWriter::open(path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(Self::new(writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/openlib/source.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 38 | let record = serde_json::from_str(data).map_err(|e| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Row { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | key: key.to_owned(), [INFO] [stdout] 47 | | record, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn data_progress(len: S) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | new_progress(len.try_into().expect("invalid length")).with_style( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn data_progress(len: S) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / ProgressStyle::default_bar() [INFO] [stdout] 84 | | .template(DATA_PROGRESS_TMPL) [INFO] [stdout] 85 | | .expect("template error"), [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn item_progress(len: S, name: &str) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let style = ProgressStyle::default_bar() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / new_progress(len.unwrap_or(0)) [INFO] [stdout] 107 | | .with_style(style) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/logging.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn meter_bar(len: S, name: &str) -> ProgressBar [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let style = ProgressStyle::default_bar() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | / new_progress(len.unwrap_or(0)) [INFO] [stdout] 123 | | .with_style(style) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 42 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bookdata` (bin "bookdata") due to 43 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 42 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bookdata` (bin "bookdata" test) due to 43 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9070c87ed2d504ba2165c894e1b051ffaaea6327cbf8f72c9ec9d1700831bb44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9070c87ed2d504ba2165c894e1b051ffaaea6327cbf8f72c9ec9d1700831bb44", kill_on_drop: false }` [INFO] [stdout] 9070c87ed2d504ba2165c894e1b051ffaaea6327cbf8f72c9ec9d1700831bb44