[INFO] cloning repository https://github.com/Bogda165/FileSearch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bogda165/FileSearch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogda165%2FFileSearch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogda165%2FFileSearch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 07989ee7715f7e57e8eaff4755eed82118ae15b8 [INFO] checking Bogda165/FileSearch/07989ee7715f7e57e8eaff4755eed82118ae15b8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBogda165%2FFileSearch" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Bogda165/FileSearch on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Bogda165/FileSearch [INFO] finished tweaking git repo https://github.com/Bogda165/FileSearch [INFO] tweaked toml for git repo https://github.com/Bogda165/FileSearch written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Bogda165/FileSearch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2b4c2859c13873fb1c2d7ef6f24597fd40ae7b996a86cc3e341b67212f90e04 [INFO] running `Command { std: "docker" "start" "-a" "f2b4c2859c13873fb1c2d7ef6f24597fd40ae7b996a86cc3e341b67212f90e04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2b4c2859c13873fb1c2d7ef6f24597fd40ae7b996a86cc3e341b67212f90e04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2b4c2859c13873fb1c2d7ef6f24597fd40ae7b996a86cc3e341b67212f90e04", kill_on_drop: false }` [INFO] [stdout] f2b4c2859c13873fb1c2d7ef6f24597fd40ae7b996a86cc3e341b67212f90e04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] acfcfd5ce045382b28b16bacd7c811b2f507aa940ae549bc03d42400f34ba442 [INFO] running `Command { std: "docker" "start" "-a" "acfcfd5ce045382b28b16bacd7c811b2f507aa940ae549bc03d42400f34ba442", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.199 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking db v0.1.0 (/opt/rustwide/workdir/src/db) [INFO] [stdout] warning: unused import: `SemanticVectorElement` [INFO] [stdout] --> src/db/src/image.rs:2:43 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::semantic_vector::{SemanticVec, SemanticVectorElement}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ErrorCode` [INFO] [stdout] --> src/db/src/database.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | use rusqlite::{Connection, ErrorCode}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SemanticVectorElement` [INFO] [stdout] --> src/db/src/image.rs:2:43 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::semantic_vector::{SemanticVec, SemanticVectorElement}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ErrorCode` [INFO] [stdout] --> src/db/src/database.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | use rusqlite::{Connection, ErrorCode}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fallible_iterator::FallibleIterator` [INFO] [stdout] --> src/db/src/database.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use fallible_iterator::FallibleIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fallible_iterator::FallibleIterator` [INFO] [stdout] --> src/db/src/database.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use fallible_iterator::FallibleIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | let mut rows = statement.query(()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/db/src/database.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | let mut rows = statement.query(()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Command` is never used [INFO] [stdout] --> src/db/src/database.rs:1:6 [INFO] [stdout] | [INFO] [stdout] 1 | enum Command { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Command` is never used [INFO] [stdout] --> src/db/src/database.rs:1:6 [INFO] [stdout] | [INFO] [stdout] 1 | enum Command { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/db/src/image.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | self.semantic_vector.save(connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = self.semantic_vector.save(connection); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/src/database.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 19 | let connection = Connection::open("database.db").expect("Connection::open"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Database { connection: Some(connection) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/db/src/image.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | self.semantic_vector.save(connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = self.semantic_vector.save(connection); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/db/src/database.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | item.save(self.connection.as_mut().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = item.save(self.connection.as_mut().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/src/database.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 19 | let connection = Connection::open("database.db").expect("Connection::open"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Database { connection: Some(connection) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/src/database.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 182 | let mut statement = self.connection.as_ref().unwrap() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | let mut rows = rows.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | [INFO] [stdout] 191 | Ok(rows.next().unwrap().is_some()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/db/src/database.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | item.save(self.connection.as_mut().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 86 | let _ = item.save(self.connection.as_mut().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/src/database.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 182 | let mut statement = self.connection.as_ref().unwrap() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let mut rows = statement.query(&[&path]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | let mut rows = rows.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | [INFO] [stdout] 191 | Ok(rows.next().unwrap().is_some()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `db` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `db` (lib) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "acfcfd5ce045382b28b16bacd7c811b2f507aa940ae549bc03d42400f34ba442", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acfcfd5ce045382b28b16bacd7c811b2f507aa940ae549bc03d42400f34ba442", kill_on_drop: false }` [INFO] [stdout] acfcfd5ce045382b28b16bacd7c811b2f507aa940ae549bc03d42400f34ba442