[INFO] cloning repository https://github.com/Bloeckchengrafik/ftswarm-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bloeckchengrafik/ftswarm-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBloeckchengrafik%2Fftswarm-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBloeckchengrafik%2Fftswarm-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 328ea8a46477fcd5c8bdc5c9415f4c8a3a645124 [INFO] checking Bloeckchengrafik/ftswarm-rs/328ea8a46477fcd5c8bdc5c9415f4c8a3a645124 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBloeckchengrafik%2Fftswarm-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Bloeckchengrafik/ftswarm-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Bloeckchengrafik/ftswarm-rs [INFO] finished tweaking git repo https://github.com/Bloeckchengrafik/ftswarm-rs [INFO] tweaked toml for git repo https://github.com/Bloeckchengrafik/ftswarm-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Bloeckchengrafik/ftswarm-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e0a38e404cad9fa99b26bc50369b526ce0ecf2f3b43b0ea002a6718df523014 [INFO] running `Command { std: "docker" "start" "-a" "0e0a38e404cad9fa99b26bc50369b526ce0ecf2f3b43b0ea002a6718df523014", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e0a38e404cad9fa99b26bc50369b526ce0ecf2f3b43b0ea002a6718df523014", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e0a38e404cad9fa99b26bc50369b526ce0ecf2f3b43b0ea002a6718df523014", kill_on_drop: false }` [INFO] [stdout] 0e0a38e404cad9fa99b26bc50369b526ce0ecf2f3b43b0ea002a6718df523014 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56212f89775144b0d14e04a1b7aba1f1ee67ca75058f31c3ca9710d7e739d23c [INFO] running `Command { std: "docker" "start" "-a" "56212f89775144b0d14e04a1b7aba1f1ee67ca75058f31c3ca9710d7e739d23c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling zerocopy v0.8.0-alpha.5 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking lock_api v0.4.11 [INFO] [stderr] Checking proc-macro2 v1.0.78 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Checking rand_core v0.9.0-alpha.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.0 [INFO] [stderr] Checking rand v0.9.0-alpha.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking ftswarm_macros v0.2.2 (/opt/rustwide/workdir/crates/ftswarm_macros) [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking unescaper v0.1.4 [INFO] [stderr] Checking serialport v4.3.0 [INFO] [stderr] Checking ftswarm_proto v0.2.2 (/opt/rustwide/workdir/crates/ftswarm_proto) [INFO] [stderr] Checking ftswarm_serial v0.2.2 (/opt/rustwide/workdir/crates/ftswarm_serial) [INFO] [stderr] Checking ftswarm_emulator v0.2.3 (/opt/rustwide/workdir/crates/ftswarm_emulator) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> crates/ftswarm_proto/examples/proto_messageparser.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | Err(e) => println!("Error: {}", e), [INFO] [stdout] | ^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> crates/ftswarm_proto/examples/proto_messageparser.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | Err(e) => println!("Error: {}", e), [INFO] [stdout] | ^^^^^^ matches no values because `Infallible` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ftswarm v0.2.2 (/opt/rustwide/workdir/crates/ftswarm) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/lib.rs:109:19 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(mut serial: Serial) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let inner = Arc::new(Mutex::new(InnerFtSwarm::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let inner_for_thread = inner.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let handle = tokio::spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | coro: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/message_queue.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 29 | let (s, r) = mpsc::channel(1); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | (SenderHandle::new(s), r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/servo.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Box::new(Servo { [INFO] [stdout] | __________________^ [INFO] [stdout] 18 | | name: name.to_string(), [INFO] [stdout] 19 | | swarm [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/led.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Box::new(Led { [INFO] [stdout] | __________________^ [INFO] [stdout] 18 | | name: name.to_string(), [INFO] [stdout] 19 | | swarm [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/controller.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Box::new(Controller { [INFO] [stdout] | __________________^ [INFO] [stdout] 19 | | name: name.to_string(), [INFO] [stdout] 20 | | swarm [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/lib.rs:109:19 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(mut serial: Serial) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let inner = Arc::new(Mutex::new(InnerFtSwarm::new())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | [INFO] [stdout] 96 | let inner_for_thread = inner.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let handle = tokio::spawn(async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | coro: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/message_queue.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 29 | let (s, r) = mpsc::channel(1); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | (SenderHandle::new(s), r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/servo.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Box::new(Servo { [INFO] [stdout] | __________________^ [INFO] [stdout] 18 | | name: name.to_string(), [INFO] [stdout] 19 | | swarm [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/led.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 16 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Box::new(Led { [INFO] [stdout] | __________________^ [INFO] [stdout] 18 | | name: name.to_string(), [INFO] [stdout] 19 | | swarm [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ftswarm` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/ftswarm/src/swarm_object/controller.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(name: &str, swarm: FtSwarm, _params: ()) -> Box { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Box::new(Controller { [INFO] [stdout] | __________________^ [INFO] [stdout] 19 | | name: name.to_string(), [INFO] [stdout] 20 | | swarm [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ftswarm` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "56212f89775144b0d14e04a1b7aba1f1ee67ca75058f31c3ca9710d7e739d23c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56212f89775144b0d14e04a1b7aba1f1ee67ca75058f31c3ca9710d7e739d23c", kill_on_drop: false }` [INFO] [stdout] 56212f89775144b0d14e04a1b7aba1f1ee67ca75058f31c3ca9710d7e739d23c