[INFO] cloning repository https://github.com/BlaiseBaptist/monster_battle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BlaiseBaptist/monster_battle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBlaiseBaptist%2Fmonster_battle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBlaiseBaptist%2Fmonster_battle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 886d3025144ef07e4094285a12eba66fcc9b9926 [INFO] checking BlaiseBaptist/monster_battle/886d3025144ef07e4094285a12eba66fcc9b9926 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBlaiseBaptist%2Fmonster_battle" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BlaiseBaptist/monster_battle on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BlaiseBaptist/monster_battle [INFO] finished tweaking git repo https://github.com/BlaiseBaptist/monster_battle [INFO] tweaked toml for git repo https://github.com/BlaiseBaptist/monster_battle written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BlaiseBaptist/monster_battle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e837acdb0d4a12551975b870409dd094ebcd7a441134bbe28cda043431da29b7 [INFO] running `Command { std: "docker" "start" "-a" "e837acdb0d4a12551975b870409dd094ebcd7a441134bbe28cda043431da29b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e837acdb0d4a12551975b870409dd094ebcd7a441134bbe28cda043431da29b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e837acdb0d4a12551975b870409dd094ebcd7a441134bbe28cda043431da29b7", kill_on_drop: false }` [INFO] [stdout] e837acdb0d4a12551975b870409dd094ebcd7a441134bbe28cda043431da29b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93b9b51b2bda6a19f026aa1598a38601f783d8344026fcaaff6046174f2fb1d4 [INFO] running `Command { std: "docker" "start" "-a" "93b9b51b2bda6a19f026aa1598a38601f783d8344026fcaaff6046174f2fb1d4", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.91 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.91 [INFO] [stderr] Checking pad v0.1.5 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking monster v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/server.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | fn set_up() -> (Team) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - fn set_up() -> (Team) { [INFO] [stdout] 231 + fn set_up() -> Team { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/server.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | (team) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - (team) [INFO] [stdout] 238 + team [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:20:34 [INFO] [stdout] | [INFO] [stdout] 20 | fn attack(&self, other: &mut Monster, round: i32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | fn attack(&self, other: &mut dyn Monster, round: i32) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 58 | monsters: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | monsters: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/server.rs:231:16 [INFO] [stdout] | [INFO] [stdout] 231 | fn set_up() -> (Team) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 231 - fn set_up() -> (Team) { [INFO] [stdout] 231 + fn set_up() -> Team { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/server.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | (team) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - (team) [INFO] [stdout] 238 + team [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:20:34 [INFO] [stdout] | [INFO] [stdout] 20 | fn attack(&self, other: &mut Monster, round: i32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | fn attack(&self, other: &mut dyn Monster, round: i32) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 58 | monsters: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | monsters: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | fn attack(&self, other: &mut Monster, round: i32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 111 | fn attack(&self, other: &mut dyn Monster, round: i32) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/server.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | fn attack(&self, other: &mut Monster, round: i32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 111 | fn attack(&self, other: &mut dyn Monster, round: i32) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:11:21 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monster` (bin "client") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `monster` (bin "client" test) due to 2 previous errors [INFO] [stdout] warning: method `star_check` is never used [INFO] [stdout] --> src/server.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 14 | trait Monster: Send { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 31 | fn star_check(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `stars` is never read [INFO] [stdout] --> src/server.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct Logic { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | stars: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `money`, `name`, `level`, and `id` are never read [INFO] [stdout] --> src/server.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 44 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 45 | team: Team, [INFO] [stdout] 46 | money: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 47 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | level: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 49 | id: u128, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `star_check` is never used [INFO] [stdout] --> src/server.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 93 | impl Logic { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 94 | fn star_check(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 172 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `star_check` is never used [INFO] [stdout] --> src/server.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 14 | trait Monster: Send { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 31 | fn star_check(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `stars` is never read [INFO] [stdout] --> src/server.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct Logic { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | stars: i32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `money`, `name`, `level`, and `id` are never read [INFO] [stdout] --> src/server.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 44 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 45 | team: Team, [INFO] [stdout] 46 | money: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 47 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 48 | level: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 49 | id: u128, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `star_check` is never used [INFO] [stdout] --> src/server.rs:94:8 [INFO] [stdout] | [INFO] [stdout] 93 | impl Logic { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 94 | fn star_check(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monster` (bin "server") due to 3 previous errors; 9 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 172 | #[derive(Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monster` (bin "server" test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93b9b51b2bda6a19f026aa1598a38601f783d8344026fcaaff6046174f2fb1d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93b9b51b2bda6a19f026aa1598a38601f783d8344026fcaaff6046174f2fb1d4", kill_on_drop: false }` [INFO] [stdout] 93b9b51b2bda6a19f026aa1598a38601f783d8344026fcaaff6046174f2fb1d4