[INFO] cloning repository https://github.com/Bha-Gu/tree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Bha-Gu/tree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBha-Gu%2Ftree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBha-Gu%2Ftree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4d54235b92752e88c4bf7170ad4e01923a874b7a [INFO] checking Bha-Gu/tree/4d54235b92752e88c4bf7170ad4e01923a874b7a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBha-Gu%2Ftree" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Bha-Gu/tree on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Bha-Gu/tree [INFO] finished tweaking git repo https://github.com/Bha-Gu/tree [INFO] tweaked toml for git repo https://github.com/Bha-Gu/tree written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Bha-Gu/tree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 819a3d8ffbbf5231f49022d07a3d9b42612048f2a8729ecec0a255b2543bd64b [INFO] running `Command { std: "docker" "start" "-a" "819a3d8ffbbf5231f49022d07a3d9b42612048f2a8729ecec0a255b2543bd64b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "819a3d8ffbbf5231f49022d07a3d9b42612048f2a8729ecec0a255b2543bd64b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "819a3d8ffbbf5231f49022d07a3d9b42612048f2a8729ecec0a255b2543bd64b", kill_on_drop: false }` [INFO] [stdout] 819a3d8ffbbf5231f49022d07a3d9b42612048f2a8729ecec0a255b2543bd64b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f902e299b495461296a1a72281086eda558cb3b745fb7775bcf97d33fcd93a45 [INFO] running `Command { std: "docker" "start" "-a" "f902e299b495461296a1a72281086eda558cb3b745fb7775bcf97d33fcd93a45", kill_on_drop: false }` [INFO] [stderr] Checking linked v0.1.0 (https://github.com/Bha-Gu/linked#6725c0c7) [INFO] [stderr] Checking tree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/binary/search_tree.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | let mut root_node = *root_pointer; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/binary/search_tree.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | let mut root_node = *root_pointer; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `dfs_order_search` and `order` are never used [INFO] [stdout] --> src/binary/search_tree.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 63 | impl BinarySearchTree { [INFO] [stdout] | ----------------------------------------------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | pub fn dfs_order_search(&self, order: DFSType) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | fn order(curr: &BTNode, path: &mut Vec, order: DFSType) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary/search_tree.rs:151:57 [INFO] [stdout] | [INFO] [stdout] 151 | let root_push = { |path: &mut Vec| path.push(curr.value.clone()) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary/tree.rs:155:57 [INFO] [stdout] | [INFO] [stdout] 155 | let root_push = { |path: &mut Vec| path.push(curr.value.clone()) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `dfs_order_search` and `order` are never used [INFO] [stdout] --> src/binary/search_tree.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 63 | impl BinarySearchTree { [INFO] [stdout] | ----------------------------------------------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | pub fn dfs_order_search(&self, order: DFSType) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | fn order(curr: &BTNode, path: &mut Vec, order: DFSType) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary/search_tree.rs:151:57 [INFO] [stdout] | [INFO] [stdout] 151 | let root_push = { |path: &mut Vec| path.push(curr.value.clone()) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary/tree.rs:155:57 [INFO] [stdout] | [INFO] [stdout] 155 | let root_push = { |path: &mut Vec| path.push(curr.value.clone()) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree` (bin "tree") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tree` (bin "tree" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f902e299b495461296a1a72281086eda558cb3b745fb7775bcf97d33fcd93a45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f902e299b495461296a1a72281086eda558cb3b745fb7775bcf97d33fcd93a45", kill_on_drop: false }` [INFO] [stdout] f902e299b495461296a1a72281086eda558cb3b745fb7775bcf97d33fcd93a45