[INFO] cloning repository https://github.com/BenjaminDavidPinter/who_are_you [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BenjaminDavidPinter/who_are_you" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenjaminDavidPinter%2Fwho_are_you", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenjaminDavidPinter%2Fwho_are_you'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5232dd6a31d8c7b4db16effb2b7056eee6d918a9 [INFO] checking BenjaminDavidPinter/who_are_you/5232dd6a31d8c7b4db16effb2b7056eee6d918a9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenjaminDavidPinter%2Fwho_are_you" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BenjaminDavidPinter/who_are_you on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BenjaminDavidPinter/who_are_you [INFO] finished tweaking git repo https://github.com/BenjaminDavidPinter/who_are_you [INFO] tweaked toml for git repo https://github.com/BenjaminDavidPinter/who_are_you written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BenjaminDavidPinter/who_are_you already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 182066c3a127b40228b81360f875e18c2c2f8a9cebb7ec66502c567c731ae949 [INFO] running `Command { std: "docker" "start" "-a" "182066c3a127b40228b81360f875e18c2c2f8a9cebb7ec66502c567c731ae949", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "182066c3a127b40228b81360f875e18c2c2f8a9cebb7ec66502c567c731ae949", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "182066c3a127b40228b81360f875e18c2c2f8a9cebb7ec66502c567c731ae949", kill_on_drop: false }` [INFO] [stdout] 182066c3a127b40228b81360f875e18c2c2f8a9cebb7ec66502c567c731ae949 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6af66dcf32ab48a9396d3d8815e594021afe874b601ed446c206ad8042176339 [INFO] running `Command { std: "docker" "start" "-a" "6af66dcf32ab48a9396d3d8815e594021afe874b601ed446c206ad8042176339", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking soundex v0.2.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking who_are_you v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `fs` [INFO] [stdout] --> src/main.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env, fs}; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `self` [INFO] [stdout] --> src/main.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prelude` [INFO] [stdout] --> src/main.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs` [INFO] [stdout] --> src/main.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{env, fs}; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufReader` and `self` [INFO] [stdout] --> src/main.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | let mut new_person = PersonName::new(arg); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `provided_name`, `name_parts`, `initials`, and `name_sounds` are never read [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | struct PersonName { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 8 | provided_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 9 | name_parts: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 10 | initials: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 11 | name_sounds: Vec [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PersonName` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `personName` should have a snake case name [INFO] [stdout] --> src/main.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(personName: String) -> PersonName { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `person_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | let re = Regex::new(pattern).unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | re.split(&s).into_iter().map(|x| String::from(x)).filter(|x| !String::is_empty(x)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `who_are_you` (bin "who_are_you") due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `prelude` [INFO] [stdout] --> src/main.rs:2:21 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{self, prelude::*, BufReader}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 56 | let mut new_person = PersonName::new(arg); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `provided_name`, `initials`, and `name_sounds` are never read [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | struct PersonName { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 8 | provided_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 9 | name_parts: Vec, [INFO] [stdout] 10 | initials: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 11 | name_sounds: Vec [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PersonName` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `personName` should have a snake case name [INFO] [stdout] --> src/main.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(personName: String) -> PersonName { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `person_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | let re = Regex::new(pattern).unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | re.split(&s).into_iter().map(|x| String::from(x)).filter(|x| !String::is_empty(x)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Deconstruct` should have a snake case name [INFO] [stdout] --> src/main.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn Deconstruct() { [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `deconstruct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `Initialism` should have a snake case name [INFO] [stdout] --> src/main.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn Initialism() { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `initialism` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `who_are_you` (bin "who_are_you" test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6af66dcf32ab48a9396d3d8815e594021afe874b601ed446c206ad8042176339", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6af66dcf32ab48a9396d3d8815e594021afe874b601ed446c206ad8042176339", kill_on_drop: false }` [INFO] [stdout] 6af66dcf32ab48a9396d3d8815e594021afe874b601ed446c206ad8042176339