[INFO] cloning repository https://github.com/BenMcAvoy/Jamd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BenMcAvoy/Jamd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenMcAvoy%2FJamd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenMcAvoy%2FJamd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6adcaaec61a96e79f04af12fee97e66a639e7c0a [INFO] checking BenMcAvoy/Jamd/6adcaaec61a96e79f04af12fee97e66a639e7c0a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBenMcAvoy%2FJamd" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BenMcAvoy/Jamd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BenMcAvoy/Jamd [INFO] finished tweaking git repo https://github.com/BenMcAvoy/Jamd [INFO] tweaked toml for git repo https://github.com/BenMcAvoy/Jamd written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BenMcAvoy/Jamd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8eda476bb7eae51f6abc293ee10e1d1b3bf9dd6bd02a2223e01f565774885890 [INFO] running `Command { std: "docker" "start" "-a" "8eda476bb7eae51f6abc293ee10e1d1b3bf9dd6bd02a2223e01f565774885890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8eda476bb7eae51f6abc293ee10e1d1b3bf9dd6bd02a2223e01f565774885890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8eda476bb7eae51f6abc293ee10e1d1b3bf9dd6bd02a2223e01f565774885890", kill_on_drop: false }` [INFO] [stdout] 8eda476bb7eae51f6abc293ee10e1d1b3bf9dd6bd02a2223e01f565774885890 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1ab9220964fb810306a4bbe8701877acfa9ee01301ec1d98daaf3d1af18ed94 [INFO] running `Command { std: "docker" "start" "-a" "c1ab9220964fb810306a4bbe8701877acfa9ee01301ec1d98daaf3d1af18ed94", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking termion v3.0.0 [INFO] [stderr] Checking jamd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `StatementKind` and `Statement` [INFO] [stdout] --> src/ast/evaluator.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | NumberExpression, Statement, StatementKind, Visitor, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `StatementKind` and `Statement` [INFO] [stdout] --> src/ast/evaluator.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | NumberExpression, Statement, StatementKind, Visitor, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arrow_pointers` [INFO] [stdout] --> src/diagnostics/printer.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let arrow_pointers = format!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arrow_pointers` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arrow_pointers` [INFO] [stdout] --> src/diagnostics/printer.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let arrow_pointers = format!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arrow_pointers` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `values` is never read [INFO] [stdout] --> src/ast/evaluator.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Evaluator { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | pub last_value: Option, [INFO] [stdout] 9 | pub values: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get` are never used [INFO] [stdout] --> src/ast/counter.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 8 | impl Counter { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 9 | pub const fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn get(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_newline` is never used [INFO] [stdout] --> src/ast/tree.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Printer { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 66 | fn add_newline(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INDENT_SIZE` is never used [INFO] [stdout] --> src/ast/tree.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | const INDENT_SIZE: usize = 2; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Warning` is never constructed [INFO] [stdout] --> src/diagnostics/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum DiagnosticKind { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 9 | Warning, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `kind` is never read [INFO] [stdout] --> src/diagnostics/mod.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Diagnostic { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub kind: DiagnosticKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `report_warning` is never used [INFO] [stdout] --> src/diagnostics/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Bag { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn report_warning(&mut self, message: String, span: TextSpan) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | |file| std::fs::read_to_string(file).expect("Failed to read file"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 151 | pub const fn expression(expression: Expression) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Self::new(StatementKind::Expression(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:225:19 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn binary(left: Self, right: Self, operator: BinaryOperator) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | Self::new(ExpressionKind::Binary(BinaryExpression { [INFO] [stdout] | ___________________^ [INFO] [stdout] 226 | | left: Box::new(left), [INFO] [stdout] 227 | | right: Box::new(right), [INFO] [stdout] 228 | | operator, [INFO] [stdout] 229 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn parenthesized(kind: ExpressionKind) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Self::new(ExpressionKind::Parenthesized(ParenthesizedExpression { [INFO] [stdout] | ___________________^ [INFO] [stdout] 234 | | expression: Box::new(Self::new(kind)), [INFO] [stdout] 235 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `values` is never read [INFO] [stdout] --> src/ast/evaluator.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Evaluator { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 8 | pub last_value: Option, [INFO] [stdout] 9 | pub values: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get` are never used [INFO] [stdout] --> src/ast/counter.rs:9:18 [INFO] [stdout] | [INFO] [stdout] 8 | impl Counter { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 9 | pub const fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn get(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_newline` is never used [INFO] [stdout] --> src/ast/tree.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Printer { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 66 | fn add_newline(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INDENT_SIZE` is never used [INFO] [stdout] --> src/ast/tree.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | const INDENT_SIZE: usize = 2; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Warning` is never constructed [INFO] [stdout] --> src/diagnostics/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum DiagnosticKind { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 9 | Warning, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `kind` is never read [INFO] [stdout] --> src/diagnostics/mod.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Diagnostic { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | pub kind: DiagnosticKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `report_warning` is never used [INFO] [stdout] --> src/diagnostics/mod.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 34 | impl Bag { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn report_warning(&mut self, message: String, span: TextSpan) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | |file| std::fs::read_to_string(file).expect("Failed to read file"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 151 | pub const fn expression(expression: Expression) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Self::new(StatementKind::Expression(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:225:19 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn binary(left: Self, right: Self, operator: BinaryOperator) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | Self::new(ExpressionKind::Binary(BinaryExpression { [INFO] [stdout] | ___________________^ [INFO] [stdout] 226 | | left: Box::new(left), [INFO] [stdout] 227 | | right: Box::new(right), [INFO] [stdout] 228 | | operator, [INFO] [stdout] 229 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/tree.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn parenthesized(kind: ExpressionKind) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Self::new(ExpressionKind::Parenthesized(ParenthesizedExpression { [INFO] [stdout] | ___________________^ [INFO] [stdout] 234 | | expression: Box::new(Self::new(kind)), [INFO] [stdout] 235 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jamd` (bin "jamd") due to 5 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `jamd` (bin "jamd" test) due to 5 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1ab9220964fb810306a4bbe8701877acfa9ee01301ec1d98daaf3d1af18ed94", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1ab9220964fb810306a4bbe8701877acfa9ee01301ec1d98daaf3d1af18ed94", kill_on_drop: false }` [INFO] [stdout] c1ab9220964fb810306a4bbe8701877acfa9ee01301ec1d98daaf3d1af18ed94