[INFO] cloning repository https://github.com/Ben435/simple-opengl-renderer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ben435/simple-opengl-renderer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBen435%2Fsimple-opengl-renderer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBen435%2Fsimple-opengl-renderer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f3bd20c6ff807553e9a3fadaa1295ac3972e011 [INFO] checking Ben435/simple-opengl-renderer/3f3bd20c6ff807553e9a3fadaa1295ac3972e011 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBen435%2Fsimple-opengl-renderer" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Ben435/simple-opengl-renderer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Ben435/simple-opengl-renderer [INFO] finished tweaking git repo https://github.com/Ben435/simple-opengl-renderer [INFO] tweaked toml for git repo https://github.com/Ben435/simple-opengl-renderer written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Ben435/simple-opengl-renderer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7894a3c5dbd0ffb672bb406c09f39e33103d5c4451b2205aff7896e3b2ac7e53 [INFO] running `Command { std: "docker" "start" "-a" "7894a3c5dbd0ffb672bb406c09f39e33103d5c4451b2205aff7896e3b2ac7e53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7894a3c5dbd0ffb672bb406c09f39e33103d5c4451b2205aff7896e3b2ac7e53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7894a3c5dbd0ffb672bb406c09f39e33103d5c4451b2205aff7896e3b2ac7e53", kill_on_drop: false }` [INFO] [stdout] 7894a3c5dbd0ffb672bb406c09f39e33103d5c4451b2205aff7896e3b2ac7e53 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34121cb923260d20b56423a7730676cc70a229263c8145d5e392550dcb3d538b [INFO] running `Command { std: "docker" "start" "-a" "34121cb923260d20b56423a7730676cc70a229263c8145d5e392550dcb3d538b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Compiling cgmath v0.17.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking tobj v2.0.2 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling cmake v0.1.44 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling glfw-sys v3.3.2 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking glfw v0.40.0 [INFO] [stderr] Checking simple_opengl_renderer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/model.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 92 | let mesh = GlMesh::from_vertices(vertices, indices); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Some(Object { [INFO] [stdout] | __________________^ [INFO] [stdout] 101 | | mesh, [INFO] [stdout] 102 | | material, [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_shader.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 69 | Err(e) => panic!(format!("Failed to translate String to CString: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 69 - Err(e) => panic!(format!("Failed to translate String to CString: {}", e)), [INFO] [stdout] 69 + Err(e) => panic!("Failed to translate String to CString: {}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_shader.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | panic!(format!("Failed to find location for uniform: {}", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 74 - panic!(format!("Failed to find location for uniform: {}", name)); [INFO] [stdout] 74 + panic!("Failed to find location for uniform: {}", name); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/ogl/gl_mesh.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 79 | let vbo = GlBuffer::new(&vertices); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let mut vao = GlVertexArray::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ebo: GlIndexBuffer::new(&indices), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_errors.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | panic!(format!("Gl error set!: {}", err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 14 - panic!(format!("Gl error set!: {}", err)); [INFO] [stdout] 14 + panic!("Gl error set!: {}", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 35 | let mut file = fs::File::open(resource_name_to_path(&self.root_path, resource_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(unsafe { ffi::CString::from_vec_unchecked(buffer) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/model.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 92 | let mesh = GlMesh::from_vertices(vertices, indices); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Some(Object { [INFO] [stdout] | __________________^ [INFO] [stdout] 101 | | mesh, [INFO] [stdout] 102 | | material, [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_shader.rs:69:30 [INFO] [stdout] | [INFO] [stdout] 69 | Err(e) => panic!(format!("Failed to translate String to CString: {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 69 - Err(e) => panic!(format!("Failed to translate String to CString: {}", e)), [INFO] [stdout] 69 + Err(e) => panic!("Failed to translate String to CString: {}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_shader.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | panic!(format!("Failed to find location for uniform: {}", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 74 - panic!(format!("Failed to find location for uniform: {}", name)); [INFO] [stdout] 74 + panic!("Failed to find location for uniform: {}", name); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/ogl/gl_mesh.rs:85:18 [INFO] [stdout] | [INFO] [stdout] 79 | let vbo = GlBuffer::new(&vertices); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let mut vao = GlVertexArray::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | ebo: GlIndexBuffer::new(&indices), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/render/ogl/gl_errors.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | panic!(format!("Gl error set!: {}", err)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 14 - panic!(format!("Gl error set!: {}", err)); [INFO] [stdout] 14 + panic!("Gl error set!: {}", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 35 | let mut file = fs::File::open(resource_name_to_path(&self.root_path, resource_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(unsafe { ffi::CString::from_vec_unchecked(buffer) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_opengl_renderer` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple_opengl_renderer` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "34121cb923260d20b56423a7730676cc70a229263c8145d5e392550dcb3d538b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34121cb923260d20b56423a7730676cc70a229263c8145d5e392550dcb3d538b", kill_on_drop: false }` [INFO] [stdout] 34121cb923260d20b56423a7730676cc70a229263c8145d5e392550dcb3d538b