[INFO] updating cached repository https://github.com/BRonen/dsa-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a1a79c6ed9bcc2a6d36a39c2aa249c8754b40e29 [INFO] checking BRonen/dsa-rs/a1a79c6ed9bcc2a6d36a39c2aa249c8754b40e29 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBRonen%2Fdsa-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BRonen/dsa-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BRonen/dsa-rs [INFO] finished tweaking git repo https://github.com/BRonen/dsa-rs [INFO] tweaked toml for git repo https://github.com/BRonen/dsa-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BRonen/dsa-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98fac3f6d770c1c7937e8dcbd1395076c2763d2964dc871056438aac3f5fb39c [INFO] running `Command { std: "docker" "start" "-a" "98fac3f6d770c1c7937e8dcbd1395076c2763d2964dc871056438aac3f5fb39c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98fac3f6d770c1c7937e8dcbd1395076c2763d2964dc871056438aac3f5fb39c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98fac3f6d770c1c7937e8dcbd1395076c2763d2964dc871056438aac3f5fb39c", kill_on_drop: false }` [INFO] [stdout] 98fac3f6d770c1c7937e8dcbd1395076c2763d2964dc871056438aac3f5fb39c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 170ba0670d1aae92a2a300aa8c27e6137b979c9ec6034cc580f90f61bbef4f59 [INFO] running `Command { std: "docker" "start" "-a" "170ba0670d1aae92a2a300aa8c27e6137b979c9ec6034cc580f90f61bbef4f59", kill_on_drop: false }` [INFO] [stderr] Checking dsa-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `bubble_sort_silly` is never used [INFO] [stdout] --> src/sortings/bubble_sort.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn bubble_sort_silly(mut array: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bubble_sort` is never used [INFO] [stdout] --> src/sortings/bubble_sort.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn bubble_sort(mut array: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `merge_sort` is never used [INFO] [stdout] --> src/sortings/merge_sort.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn merge_sort(mut array: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quick_sort` is never used [INFO] [stdout] --> src/sortings/quick_sort.rs:1:4 [INFO] [stdout] | [INFO] [stdout] 1 | fn quick_sort(mut array: Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Leaf` and `Node` are never constructed [INFO] [stdout] --> src/trees/binary_tree.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum Tree { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 3 | Leaf(A), [INFO] [stdout] | ^^^^ [INFO] [stdout] 4 | Node(Box>, Box>), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/trees/binary_tree.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Tree { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 8 | pub fn new(values: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Node` and `Leaf` are never constructed [INFO] [stdout] --> src/trees/binary_search_tree.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum Tree { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 3 | Node(A, Box>, Box>), [INFO] [stdout] | ^^^^ [INFO] [stdout] 4 | Leaf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Tree` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `insert` are never used [INFO] [stdout] --> src/trees/binary_search_tree.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Tree { [INFO] [stdout] | --------------------------- associated items in this implementation [INFO] [stdout] 8 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | pub fn insert(self, node: A) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trees/binary_tree.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 33 | let tree = Tree::new(vec![1, 2, 3, 4]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | / Tree::Node( [INFO] [stdout] 38 | | Box::new( [INFO] [stdout] 39 | | Tree::Node( [INFO] [stdout] 40 | | Box::new( [INFO] [stdout] ... | [INFO] [stdout] 57 | | ) [INFO] [stdout] 58 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trees/binary_tree.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 64 | let tree = Tree::new(vec![ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / Tree::Node( [INFO] [stdout] 74 | | Box::new( [INFO] [stdout] 75 | | Tree::Node( [INFO] [stdout] 76 | | Box::new( [INFO] [stdout] ... | [INFO] [stdout] 289 | | ) [INFO] [stdout] 290 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsa-rs` (bin "dsa-rs" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "170ba0670d1aae92a2a300aa8c27e6137b979c9ec6034cc580f90f61bbef4f59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "170ba0670d1aae92a2a300aa8c27e6137b979c9ec6034cc580f90f61bbef4f59", kill_on_drop: false }` [INFO] [stdout] 170ba0670d1aae92a2a300aa8c27e6137b979c9ec6034cc580f90f61bbef4f59