[INFO] cloning repository https://github.com/BOTBrad/block [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/BOTBrad/block" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBOTBrad%2Fblock", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBOTBrad%2Fblock'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c93f187d7957075972a3b70273c40b41857e1d8f [INFO] checking BOTBrad/block/c93f187d7957075972a3b70273c40b41857e1d8f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FBOTBrad%2Fblock" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/BOTBrad/block on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/BOTBrad/block [INFO] finished tweaking git repo https://github.com/BOTBrad/block [INFO] tweaked toml for git repo https://github.com/BOTBrad/block written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/BOTBrad/block already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d20a70e06a7d82f12302881bc8bbfee1f8d7a06d76b692a55a90e74c23516ce [INFO] running `Command { std: "docker" "start" "-a" "2d20a70e06a7d82f12302881bc8bbfee1f8d7a06d76b692a55a90e74c23516ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d20a70e06a7d82f12302881bc8bbfee1f8d7a06d76b692a55a90e74c23516ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d20a70e06a7d82f12302881bc8bbfee1f8d7a06d76b692a55a90e74c23516ce", kill_on_drop: false }` [INFO] [stdout] 2d20a70e06a7d82f12302881bc8bbfee1f8d7a06d76b692a55a90e74c23516ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4d2baf218db46cb65b78a45d212b58d0ec3bedb0298e4b07c9b544bf613914b [INFO] running `Command { std: "docker" "start" "-a" "a4d2baf218db46cb65b78a45d212b58d0ec3bedb0298e4b07c9b544bf613914b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking svg v0.5.10 [INFO] [stderr] Checking block v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `point::Point` [INFO] [stdout] --> src/blockl/fragment.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use point::Point; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pen::Pen` [INFO] [stdout] --> src/pen/frag_writer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use pen::Pen; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Pen` and `Writer` [INFO] [stdout] --> src/main.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | use pen::{FragWriter, Pen, Writer}; [INFO] [stdout] | ^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `point::Point` [INFO] [stdout] --> src/blockl/fragment.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use point::Point; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pen::Pen` [INFO] [stdout] --> src/pen/frag_writer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use pen::Pen; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f64::consts::PI` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::f64::consts::PI; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Pen` and `Writer` [INFO] [stdout] --> src/main.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | use pen::{FragWriter, Pen, Writer}; [INFO] [stdout] | ^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `angle` [INFO] [stdout] --> src/pen/frag_writer.rs:118:38 [INFO] [stdout] | [INFO] [stdout] 118 | fn thickness_rotate(pts: Vec, angle: f64) -> (f64, f64) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `angle` [INFO] [stdout] --> src/pen/frag_writer.rs:118:38 [INFO] [stdout] | [INFO] [stdout] 118 | fn thickness_rotate(pts: Vec, angle: f64) -> (f64, f64) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_angle` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | let mut p = Path::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:38:7 [INFO] [stdout] | [INFO] [stdout] 38 | let mut document = Document::new() [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width`, `height`, and `path` are never read [INFO] [stdout] --> src/pen/frag_writer.rs:12:3 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct FragWriter { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | width: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | height: f64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `thickness_rotate` is never used [INFO] [stdout] --> src/pen/frag_writer.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn thickness_rotate(pts: Vec, angle: f64) -> (f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pen` is never constructed [INFO] [stdout] --> src/pen/pen.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Pen { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `by`, `move_by`, `get_starting_pairs`, and `done` are never used [INFO] [stdout] --> src/pen/pen.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 18 | impl Pen { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(w: f64, h: f64, angle: f64, style: Path) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn by(&mut self, distance: f64, angle: f64) -> &mut Self { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn move_by(&mut self, distance: f64, angle: f64) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | fn get_starting_pairs(&self) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn done(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | let mut p = Path::new() [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:38:7 [INFO] [stdout] | [INFO] [stdout] 38 | let mut document = Document::new() [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width`, `height`, and `path` are never read [INFO] [stdout] --> src/pen/frag_writer.rs:12:3 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct FragWriter { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | width: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | height: f64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | path: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `thickness_rotate` is never used [INFO] [stdout] --> src/pen/frag_writer.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn thickness_rotate(pts: Vec, angle: f64) -> (f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pen` is never constructed [INFO] [stdout] --> src/pen/pen.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Pen { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Writer` is never constructed [INFO] [stdout] --> src/pen/writer.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Writer { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `by`, `move_by`, `get_starting_pairs`, and `done` are never used [INFO] [stdout] --> src/pen/pen.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 18 | impl Pen { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(w: f64, h: f64, angle: f64, style: Path) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn by(&mut self, distance: f64, angle: f64) -> &mut Self { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn move_by(&mut self, distance: f64, angle: f64) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 66 | fn get_starting_pairs(&self) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn done(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Writer` is never constructed [INFO] [stdout] --> src/pen/writer.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Writer { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/pen/writer.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 13 | impl Writer { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 14 | pub fn new(pen: Pen) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn lozenge(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn vertical(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn half_vertical(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | fn vertical_impl(&mut self, scalar: f64) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn arch(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn done(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/pen/writer.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 13 | impl Writer { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 14 | pub fn new(pen: Pen) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn lozenge(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn vertical(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn half_vertical(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | fn vertical_impl(&mut self, scalar: f64) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn arch(&mut self) -> &mut Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn done(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rotate_by` is never used [INFO] [stdout] --> src/point/point.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl Point { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn rotate_by(self, angle: f64) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rotate_by` is never used [INFO] [stdout] --> src/point/point.rs:28:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl Point { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn rotate_by(self, angle: f64) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pen/pen.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(w: f64, h: f64, angle: f64, style: Path) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | parts: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pen/pen.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(w: f64, h: f64, angle: f64, style: Path) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | parts: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `block` (bin "block" test) due to 2 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `block` (bin "block") due to 2 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a4d2baf218db46cb65b78a45d212b58d0ec3bedb0298e4b07c9b544bf613914b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4d2baf218db46cb65b78a45d212b58d0ec3bedb0298e4b07c9b544bf613914b", kill_on_drop: false }` [INFO] [stdout] a4d2baf218db46cb65b78a45d212b58d0ec3bedb0298e4b07c9b544bf613914b