[INFO] cloning repository https://github.com/Axel-Jacobsen/mmmbacktest [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Axel-Jacobsen/mmmbacktest" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAxel-Jacobsen%2Fmmmbacktest", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAxel-Jacobsen%2Fmmmbacktest'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 09cbea6c0257e8558d1afb2a94df7b4af8b01cb3 [INFO] checking Axel-Jacobsen/mmmbacktest/09cbea6c0257e8558d1afb2a94df7b4af8b01cb3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAxel-Jacobsen%2Fmmmbacktest" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Axel-Jacobsen/mmmbacktest on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Axel-Jacobsen/mmmbacktest [INFO] finished tweaking git repo https://github.com/Axel-Jacobsen/mmmbacktest [INFO] tweaked toml for git repo https://github.com/Axel-Jacobsen/mmmbacktest written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Axel-Jacobsen/mmmbacktest already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d42dba8e597bd2c78cd78c78bd206f16b47a88a144e57609235b1b7675edc574 [INFO] running `Command { std: "docker" "start" "-a" "d42dba8e597bd2c78cd78c78bd206f16b47a88a144e57609235b1b7675edc574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d42dba8e597bd2c78cd78c78bd206f16b47a88a144e57609235b1b7675edc574", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d42dba8e597bd2c78cd78c78bd206f16b47a88a144e57609235b1b7675edc574", kill_on_drop: false }` [INFO] [stdout] d42dba8e597bd2c78cd78c78bd206f16b47a88a144e57609235b1b7675edc574 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c7afb27db02cafca226308fcf1431c7192f2628e6674eb6ac6cdd118942d8fc [INFO] running `Command { std: "docker" "start" "-a" "1c7afb27db02cafca226308fcf1431c7192f2628e6674eb6ac6cdd118942d8fc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.73 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking unicase v2.7.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling libsqlite3-sys v0.27.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling quote v1.0.34 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking rusqlite v0.30.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking r2d2_sqlite v0.23.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.53 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking thiserror v1.0.53 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking h2 v0.3.22 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking warp v0.3.6 [INFO] [stderr] Checking mmmbacktest v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | |row| Ok(rusqlite_row_to_litemarket(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | |row| Ok(rusqlite_row_to_litemarket(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:196:18 [INFO] [stdout] | [INFO] [stdout] 196 | |row| Ok(rusqlite_row_to_bet(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | |row| Ok(rusqlite_row_to_user(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/bet_table.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 11 | let paths = fs::read_dir(bets_dir).unwrap_or_else(|err| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let progress_bar = ProgressBar::new(total_files as u64); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let paths = fs::read_dir(bets_dir).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | paths.filter_map(move |entry| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 42 | | if let Ok(e) = entry { [INFO] [stdout] 43 | | let path = e.path(); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/db_common.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | let manager = SqliteConnectionManager::file("mmmbacktest.db"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok(Arc::new(r2d2::Pool::new(manager)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mmmbacktest` (bin "mmmbacktest") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | |row| Ok(rusqlite_row_to_litemarket(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | |row| Ok(rusqlite_row_to_litemarket(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:196:18 [INFO] [stdout] | [INFO] [stdout] 196 | |row| Ok(rusqlite_row_to_bet(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/mod.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | |row| Ok(rusqlite_row_to_user(row)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/bet_table.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 11 | let paths = fs::read_dir(bets_dir).unwrap_or_else(|err| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let progress_bar = ProgressBar::new(total_files as u64); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let paths = fs::read_dir(bets_dir).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | paths.filter_map(move |entry| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 42 | | if let Ok(e) = entry { [INFO] [stdout] 43 | | let path = e.path(); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db/db_common.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | let manager = SqliteConnectionManager::file("mmmbacktest.db"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok(Arc::new(r2d2::Pool::new(manager)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mmmbacktest` (bin "mmmbacktest" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1c7afb27db02cafca226308fcf1431c7192f2628e6674eb6ac6cdd118942d8fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c7afb27db02cafca226308fcf1431c7192f2628e6674eb6ac6cdd118942d8fc", kill_on_drop: false }` [INFO] [stdout] 1c7afb27db02cafca226308fcf1431c7192f2628e6674eb6ac6cdd118942d8fc