[INFO] cloning repository https://github.com/AvaCity/avacity-test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AvaCity/avacity-test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAvaCity%2Favacity-test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAvaCity%2Favacity-test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be63d4a1e809f468914cb50c511b90a3e1188f70 [INFO] checking AvaCity/avacity-test/be63d4a1e809f468914cb50c511b90a3e1188f70 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAvaCity%2Favacity-test" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AvaCity/avacity-test on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AvaCity/avacity-test [INFO] finished tweaking git repo https://github.com/AvaCity/avacity-test [INFO] tweaked toml for git repo https://github.com/AvaCity/avacity-test written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AvaCity/avacity-test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Updating bytes v0.5.4 -> v0.5.6 (latest: v1.7.1) [INFO] [stderr] Updating hex v0.4.0 -> v0.4.3 [INFO] [stderr] Updating roxmltree v0.11.0 -> v0.13.1 (latest: v0.20.0) [INFO] [stderr] Updating xmlparser v0.13.1 -> v0.13.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2770e7a3794b4677a5c1e8373a03bdf1b3ef31adc10a175a07ccd9eed8ec165d [INFO] running `Command { std: "docker" "start" "-a" "2770e7a3794b4677a5c1e8373a03bdf1b3ef31adc10a175a07ccd9eed8ec165d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2770e7a3794b4677a5c1e8373a03bdf1b3ef31adc10a175a07ccd9eed8ec165d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2770e7a3794b4677a5c1e8373a03bdf1b3ef31adc10a175a07ccd9eed8ec165d", kill_on_drop: false }` [INFO] [stdout] 2770e7a3794b4677a5c1e8373a03bdf1b3ef31adc10a175a07ccd9eed8ec165d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1fc8370b61473d495fb88edb3453ec390be59909df6b7b9c945bd12d37c0a7f9 [INFO] running `Command { std: "docker" "start" "-a" "1fc8370b61473d495fb88edb3453ec390be59909df6b7b9c945bd12d37c0a7f9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking dtoa v0.4.5 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking combine v4.2.1 [INFO] [stderr] Checking roxmltree v0.13.1 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Compiling async-trait v0.1.33 [INFO] [stderr] Checking redis v0.17.0 [INFO] [stderr] Checking avacity v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/location.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let mut current_player = player_data.get_mut(&client.uid).ok_or("Can't get mut")?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `encrypted` and `compressed` are never read [INFO] [stdout] --> src/client.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | pub encrypted: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | pub compressed: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn new(stream: TcpStream, modules: Arc>>>, [INFO] [stdout] | ----------------- ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | player_data: Arc>>) -> Client { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Client { [INFO] [stdout] 213 | stream: Mutex::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn new(stream: TcpStream, modules: Arc>>>, [INFO] [stdout] | ----------------- ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | player_data: Arc>>) -> Client { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | redis: redis::Client::open("redis://127.0.0.1/").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avacity` (bin "avacity" test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `encrypted` and `compressed` are never read [INFO] [stdout] --> src/client.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | pub encrypted: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 31 | pub compressed: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn new(stream: TcpStream, modules: Arc>>>, [INFO] [stdout] | ----------------- ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | player_data: Arc>>) -> Client { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Client { [INFO] [stdout] 213 | stream: Mutex::new(stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn new(stream: TcpStream, modules: Arc>>>, [INFO] [stdout] | ----------------- ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | player_data: Arc>>) -> Client { [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | redis: redis::Client::open("redis://127.0.0.1/").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avacity` (bin "avacity") due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1fc8370b61473d495fb88edb3453ec390be59909df6b7b9c945bd12d37c0a7f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fc8370b61473d495fb88edb3453ec390be59909df6b7b9c945bd12d37c0a7f9", kill_on_drop: false }` [INFO] [stdout] 1fc8370b61473d495fb88edb3453ec390be59909df6b7b9c945bd12d37c0a7f9