[INFO] cloning repository https://github.com/Aurailus/Scout [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Aurailus/Scout" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAurailus%2FScout", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAurailus%2FScout'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d98d3bd8ed942b763cc3ecba8de258e333dacfa9 [INFO] checking Aurailus/Scout/d98d3bd8ed942b763cc3ecba8de258e333dacfa9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAurailus%2FScout" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Aurailus/Scout on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Aurailus/Scout [INFO] finished tweaking git repo https://github.com/Aurailus/Scout [INFO] tweaked toml for git repo https://github.com/Aurailus/Scout written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Aurailus/Scout already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a7ebadaf6dd32b6fecbdc6d4c5091faa1a3c20dc2ba8cd7e17421a4caddb237 [INFO] running `Command { std: "docker" "start" "-a" "0a7ebadaf6dd32b6fecbdc6d4c5091faa1a3c20dc2ba8cd7e17421a4caddb237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a7ebadaf6dd32b6fecbdc6d4c5091faa1a3c20dc2ba8cd7e17421a4caddb237", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a7ebadaf6dd32b6fecbdc6d4c5091faa1a3c20dc2ba8cd7e17421a4caddb237", kill_on_drop: false }` [INFO] [stdout] 0a7ebadaf6dd32b6fecbdc6d4c5091faa1a3c20dc2ba8cd7e17421a4caddb237 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 409f5569edf897aa2eca0049dc873506fe2ea018b5a387811c69ba0948e71d29 [INFO] running `Command { std: "docker" "start" "-a" "409f5569edf897aa2eca0049dc873506fe2ea018b5a387811c69ba0948e71d29", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling strum v0.18.0 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.14 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking futures-channel v0.3.14 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking futures-task v0.3.14 [INFO] [stderr] Checking futures-io v0.3.14 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling gio v0.9.1 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling gdk-pixbuf v0.9.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling pango v0.9.1 [INFO] [stderr] Compiling cairo-rs v0.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling gdk v0.13.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling atk v0.9.0 [INFO] [stderr] Checking lexical-core v0.7.6 [INFO] [stderr] Compiling gtk v0.9.2 [INFO] [stderr] Compiling whoami v1.1.2 [INFO] [stderr] Checking convert_case v0.4.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking shell-words v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Checking opener v0.4.1 [INFO] [stderr] Compiling scout-core v0.0.1 (/opt/rustwide/workdir/core) [INFO] [stderr] Checking colorsys v0.6.3 [INFO] [stderr] Checking system_shutdown v3.0.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling futures-macro v0.3.14 [INFO] [stderr] Compiling thiserror v1.0.24 [INFO] [stderr] Checking freedesktop_entry_parser v1.1.2 [INFO] [stderr] Checking futures-util v0.3.14 [INFO] [stderr] Checking futures-executor v0.3.14 [INFO] [stderr] Checking futures v0.3.14 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling system-deps v1.3.2 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling glib-macros v0.10.1 [INFO] [stderr] Compiling glib-sys v0.10.1 [INFO] [stderr] Compiling gobject-sys v0.10.0 [INFO] [stderr] Compiling gio-sys v0.10.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Compiling pango-sys v0.10.0 [INFO] [stderr] Compiling cairo-sys-rs v0.10.0 [INFO] [stderr] Compiling atk-sys v0.10.0 [INFO] [stderr] Compiling gdk-sys v0.10.0 [INFO] [stderr] Compiling gtk-sys v0.10.0 [INFO] [stderr] Checking glib v0.10.3 [INFO] [stdout] warning: `extern` fn uses type `Shared>`, which is not FFI-safe [INFO] [stdout] --> core/src/lib.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | pub register: unsafe extern "C" fn(Shared>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] note: the type is defined here [INFO] [stdout] --> core/src/shared.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Shared { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/shared.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(t: T) -> Shared { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Shared { v: Rc::new(RefCell::new(t)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> core/src/shared.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | write!(f, "{}", self.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Shared` does not implement `Deref`, so calling `deref` on `&Shared` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 119 - write!(f, "{}", self.deref()) [INFO] [stdout] 119 + write!(f, "{}", self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Shared`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Clone)] [INFO] [stdout] 18 | pub struct Shared { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> core/src/shared.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | write!(f, "{:?}", self.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Shared` does not implement `Deref`, so calling `deref` on `&Shared` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 126 - write!(f, "{:?}", self.deref()) [INFO] [stdout] 126 + write!(f, "{:?}", self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Shared`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Clone)] [INFO] [stdout] 18 | pub struct Shared { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scout-core` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: `extern` fn uses type `Shared>`, which is not FFI-safe [INFO] [stdout] --> core/src/lib.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | pub register: unsafe extern "C" fn(Shared>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct [INFO] [stdout] = note: this struct has unspecified layout [INFO] [stdout] note: the type is defined here [INFO] [stdout] --> core/src/shared.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Shared { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(improper_ctypes_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/src/shared.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new(t: T) -> Shared { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Shared { v: Rc::new(RefCell::new(t)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> core/src/shared.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 119 | write!(f, "{}", self.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Shared` does not implement `Deref`, so calling `deref` on `&Shared` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 119 - write!(f, "{}", self.deref()) [INFO] [stdout] 119 + write!(f, "{}", self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Shared`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Clone)] [INFO] [stdout] 18 | pub struct Shared { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> core/src/shared.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | write!(f, "{:?}", self.deref()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Shared` does not implement `Deref`, so calling `deref` on `&Shared` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 126 - write!(f, "{:?}", self.deref()) [INFO] [stdout] 126 + write!(f, "{:?}", self) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Shared`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Clone)] [INFO] [stdout] 18 | pub struct Shared { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scout-core` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "409f5569edf897aa2eca0049dc873506fe2ea018b5a387811c69ba0948e71d29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "409f5569edf897aa2eca0049dc873506fe2ea018b5a387811c69ba0948e71d29", kill_on_drop: false }` [INFO] [stdout] 409f5569edf897aa2eca0049dc873506fe2ea018b5a387811c69ba0948e71d29