[INFO] cloning repository https://github.com/Atom0713/kth_id2203_replicated_state_machine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Atom0713/kth_id2203_replicated_state_machine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAtom0713%2Fkth_id2203_replicated_state_machine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAtom0713%2Fkth_id2203_replicated_state_machine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3e79093c436b8bbfbc2bd285ccdc032194fe973a [INFO] checking Atom0713/kth_id2203_replicated_state_machine/3e79093c436b8bbfbc2bd285ccdc032194fe973a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAtom0713%2Fkth_id2203_replicated_state_machine" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 81% (723/892) Updating files: 82% (732/892) Updating files: 83% (741/892) Updating files: 84% (750/892) Updating files: 85% (759/892) Updating files: 86% (768/892) Updating files: 87% (777/892) Updating files: 88% (785/892) Updating files: 89% (794/892) Updating files: 90% (803/892) Updating files: 91% (812/892) Updating files: 92% (821/892) Updating files: 93% (830/892) Updating files: 94% (839/892) Updating files: 95% (848/892) Updating files: 96% (857/892) Updating files: 97% (866/892) Updating files: 98% (875/892) Updating files: 99% (884/892) Updating files: 100% (892/892) Updating files: 100% (892/892), done. [INFO] validating manifest of git repo https://github.com/Atom0713/kth_id2203_replicated_state_machine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Atom0713/kth_id2203_replicated_state_machine [INFO] finished tweaking git repo https://github.com/Atom0713/kth_id2203_replicated_state_machine [INFO] tweaked toml for git repo https://github.com/Atom0713/kth_id2203_replicated_state_machine written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Atom0713/kth_id2203_replicated_state_machine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f20c2910d724e1c7a5e8023a70413c732bee21a8c0be0800d69d4b2f7c2bfb2b [INFO] running `Command { std: "docker" "start" "-a" "f20c2910d724e1c7a5e8023a70413c732bee21a8c0be0800d69d4b2f7c2bfb2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f20c2910d724e1c7a5e8023a70413c732bee21a8c0be0800d69d4b2f7c2bfb2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f20c2910d724e1c7a5e8023a70413c732bee21a8c0be0800d69d4b2f7c2bfb2b", kill_on_drop: false }` [INFO] [stdout] f20c2910d724e1c7a5e8023a70413c732bee21a8c0be0800d69d4b2f7c2bfb2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09ab265bde646e522a1b4ddd3944627aa5754eb038653a646b1db29657b03a90 [INFO] running `Command { std: "docker" "start" "-a" "09ab265bde646e522a1b4ddd3944627aa5754eb038653a646b1db29657b03a90", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking commitlog v0.2.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling omnipaxos_macros v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking omnipaxos v0.2.2 [INFO] [stderr] Checking omnipaxos_storage v0.2.2 [INFO] [stderr] Checking omni-spacetimedb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/durability/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DurabilityLayer` [INFO] [stdout] --> src/node/mod.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::durability::{DurabilityLayer, DurabilityLevel}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::messages::*` [INFO] [stdout] --> src/node/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use omnipaxos::messages::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/node/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::sync::mpsc` [INFO] [stdout] --> src/node/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/durability/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DurabilityLayer` [INFO] [stdout] --> src/node/mod.rs:6:25 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::durability::{DurabilityLayer, DurabilityLevel}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::messages::*` [INFO] [stdout] --> src/node/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use omnipaxos::messages::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/node/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::sync::mpsc` [INFO] [stdout] --> src/node/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::node::*` [INFO] [stdout] --> src/node/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | use crate::node::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `omnipaxos::messages::Message` [INFO] [stdout] --> src/node/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | use omnipaxos::messages::Message; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/node/mod.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/node/mod.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Builder` and `Runtime` [INFO] [stdout] --> src/node/mod.rs:101:26 [INFO] [stdout] | [INFO] [stdout] 101 | use tokio::runtime::{Builder, Runtime}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::sync::mpsc` [INFO] [stdout] --> src/node/mod.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | use tokio::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio::task::JoinHandle` [INFO] [stdout] --> src/node/mod.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | use tokio::task::JoinHandle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `offset` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | offset: TxOffset, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | fn append_tx(&mut self, tx_offset: TxOffset, tx_data: TxData) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_data` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:21:50 [INFO] [stdout] | [INFO] [stdout] 21 | fn append_tx(&mut self, tx_offset: TxOffset, tx_data: TxData) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node_id` [INFO] [stdout] --> src/node/mod.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability) -> Self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_node_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `omni_durability` [INFO] [stdout] --> src/node/mod.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_omni_durability` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `durability_level` [INFO] [stdout] --> src/node/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | durability_level: DurabilityLevel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_durability_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/node/mod.rs:60:30 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn release_tx(&self, tx: >::Tx) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/node/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | tx: >::MutTx, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_outgoing_msgs` is never used [INFO] [stdout] --> src/node/mod.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 18 | impl NodeRunner { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 19 | async fn send_outgoing_msgs(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `node_id` is never read [INFO] [stdout] --> src/node/mod.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Node { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 29 | node_id: NodeId, // Unique identifier for the node [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `apply_replicated_txns` and `advance_replicated_durability_offset` are never used [INFO] [stdout] --> src/node/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 33 | impl Node { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | fn apply_replicated_txns(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | fn advance_replicated_durability_offset( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 240 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | tx_offset: offset, [INFO] [stdout] 283 | | tx_data, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:275:38 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 149 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 150 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 151 | | Err(_) => None, [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb") due to 11 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `offset` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | offset: TxOffset, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_offset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_offset` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | fn append_tx(&mut self, tx_offset: TxOffset, tx_data: TxData) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_offset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx_data` [INFO] [stdout] --> src/durability/omnipaxos_durability.rs:21:50 [INFO] [stdout] | [INFO] [stdout] 21 | fn append_tx(&mut self, tx_offset: TxOffset, tx_data: TxData) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_tx_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node_id` [INFO] [stdout] --> src/node/mod.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability) -> Self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_node_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `omni_durability` [INFO] [stdout] --> src/node/mod.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(node_id: NodeId, omni_durability: OmniPaxosDurability) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_omni_durability` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `durability_level` [INFO] [stdout] --> src/node/mod.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | durability_level: DurabilityLevel, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_durability_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/node/mod.rs:60:30 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn release_tx(&self, tx: >::Tx) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/node/mod.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | tx: >::MutTx, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/durability/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct ObserverId(u64); [INFO] [stdout] | ---------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ObserverId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_outgoing_msgs` is never used [INFO] [stdout] --> src/node/mod.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 18 | impl NodeRunner { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 19 | async fn send_outgoing_msgs(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `node_id` is never read [INFO] [stdout] --> src/node/mod.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Node { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 29 | node_id: NodeId, // Unique identifier for the node [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `apply_replicated_txns` and `advance_replicated_durability_offset` are never used [INFO] [stdout] --> src/node/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 33 | impl Node { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | fn apply_replicated_txns(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | fn advance_replicated_durability_offset( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVERS` is never used [INFO] [stdout] --> src/node/mod.rs:105:11 [INFO] [stdout] | [INFO] [stdout] 105 | const SERVERS: [NodeId; 3] = [1, 2, 3]; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 240 | mut tx: Self::MutTx, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let tx_data = TxData { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | Ok(TxResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 282 | | tx_offset: offset, [INFO] [stdout] 283 | | tx_data, [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:268:38 [INFO] [stdout] | [INFO] [stdout] 268 | .map(|s| RowData(Arc::from(serialize_example_row(s).unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/example_datastore.rs:275:38 [INFO] [stdout] | [INFO] [stdout] 275 | .map(|s| RowData(Arc::from(s.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(RowData(Arc::from(buffer.into_boxed_slice()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 71 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(InsertList { [INFO] [stdout] | ________^ [INFO] [stdout] 76 | | table_id, [INFO] [stdout] 77 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 95 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(DeleteList { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | table_id, [INFO] [stdout] 101 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datastore/tx_data/serde.rs:152:12 [INFO] [stdout] | [INFO] [stdout] 133 | let mut inserts = Vec::with_capacity(num_inserts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut deletes = Vec::with_capacity(num_deletes); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(TxData { [INFO] [stdout] | ____________^ [INFO] [stdout] 153 | | inserts: Arc::from(inserts.into_boxed_slice()), [INFO] [stdout] 154 | | deletes: Arc::from(deletes.into_boxed_slice()), [INFO] [stdout] 155 | | truncs: Arc::from(truncs.into_boxed_slice()), [INFO] [stdout] 156 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | let tx_data = TxData::deserialize(reader)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(LogEntry { tx_offset, tx_data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Box::new(std::iter::from_fn(move || { [INFO] [stdout] | __________________^ [INFO] [stdout] 149 | | match LogEntry::deserialize(&mut file) { [INFO] [stdout] 150 | | Ok(log_entry) => Some((log_entry.tx_offset, log_entry.tx_data)), [INFO] [stdout] 151 | | Err(_) => None, [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/durability/example_durability.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 145 | let mut file = File::open(&self.filepath).expect("Failed to open log file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match LogEntry::deserialize(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 25 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `omni-spacetimedb` (bin "omni-spacetimedb" test) due to 11 previous errors; 25 warnings emitted [INFO] running `Command { std: "docker" "inspect" "09ab265bde646e522a1b4ddd3944627aa5754eb038653a646b1db29657b03a90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09ab265bde646e522a1b4ddd3944627aa5754eb038653a646b1db29657b03a90", kill_on_drop: false }` [INFO] [stdout] 09ab265bde646e522a1b4ddd3944627aa5754eb038653a646b1db29657b03a90