[INFO] cloning repository https://github.com/AshTS/ASCIIGraphicsRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AshTS/ASCIIGraphicsRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAshTS%2FASCIIGraphicsRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAshTS%2FASCIIGraphicsRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 93b66784b91f5acf7f96fe32dda9b6fe76d9095a [INFO] checking AshTS/ASCIIGraphicsRust/93b66784b91f5acf7f96fe32dda9b6fe76d9095a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAshTS%2FASCIIGraphicsRust" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AshTS/ASCIIGraphicsRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AshTS/ASCIIGraphicsRust [INFO] finished tweaking git repo https://github.com/AshTS/ASCIIGraphicsRust [INFO] tweaked toml for git repo https://github.com/AshTS/ASCIIGraphicsRust written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AshTS/ASCIIGraphicsRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06e01bc18c8cebcf830e289f1f6d66e80f64109511e175f0b5a8992b37adc3e6 [INFO] running `Command { std: "docker" "start" "-a" "06e01bc18c8cebcf830e289f1f6d66e80f64109511e175f0b5a8992b37adc3e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06e01bc18c8cebcf830e289f1f6d66e80f64109511e175f0b5a8992b37adc3e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06e01bc18c8cebcf830e289f1f6d66e80f64109511e175f0b5a8992b37adc3e6", kill_on_drop: false }` [INFO] [stdout] 06e01bc18c8cebcf830e289f1f6d66e80f64109511e175f0b5a8992b37adc3e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb39128c43ad73e6e34efb01a289817664ee48239b8c72118b4d9ebff3739b8f [INFO] running `Command { std: "docker" "start" "-a" "eb39128c43ad73e6e34efb01a289817664ee48239b8c72118b4d9ebff3739b8f", kill_on_drop: false }` [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking asciiengine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `borrow::Borrow` and `fmt::Display` [INFO] [stdout] --> src/screen/draw_interface.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Display, borrow::Borrow}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `value_spinbox::*` [INFO] [stdout] --> src/ui/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub use value_spinbox::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `borrow::Borrow` and `fmt::Display` [INFO] [stdout] --> src/screen/draw_interface.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::Display, borrow::Borrow}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `value_spinbox::*` [INFO] [stdout] --> src/ui/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub use value_spinbox::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/character_map.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_file(path: impl Into, texture_creator: &'a TextureCreator, character_size: (usize, usize), start_pos: ... [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let temp_surface = sdl2::surface::Surface::load_bmp(path.into())?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let texture = texture_creator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::new(texture, character_size, start_pos, per_row)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut canvas = window [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let timer_subsystem = sdl_context.timer()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | context: sdl_context, [INFO] [stdout] 40 | | canvas, [INFO] [stdout] 41 | | video_subsystem, [INFO] [stdout] 42 | | timer_subsystem, [INFO] [stdout] 43 | | event_pump [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/graphical_menu.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(elements: Vec, pos: TextBufferPos, settings: MenuSettings) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self { [INFO] [stdout] 85 | menu: SelectionMenu::new(elements), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asciiengine` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/character_map.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn from_file(path: impl Into, texture_creator: &'a TextureCreator, character_size: (usize, usize), start_pos: ... [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let temp_surface = sdl2::surface::Surface::load_bmp(path.into())?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let texture = texture_creator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::new(texture, character_size, start_pos, per_row)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interface.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut canvas = window [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let timer_subsystem = sdl_context.timer()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | context: sdl_context, [INFO] [stdout] 40 | | canvas, [INFO] [stdout] 41 | | video_subsystem, [INFO] [stdout] 42 | | timer_subsystem, [INFO] [stdout] 43 | | event_pump [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/graphical_menu.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(elements: Vec, pos: TextBufferPos, settings: MenuSettings) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self { [INFO] [stdout] 85 | menu: SelectionMenu::new(elements), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asciiengine` (lib) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "eb39128c43ad73e6e34efb01a289817664ee48239b8c72118b4d9ebff3739b8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb39128c43ad73e6e34efb01a289817664ee48239b8c72118b4d9ebff3739b8f", kill_on_drop: false }` [INFO] [stdout] eb39128c43ad73e6e34efb01a289817664ee48239b8c72118b4d9ebff3739b8f