[INFO] cloning repository https://github.com/ArtlessAvian/lizard-state-riir [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ArtlessAvian/lizard-state-riir" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArtlessAvian%2Flizard-state-riir", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArtlessAvian%2Flizard-state-riir'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 37d735bcbb9e85fae46b6b9caf417708430a4591 [INFO] checking ArtlessAvian/lizard-state-riir/37d735bcbb9e85fae46b6b9caf417708430a4591 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FArtlessAvian%2Flizard-state-riir" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ArtlessAvian/lizard-state-riir on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ArtlessAvian/lizard-state-riir [INFO] finished tweaking git repo https://github.com/ArtlessAvian/lizard-state-riir [INFO] tweaked toml for git repo https://github.com/ArtlessAvian/lizard-state-riir written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ArtlessAvian/lizard-state-riir already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bb8c185fb117f95903fa6b9a40b712eaa2265d93a475241f19562c121dc2c54 [INFO] running `Command { std: "docker" "start" "-a" "4bb8c185fb117f95903fa6b9a40b712eaa2265d93a475241f19562c121dc2c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bb8c185fb117f95903fa6b9a40b712eaa2265d93a475241f19562c121dc2c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bb8c185fb117f95903fa6b9a40b712eaa2265d93a475241f19562c121dc2c54", kill_on_drop: false }` [INFO] [stdout] 4bb8c185fb117f95903fa6b9a40b712eaa2265d93a475241f19562c121dc2c54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f995380c01b1b0b6cc9ad69ffac259489914dc53aafbf42abd232ecfdc8bf410 [INFO] running `Command { std: "docker" "start" "-a" "f995380c01b1b0b6cc9ad69ffac259489914dc53aafbf42abd232ecfdc8bf410", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling gdextension-api v0.1.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling nanoserde-derive v0.1.22 [INFO] [stderr] Compiling bytecheck v0.6.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling rend v0.4.2 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling rkyv v0.7.44 [INFO] [stderr] Compiling inventory v0.1.11 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling venial v0.6.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling nanoserde v0.1.37 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking godot-cell v0.1.1 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling godot-bindings v0.1.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Compiling godot-codegen v0.1.1 [INFO] [stderr] Compiling godot-macros v0.1.1 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling bytecheck_derive v0.6.12 [INFO] [stderr] Compiling rkyv_derive v0.7.44 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling rkyv_typename_derive v0.7.44 [INFO] [stderr] Compiling inventory-impl v0.1.11 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Checking rkyv_typename v0.7.44 [INFO] [stderr] Compiling rkyv_dyn_derive v0.7.44 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling godot-ffi v0.1.1 [INFO] [stderr] Compiling godot-core v0.1.1 [INFO] [stderr] Checking petname v1.1.3 [INFO] [stderr] Checking rkyv_dyn v0.7.44 [INFO] [stderr] Checking engine v0.1.0 (/opt/rustwide/workdir/engine) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/utils.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 25 | let mut updated = (floor.entities[self.entity]).clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | / floor [INFO] [stdout] 39 | | .update_entity(updated) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/utils.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut subject_clone: Entity = floor.entities[self.subject_id].clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / floor [INFO] [stdout] 64 | | .update_entity(subject_clone) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 74 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / floor [INFO] [stdout] 79 | | .update_entity(object_clone) [INFO] [stdout] 80 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 81 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 84 | | })) [INFO] [stdout] 85 | | .map(Cow::Owned), [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 88 | .bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / DelayCommand { [INFO] [stdout] 90 | | subject_id: self.subject_id, [INFO] [stdout] 91 | | queued_command: Rc::new(DoubleHitFollowup { [INFO] [stdout] 92 | | dir: self.dir, [INFO] [stdout] ... | [INFO] [stdout] 96 | | event: None, [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 125 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | / floor [INFO] [stdout] 130 | | .update_entity(object_clone) [INFO] [stdout] 131 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 132 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 135 | | })) [INFO] [stdout] 136 | | .map(Cow::Owned), [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:234:26 [INFO] [stdout] | [INFO] [stdout] 233 | (update, player_id) = update.bind_with_side_output(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | floor.add_entity(Entity { [INFO] [stdout] | __________________________^ [INFO] [stdout] 235 | | id: EntityId::default(), [INFO] [stdout] 236 | | state: EntityState::Ok { next_turn: 0 }, [INFO] [stdout] 237 | | pos: AbsolutePosition::new(0, 0), [INFO] [stdout] ... | [INFO] [stdout] 243 | | is_player_friendly: false, [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:247:26 [INFO] [stdout] | [INFO] [stdout] 246 | (update, other_id) = update.bind_with_side_output(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | floor.add_entity(Entity { [INFO] [stdout] | __________________________^ [INFO] [stdout] 248 | | id: EntityId::default(), [INFO] [stdout] 249 | | state: EntityState::Ok { next_turn: 100 }, [INFO] [stdout] 250 | | pos: AbsolutePosition::new(1, 0), [INFO] [stdout] ... | [INFO] [stdout] 256 | | is_player_friendly: false, [INFO] [stdout] 257 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:261:13 [INFO] [stdout] | [INFO] [stdout] 260 | .bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | / DoubleHitAction [INFO] [stdout] 262 | | .verify_action(&floor, player_id, RelativePosition::new(1, 0)) [INFO] [stdout] 263 | | .unwrap() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:266:23 [INFO] [stdout] | [INFO] [stdout] 266 | .bind(|floor| floor.take_npc_turn().unwrap()); // Second hit. [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 109 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | .bind(|floor| floor.update_entity(subject_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 162 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | / BorrowedFloorUpdate::new(floor) [INFO] [stdout] 181 | | .log(FloorEvent::StartAttack(StartAttackEvent { [INFO] [stdout] 182 | | subject: subject_clone.id, [INFO] [stdout] 183 | | tile: subject_clone.pos + self.dir, [INFO] [stdout] ... | [INFO] [stdout] 189 | | })) [INFO] [stdout] 190 | | .bind(|floor| floor.update_entities(Vec::from([subject_clone, object_clone]))) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:190:49 [INFO] [stdout] | [INFO] [stdout] 162 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | .bind(|floor| floor.update_entities(Vec::from([subject_clone, object_clone]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:326:26 [INFO] [stdout] | [INFO] [stdout] 325 | (update, player_id) = update.bind_with_side_output(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | floor.add_entity(Entity { [INFO] [stdout] | __________________________^ [INFO] [stdout] 327 | | id: EntityId::default(), [INFO] [stdout] 328 | | state: EntityState::Ok { next_turn: 0 }, [INFO] [stdout] 329 | | pos: AbsolutePosition::new(0, 0), [INFO] [stdout] ... | [INFO] [stdout] 335 | | is_player_friendly: false, [INFO] [stdout] 336 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:339:26 [INFO] [stdout] | [INFO] [stdout] 338 | (update, other_id) = update.bind_with_side_output(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | floor.add_entity(Entity { [INFO] [stdout] | __________________________^ [INFO] [stdout] 340 | | id: EntityId::default(), [INFO] [stdout] 341 | | state: EntityState::Ok { next_turn: 0 }, [INFO] [stdout] 342 | | pos: AbsolutePosition::new(1, 0), [INFO] [stdout] ... | [INFO] [stdout] 348 | | is_player_friendly: false, [INFO] [stdout] 349 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 351 | update = update.bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | / BumpAction [INFO] [stdout] 353 | | .verify_action(&floor, player_id, RelativePosition::new(1, 0)) [INFO] [stdout] 354 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:390:26 [INFO] [stdout] | [INFO] [stdout] 389 | (update, player_id) = update.bind_with_side_output(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 390 | floor.add_entity(Entity { [INFO] [stdout] | __________________________^ [INFO] [stdout] 391 | | id: EntityId::default(), [INFO] [stdout] 392 | | state: EntityState::Ok { next_turn: 0 }, [INFO] [stdout] 393 | | pos: AbsolutePosition::new(0, 0), [INFO] [stdout] ... | [INFO] [stdout] 399 | | is_player_friendly: false, [INFO] [stdout] 400 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 402 | update = update.bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | / GotoAction {} [INFO] [stdout] 404 | | .verify_action(&floor, player_id, AbsolutePosition::new(5, 3)) [INFO] [stdout] 405 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 66 | .bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | / DelayCommand { [INFO] [stdout] 68 | | subject_id: self.subject_id, [INFO] [stdout] 69 | | queued_command: Rc::new(ForwardHeavyFollowup { [INFO] [stdout] 70 | | dir: self.dir, [INFO] [stdout] ... | [INFO] [stdout] 74 | | event: None, [INFO] [stdout] 75 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 93 | let mut subject_update = floor.entities[self.subject_id].clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | floor.update_entity(subject_update).log(event) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 110 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / floor [INFO] [stdout] 115 | | .update_entity(object_clone) [INFO] [stdout] 116 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 117 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 126 | | .do_action(&floor) [INFO] [stdout] 127 | | }), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn add_entity(&self, new: Entity) -> (FloorUpdate, EntityId) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | / vision_update.bind(|next_vision| { [INFO] [stdout] 103 | | FloorUpdate::new(Floor { [INFO] [stdout] 104 | | entities: next_entities, [INFO] [stdout] 105 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 108 | | }) [INFO] [stdout] 109 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 81 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 104 | | entities: next_entities, [INFO] [stdout] 105 | | occupiers: next_occupiers, [INFO] [stdout] 106 | | map: self.map.clone(), [INFO] [stdout] 107 | | vision: next_vision, [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn set_map(&self, map: FloorMap) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | entities: self.entities.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn update_entity(&self, new: Entity) -> FloorUpdate { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | .bind(|next_vision| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 161 | | FloorUpdate::new(Floor { [INFO] [stdout] 162 | | entities: next_entities, [INFO] [stdout] 163 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }) [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:161:34 [INFO] [stdout] | [INFO] [stdout] 135 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 162 | | entities: next_entities, [INFO] [stdout] 163 | | occupiers: next_occupiers, [INFO] [stdout] 164 | | map: self.map.clone(), [INFO] [stdout] 165 | | vision: next_vision, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn update_entities(&self, new_set: Vec) -> FloorUpdate { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | .bind(|next_vision| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 211 | | FloorUpdate::new(Floor { [INFO] [stdout] 212 | | entities: next_entities, [INFO] [stdout] 213 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 216 | | }) [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:211:34 [INFO] [stdout] | [INFO] [stdout] 177 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 212 | | entities: next_entities, [INFO] [stdout] 213 | | occupiers: next_occupiers, [INFO] [stdout] 214 | | map: self.map.clone(), [INFO] [stdout] 215 | | vision: next_vision, [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/entity.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|x| UnaimedAction::from(x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn split_contents(self) -> (T, Writer<(), Payload>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let (contents, log) = self.into_both(); [INFO] [stdout] | -------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (contents, Writer::new_with_log((), log)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn bind_or_noop(self, f: F) -> Writer [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match f(self.get_contents()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:92:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn bind_with_side_output(self, f: F) -> (Writer, SideOutput) [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let (contents, log) = self.into_both(); [INFO] [stdout] | -------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (next, side) = f(contents); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | (next.prepend_log(log), side) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn zip(self, other: Writer) -> Writer<(T, U), Payload> { [INFO] [stdout] | ---- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.bind(|t| other.map(|u| (t, u))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn zip(self, other: Writer) -> Writer<(T, U), Payload> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.bind(|t| other.map(|u| (t, u))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine` (lib test) due to 34 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/utils.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 25 | let mut updated = (floor.entities[self.entity]).clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | / floor [INFO] [stdout] 39 | | .update_entity(updated) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/utils.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut subject_clone: Entity = floor.entities[self.subject_id].clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | / floor [INFO] [stdout] 64 | | .update_entity(subject_clone) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 74 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | / floor [INFO] [stdout] 79 | | .update_entity(object_clone) [INFO] [stdout] 80 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 81 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 84 | | })) [INFO] [stdout] 85 | | .map(Cow::Owned), [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 88 | .bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / DelayCommand { [INFO] [stdout] 90 | | subject_id: self.subject_id, [INFO] [stdout] 91 | | queued_command: Rc::new(DoubleHitFollowup { [INFO] [stdout] 92 | | dir: self.dir, [INFO] [stdout] ... | [INFO] [stdout] 96 | | event: None, [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/example.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 125 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | / floor [INFO] [stdout] 130 | | .update_entity(object_clone) [INFO] [stdout] 131 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 132 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 135 | | })) [INFO] [stdout] 136 | | .map(Cow::Owned), [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 109 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | .bind(|floor| floor.update_entity(subject_clone)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 162 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | / BorrowedFloorUpdate::new(floor) [INFO] [stdout] 181 | | .log(FloorEvent::StartAttack(StartAttackEvent { [INFO] [stdout] 182 | | subject: subject_clone.id, [INFO] [stdout] 183 | | tile: subject_clone.pos + self.dir, [INFO] [stdout] ... | [INFO] [stdout] 189 | | })) [INFO] [stdout] 190 | | .bind(|floor| floor.update_entities(Vec::from([subject_clone, object_clone]))) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/public.rs:190:49 [INFO] [stdout] | [INFO] [stdout] 162 | let mut subject_clone: Entity = (floor.entities[self.subject_id]).clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | .bind(|floor| floor.update_entities(Vec::from([subject_clone, object_clone]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 66 | .bind(|floor| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | / DelayCommand { [INFO] [stdout] 68 | | subject_id: self.subject_id, [INFO] [stdout] 69 | | queued_command: Rc::new(ForwardHeavyFollowup { [INFO] [stdout] 70 | | dir: self.dir, [INFO] [stdout] ... | [INFO] [stdout] 74 | | event: None, [INFO] [stdout] 75 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 93 | let mut subject_update = floor.entities[self.subject_id].clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | floor.update_entity(subject_update).log(event) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/actions/characters/max_tegu.rs:114:21 [INFO] [stdout] | [INFO] [stdout] 110 | let mut object_clone: Entity = object_ref.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | / floor [INFO] [stdout] 115 | | .update_entity(object_clone) [INFO] [stdout] 116 | | .log(FloorEvent::AttackHit(AttackHitEvent { [INFO] [stdout] 117 | | subject: self.subject_id, [INFO] [stdout] ... | [INFO] [stdout] 126 | | .do_action(&floor) [INFO] [stdout] 127 | | }), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn add_entity(&self, new: Entity) -> (FloorUpdate, EntityId) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | / vision_update.bind(|next_vision| { [INFO] [stdout] 103 | | FloorUpdate::new(Floor { [INFO] [stdout] 104 | | entities: next_entities, [INFO] [stdout] 105 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 108 | | }) [INFO] [stdout] 109 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:103:34 [INFO] [stdout] | [INFO] [stdout] 81 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 104 | | entities: next_entities, [INFO] [stdout] 105 | | occupiers: next_occupiers, [INFO] [stdout] 106 | | map: self.map.clone(), [INFO] [stdout] 107 | | vision: next_vision, [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn set_map(&self, map: FloorMap) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | entities: self.entities.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn update_entity(&self, new: Entity) -> FloorUpdate { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | .bind(|next_vision| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 161 | | FloorUpdate::new(Floor { [INFO] [stdout] 162 | | entities: next_entities, [INFO] [stdout] 163 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 166 | | }) [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:161:34 [INFO] [stdout] | [INFO] [stdout] 135 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 162 | | entities: next_entities, [INFO] [stdout] 163 | | occupiers: next_occupiers, [INFO] [stdout] 164 | | map: self.map.clone(), [INFO] [stdout] 165 | | vision: next_vision, [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:210:19 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn update_entities(&self, new_set: Vec) -> FloorUpdate { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | .bind(|next_vision| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 211 | | FloorUpdate::new(Floor { [INFO] [stdout] 212 | | entities: next_entities, [INFO] [stdout] 213 | | occupiers: next_occupiers, [INFO] [stdout] ... | [INFO] [stdout] 216 | | }) [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/floor.rs:211:34 [INFO] [stdout] | [INFO] [stdout] 177 | let mut next_entities = self.entities.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | FloorUpdate::new(Floor { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 212 | | entities: next_entities, [INFO] [stdout] 213 | | occupiers: next_occupiers, [INFO] [stdout] 214 | | map: self.map.clone(), [INFO] [stdout] 215 | | vision: next_vision, [INFO] [stdout] 216 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/entity.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | .map(|x| UnaimedAction::from(x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn split_contents(self) -> (T, Writer<(), Payload>) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let (contents, log) = self.into_both(); [INFO] [stdout] | -------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | (contents, Writer::new_with_log((), log)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn bind_or_noop(self, f: F) -> Writer [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match f(self.get_contents()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:92:10 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn bind_with_side_output(self, f: F) -> (Writer, SideOutput) [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let (contents, log) = self.into_both(); [INFO] [stdout] | -------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let (next, side) = f(contents); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | (next.prepend_log(log), side) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn zip(self, other: Writer) -> Writer<(T, U), Payload> { [INFO] [stdout] | ---- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.bind(|t| other.map(|u| (t, u))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/src/writer.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn zip(self, other: Writer) -> Writer<(T, U), Payload> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.bind(|t| other.map(|u| (t, u))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine` (lib) due to 25 previous errors [INFO] running `Command { std: "docker" "inspect" "f995380c01b1b0b6cc9ad69ffac259489914dc53aafbf42abd232ecfdc8bf410", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f995380c01b1b0b6cc9ad69ffac259489914dc53aafbf42abd232ecfdc8bf410", kill_on_drop: false }` [INFO] [stdout] f995380c01b1b0b6cc9ad69ffac259489914dc53aafbf42abd232ecfdc8bf410