[INFO] cloning repository https://github.com/AndrewGaspar/pngs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AndrewGaspar/pngs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fpngs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fpngs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 46e3bf31dbc51c2851ee52e6b95378360097414e [INFO] checking AndrewGaspar/pngs/46e3bf31dbc51c2851ee52e6b95378360097414e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fpngs" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AndrewGaspar/pngs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AndrewGaspar/pngs [INFO] finished tweaking git repo https://github.com/AndrewGaspar/pngs [INFO] tweaked toml for git repo https://github.com/AndrewGaspar/pngs written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AndrewGaspar/pngs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60682f5e60269b7ace4572dfbaaed91eff6c4f3c5214a2767ffff60526267722 [INFO] running `Command { std: "docker" "start" "-a" "60682f5e60269b7ace4572dfbaaed91eff6c4f3c5214a2767ffff60526267722", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60682f5e60269b7ace4572dfbaaed91eff6c4f3c5214a2767ffff60526267722", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60682f5e60269b7ace4572dfbaaed91eff6c4f3c5214a2767ffff60526267722", kill_on_drop: false }` [INFO] [stdout] 60682f5e60269b7ace4572dfbaaed91eff6c4f3c5214a2767ffff60526267722 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 031802820b0b061fef7da9e20b82def6eab6ec6a7aa164608e24b6e41e2a21f4 [INFO] running `Command { std: "docker" "start" "-a" "031802820b0b061fef7da9e20b82def6eab6ec6a7aa164608e24b6e41e2a21f4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking pngs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 62 | let bytes_read = try!(buffer.read(&mut bytes[..])); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | try!(fill_buffer(&mut self.reader, &mut signature)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | try!(ensure_valid_signature(signature)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | try!(ensure_valid_chunk_type(chunk_type)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | try!(fill_buffer(&mut self.reader, &mut chunk)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | let file = try!(File::open(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/raw.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | fn fill_buffer(buffer: &mut Read, bytes: &mut [u8]) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | fn fill_buffer(buffer: &mut dyn Read, bytes: &mut [u8]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:149:14 [INFO] [stdout] | [INFO] [stdout] 140 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Some((|| { [INFO] [stdout] | ______________^ [INFO] [stdout] 150 | | let length = util::bytes_as_be_u32(&word); [INFO] [stdout] 151 | | [INFO] [stdout] 152 | | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] ... | [INFO] [stdout] 172 | | }) [INFO] [stdout] 173 | | })()) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 208 | let file = try!(File::open(&path)); [INFO] [stdout] | ---- ----------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | [INFO] [stdout] 210 | Ok(read_png_raw(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pngs` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:62:22 [INFO] [stdout] | [INFO] [stdout] 62 | let bytes_read = try!(buffer.read(&mut bytes[..])); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | try!(fill_buffer(&mut self.reader, &mut signature)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | try!(ensure_valid_signature(signature)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | try!(ensure_valid_chunk_type(chunk_type)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | try!(fill_buffer(&mut self.reader, &mut chunk)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/raw.rs:208:16 [INFO] [stdout] | [INFO] [stdout] 208 | let file = try!(File::open(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/raw.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | fn fill_buffer(buffer: &mut Read, bytes: &mut [u8]) -> Result<()> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | fn fill_buffer(buffer: &mut dyn Read, bytes: &mut [u8]) -> Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:149:14 [INFO] [stdout] | [INFO] [stdout] 140 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Some((|| { [INFO] [stdout] | ______________^ [INFO] [stdout] 150 | | let length = util::bytes_as_be_u32(&word); [INFO] [stdout] 151 | | [INFO] [stdout] 152 | | try!(fill_buffer(&mut self.reader, &mut word)); [INFO] [stdout] ... | [INFO] [stdout] 172 | | }) [INFO] [stdout] 173 | | })()) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 208 | let file = try!(File::open(&path)); [INFO] [stdout] | ---- ----------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | [INFO] [stdout] 210 | Ok(read_png_raw(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pngs` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "031802820b0b061fef7da9e20b82def6eab6ec6a7aa164608e24b6e41e2a21f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "031802820b0b061fef7da9e20b82def6eab6ec6a7aa164608e24b6e41e2a21f4", kill_on_drop: false }` [INFO] [stdout] 031802820b0b061fef7da9e20b82def6eab6ec6a7aa164608e24b6e41e2a21f4