[INFO] cloning repository https://github.com/AndrewGaspar/empire [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AndrewGaspar/empire" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fempire", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fempire'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4f489a59ad0f0d30ce8cf54110e75d62858ced6f [INFO] checking AndrewGaspar/empire/4f489a59ad0f0d30ce8cf54110e75d62858ced6f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndrewGaspar%2Fempire" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AndrewGaspar/empire on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AndrewGaspar/empire [INFO] finished tweaking git repo https://github.com/AndrewGaspar/empire [INFO] tweaked toml for git repo https://github.com/AndrewGaspar/empire written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AndrewGaspar/empire already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-5-tc2/source/libempire/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /workspace/builds/worker-5-tc2/source/mpiexec/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /workspace/builds/worker-5-tc2/source/empire/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e39d03cac09b1be1947aee6dc008458387bd6dc30f6c968602d2e2b9ffd7920 [INFO] running `Command { std: "docker" "start" "-a" "5e39d03cac09b1be1947aee6dc008458387bd6dc30f6c968602d2e2b9ffd7920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e39d03cac09b1be1947aee6dc008458387bd6dc30f6c968602d2e2b9ffd7920", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e39d03cac09b1be1947aee6dc008458387bd6dc30f6c968602d2e2b9ffd7920", kill_on_drop: false }` [INFO] [stdout] 5e39d03cac09b1be1947aee6dc008458387bd6dc30f6c968602d2e2b9ffd7920 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f68e6e3dd6626f1211f58f5c8610757995f1f2feba888d444ad1329addc8540b [INFO] running `Command { std: "docker" "start" "-a" "f68e6e3dd6626f1211f58f5c8610757995f1f2feba888d444ad1329addc8540b", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/empire/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /opt/rustwide/workdir/libempire/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /opt/rustwide/workdir/mpiexec/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Checking futures v0.1.23 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Checking crossbeam-utils v0.5.0 [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Checking slab v0.4.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.6 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-reactor v0.1.4 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-process v0.2.2 (https://github.com/alexcrichton/tokio-process.git#9b7667b7) [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking empire v0.1.0 (/opt/rustwide/workdir/empire) [INFO] [stdout] warning: unused variable: `connection` [INFO] [stdout] --> empire/src/port.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_new_connection(connection: TcpStream) -> impl Future { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> empire/src/error.rs:19:45 [INFO] [stdout] | [INFO] [stdout] 19 | &Error::IoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> empire/src/error.rs:20:50 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::TokioIoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `connection` [INFO] [stdout] --> empire/src/port.rs:18:27 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_new_connection(connection: TcpStream) -> impl Future { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> empire/src/error.rs:19:45 [INFO] [stdout] | [INFO] [stdout] 19 | &Error::IoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> empire/src/error.rs:20:50 [INFO] [stdout] | [INFO] [stdout] 20 | &Error::TokioIoError(ref err) => err.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `universe` is never used [INFO] [stdout] --> empire/src/comm.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 53 | impl Comm { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 120 | pub(crate) fn universe(&self) -> Arc> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comm_parent` is never read [INFO] [stdout] --> empire/src/universe.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct Universe { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | comm_parent: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 19 | itr: I, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | args: itr.into_iter().map(|arg| arg.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 55 | universe: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ports = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | universe, [INFO] [stdout] 69 | | name: None, [INFO] [stdout] 70 | | rank, [INFO] [stdout] ... | [INFO] [stdout] 74 | | child_commands: Vec::new(), [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub(crate) fn intercomm(universe: Weak>, rank: usize) -> error::Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | universe, [INFO] [stdout] 83 | | name: None, [INFO] [stdout] 84 | | rank, [INFO] [stdout] ... | [INFO] [stdout] 88 | | child_commands: Vec::new(), [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 128 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:141:76 [INFO] [stdout] | [INFO] [stdout] 128 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 142 | | let world_size: usize = commands.iter().map(|command| command.max_procs).sum(); [INFO] [stdout] 143 | | [INFO] [stdout] 144 | | let children: Vec<_> = commands [INFO] [stdout] ... | [INFO] [stdout] 195 | | }) [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let children: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:181:44 [INFO] [stdout] | [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let children: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 182 | | comm: intercomm, [INFO] [stdout] 183 | | results: children_results [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 194 | | .collect(), [INFO] [stdout] 195 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(world_rank, spawn_command)| { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | / future::result( [INFO] [stdout] 155 | | Command::new(&spawn_command.command) [INFO] [stdout] 156 | | .env("EMPIRE_COMM_WORLD_RANK", format!("{}", world_rank)) [INFO] [stdout] 157 | | .env("EMPIRE_COMM_WORLD_SIZE", format!("{}", world_size)) [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:175:42 [INFO] [stdout] | [INFO] [stdout] 172 | .then(|child_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | future::done(Ok(child_result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | comm: intercomm, [INFO] [stdout] 183 | results: children_results [INFO] [stdout] | __________________________^ [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] 185 | | .map(|child_result| -> super::Result<()> { [INFO] [stdout] 186 | | let status = child_result?; [INFO] [stdout] ... | [INFO] [stdout] 193 | | }) [INFO] [stdout] 194 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 201 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | self.spawn_multiple_async(commands, root).wait() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:213:35 [INFO] [stdout] | [INFO] [stdout] 209 | commands: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | self.spawn_multiple_async(Some(commands), root) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 218 | commands: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | self.spawn_multiple_root_async(commands, root).wait() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 24 | let listener = match TcpListener::bind(&("127.0.0.1:0".parse().unwrap())) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(listener) => listener, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Err(io) => return Err(error::Error::IoError(io)), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let (terminal, receiver) = oneshot::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | let server_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Port { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | name, [INFO] [stdout] 62 | | terminal: Some(terminal), [INFO] [stdout] 63 | | server_thread: Some(server_thread), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:39:48 [INFO] [stdout] | [INFO] [stdout] 39 | .then(|_| future::done(Ok(ServerEvent::Terminal))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:55:53 [INFO] [stdout] | [INFO] [stdout] 55 | .for_each(|connection| tokio::spawn(process_new_connection(connection))); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/universe.rs:112:26 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn register_comm(&mut self, comm: Comm) -> CommRegistration { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | CommRegistration(self.registrar.track_object(comm)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/registrar.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn track_object(&mut self, object: T) -> Registration { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let arc = Arc::new(object); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let weak = Arc::downgrade(&arc); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | internal: Box::new(RegistrationImpl { [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | object: weak, [INFO] [stdout] 44 | | strong_ref_index: index, [INFO] [stdout] 45 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `empire` (lib) due to 19 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `universe` is never used [INFO] [stdout] --> empire/src/comm.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 53 | impl Comm { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 120 | pub(crate) fn universe(&self) -> Arc> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `comm_parent` is never read [INFO] [stdout] --> empire/src/universe.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct Universe { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 38 | comm_parent: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 19 | itr: I, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | args: itr.into_iter().map(|arg| arg.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 55 | universe: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ports = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | universe, [INFO] [stdout] 69 | | name: None, [INFO] [stdout] 70 | | rank, [INFO] [stdout] ... | [INFO] [stdout] 74 | | child_commands: Vec::new(), [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub(crate) fn intercomm(universe: Weak>, rank: usize) -> error::Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | universe, [INFO] [stdout] 83 | | name: None, [INFO] [stdout] 84 | | rank, [INFO] [stdout] ... | [INFO] [stdout] 88 | | child_commands: Vec::new(), [INFO] [stdout] 89 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 128 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:141:76 [INFO] [stdout] | [INFO] [stdout] 128 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | ____________________________________________________________________________^ [INFO] [stdout] 142 | | let world_size: usize = commands.iter().map(|command| command.max_procs).sum(); [INFO] [stdout] 143 | | [INFO] [stdout] 144 | | let children: Vec<_> = commands [INFO] [stdout] ... | [INFO] [stdout] 195 | | }) [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let children: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:181:44 [INFO] [stdout] | [INFO] [stdout] 135 | let commands: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let children: Vec<_> = commands [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 182 | | comm: intercomm, [INFO] [stdout] 183 | | results: children_results [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 194 | | .collect(), [INFO] [stdout] 195 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 153 | .map(|(world_rank, spawn_command)| { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | / future::result( [INFO] [stdout] 155 | | Command::new(&spawn_command.command) [INFO] [stdout] 156 | | .env("EMPIRE_COMM_WORLD_RANK", format!("{}", world_rank)) [INFO] [stdout] 157 | | .env("EMPIRE_COMM_WORLD_SIZE", format!("{}", world_size)) [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:175:42 [INFO] [stdout] | [INFO] [stdout] 172 | .then(|child_result| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | future::done(Ok(child_result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:183:26 [INFO] [stdout] | [INFO] [stdout] 141 | future::result(Comm::intercomm(self.universe.clone(), 0)).and_then(move |intercomm| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | future::join_all(children).map(|children_results| SpawnMultipleResult { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | comm: intercomm, [INFO] [stdout] 183 | results: children_results [INFO] [stdout] | __________________________^ [INFO] [stdout] 184 | | .into_iter() [INFO] [stdout] 185 | | .map(|child_result| -> super::Result<()> { [INFO] [stdout] 186 | | let status = child_result?; [INFO] [stdout] ... | [INFO] [stdout] 193 | | }) [INFO] [stdout] 194 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 201 | commands: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | self.spawn_multiple_async(commands, root).wait() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:213:35 [INFO] [stdout] | [INFO] [stdout] 209 | commands: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | self.spawn_multiple_async(Some(commands), root) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/comm.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 218 | commands: I, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | self.spawn_multiple_root_async(commands, root).wait() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 24 | let listener = match TcpListener::bind(&("127.0.0.1:0".parse().unwrap())) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Ok(listener) => listener, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Err(io) => return Err(error::Error::IoError(io)), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let (terminal, receiver) = oneshot::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | let server_thread = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Port { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | name, [INFO] [stdout] 62 | | terminal: Some(terminal), [INFO] [stdout] 63 | | server_thread: Some(server_thread), [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:39:48 [INFO] [stdout] | [INFO] [stdout] 39 | .then(|_| future::done(Ok(ServerEvent::Terminal))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/port.rs:55:53 [INFO] [stdout] | [INFO] [stdout] 55 | .for_each(|connection| tokio::spawn(process_new_connection(connection))); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/universe.rs:112:26 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn register_comm(&mut self, comm: Comm) -> CommRegistration { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | CommRegistration(self.registrar.track_object(comm)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> empire/src/registrar.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn track_object(&mut self, object: T) -> Registration { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let arc = Arc::new(object); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let weak = Arc::downgrade(&arc); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | internal: Box::new(RegistrationImpl { [INFO] [stdout] | _______________________^ [INFO] [stdout] 43 | | object: weak, [INFO] [stdout] 44 | | strong_ref_index: index, [INFO] [stdout] 45 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `empire` (lib test) due to 19 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f68e6e3dd6626f1211f58f5c8610757995f1f2feba888d444ad1329addc8540b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f68e6e3dd6626f1211f58f5c8610757995f1f2feba888d444ad1329addc8540b", kill_on_drop: false }` [INFO] [stdout] f68e6e3dd6626f1211f58f5c8610757995f1f2feba888d444ad1329addc8540b