[INFO] cloning repository https://github.com/AndreiCherechesu/Morse-Chat-Server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AndreiCherechesu/Morse-Chat-Server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreiCherechesu%2FMorse-Chat-Server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreiCherechesu%2FMorse-Chat-Server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eda06368c34c8bf4e99a8ad542a2628e7e0ccd41 [INFO] checking AndreiCherechesu/Morse-Chat-Server/eda06368c34c8bf4e99a8ad542a2628e7e0ccd41 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAndreiCherechesu%2FMorse-Chat-Server" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AndreiCherechesu/Morse-Chat-Server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AndreiCherechesu/Morse-Chat-Server [INFO] finished tweaking git repo https://github.com/AndreiCherechesu/Morse-Chat-Server [INFO] tweaked toml for git repo https://github.com/AndreiCherechesu/Morse-Chat-Server written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AndreiCherechesu/Morse-Chat-Server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32c8b35a87fb11ccf7c41d9a2bec30b93d93146112478ff9e336f9389d31ba26 [INFO] running `Command { std: "docker" "start" "-a" "32c8b35a87fb11ccf7c41d9a2bec30b93d93146112478ff9e336f9389d31ba26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32c8b35a87fb11ccf7c41d9a2bec30b93d93146112478ff9e336f9389d31ba26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32c8b35a87fb11ccf7c41d9a2bec30b93d93146112478ff9e336f9389d31ba26", kill_on_drop: false }` [INFO] [stdout] 32c8b35a87fb11ccf7c41d9a2bec30b93d93146112478ff9e336f9389d31ba26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b99c4a6ba65fd8d4860a40e11e5b408a6e758739afb610918c1a9b1751589c1f [INFO] running `Command { std: "docker" "start" "-a" "b99c4a6ba65fd8d4860a40e11e5b408a6e758739afb610918c1a9b1751589c1f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.33 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling futures-core v0.3.18 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.131 [INFO] [stderr] Compiling yansi v0.5.0 [INFO] [stderr] Compiling serde v1.0.131 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling pin-project-lite v0.2.7 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling futures-task v0.3.18 [INFO] [stderr] Checking futures-sink v0.3.18 [INFO] [stderr] Compiling const_fn v0.4.8 [INFO] [stderr] Compiling futures-channel v0.3.18 [INFO] [stderr] Compiling tokio v1.14.0 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling futures-util v0.3.18 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.9.1 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking futures-io v0.3.18 [INFO] [stderr] Compiling cookie v0.15.1 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling ref-cast v1.0.6 [INFO] [stderr] Compiling tracing-core v0.1.21 [INFO] [stderr] Compiling http v0.2.5 [INFO] [stderr] Compiling mio v0.7.14 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling uncased v0.9.6 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling tracing v0.1.29 [INFO] [stderr] Compiling instant v0.1.12 [INFO] [stderr] Compiling scopeguard v1.1.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling try-lock v0.2.3 [INFO] [stderr] Compiling smallvec v1.7.0 [INFO] [stderr] Compiling lock_api v0.4.5 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling want v0.3.0 [INFO] [stderr] Compiling socket2 v0.4.2 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Compiling tower-service v0.3.1 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Checking inlinable_string v0.1.14 [INFO] [stderr] Compiling httpdate v1.0.2 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling parking_lot v0.11.2 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Compiling multer v2.0.1 [INFO] [stderr] Compiling figment v0.10.6 [INFO] [stderr] Compiling atomic v0.5.1 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling state v0.5.2 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Compiling mime v0.3.16 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking twoway v0.2.2 [INFO] [stderr] Compiling rocket v0.5.0-rc.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking spin v0.9.2 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking binascii v0.1.4 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling tokio-util v0.6.9 [INFO] [stderr] Compiling h2 v0.3.9 [INFO] [stderr] Compiling devise_core v0.3.1 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling tokio-macros v1.6.0 [INFO] [stderr] Compiling futures-macro v0.3.18 [INFO] [stderr] Compiling pear_codegen v0.2.3 [INFO] [stderr] Compiling ref-cast-impl v1.0.6 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Compiling devise_codegen v0.3.1 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Compiling time-macros v0.1.1 [INFO] [stderr] Compiling pear v0.2.3 [INFO] [stderr] Compiling devise v0.3.1 [INFO] [stderr] Compiling hyper v0.14.16 [INFO] [stderr] Checking futures-executor v0.3.18 [INFO] [stderr] Checking futures v0.3.18 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Compiling rocket_http v0.5.0-rc.1 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking ubyte v0.10.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling rocket_codegen v0.5.0-rc.1 [INFO] [stderr] Checking web-AndreiCherechesu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/controllers/message_controller.rs:3:65 [INFO] [stdout] | [INFO] [stdout] 3 | use rocket::{serde::json::Json, http::Status, post, State, get, debug}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/controllers/message_controller.rs:3:65 [INFO] [stdout] | [INFO] [stdout] 3 | use rocket::{serde::json::Json, http::Status, post, State, get, debug}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 18 | let safe_message_repository = Arc::new(Mutex::new(MessageRepository::new())); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let safe_user_repository = Arc::new(Mutex::new(UserRepository::new())); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let safe_message_service = Arc::new(Mutex::new(MessageService::new(safe_message_repository.clone(), safe_user_repository.clone()))); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let safe_user_service = safe_user_repository.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let safe_idx = Arc::new(Mutex::new(idx)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / rocket::build() [INFO] [stdout] 32 | | .configure(config) [INFO] [stdout] 33 | | .mount("/", routes![ [INFO] [stdout] 34 | | controllers::message_controller::send_message, [INFO] [stdout] ... | [INFO] [stdout] 42 | | .manage(safe_message_service) [INFO] [stdout] 43 | | .manage(safe_user_service) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/controllers/message_controller.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / message_service.send_message( [INFO] [stdout] 34 | | current_user, [INFO] [stdout] 35 | | parsed_message.clone() [INFO] [stdout] 36 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = message_service.send_message( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newUser` should have a snake case name [INFO] [stdout] --> src/repository/user_repository.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let newUser = db.entry(user.id.clone()).or_insert(user); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `new_user` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 18 | let safe_message_repository = Arc::new(Mutex::new(MessageRepository::new())); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let safe_user_repository = Arc::new(Mutex::new(UserRepository::new())); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let safe_message_service = Arc::new(Mutex::new(MessageService::new(safe_message_repository.clone(), safe_user_repository.clone()))); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let safe_user_service = safe_user_repository.clone(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let safe_idx = Arc::new(Mutex::new(idx)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / rocket::build() [INFO] [stdout] 32 | | .configure(config) [INFO] [stdout] 33 | | .mount("/", routes![ [INFO] [stdout] 34 | | controllers::message_controller::send_message, [INFO] [stdout] ... | [INFO] [stdout] 42 | | .manage(safe_message_service) [INFO] [stdout] 43 | | .manage(safe_user_service) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/controllers/message_controller.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / message_service.send_message( [INFO] [stdout] 34 | | current_user, [INFO] [stdout] 35 | | parsed_message.clone() [INFO] [stdout] 36 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = message_service.send_message( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newUser` should have a snake case name [INFO] [stdout] --> src/repository/user_repository.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | let newUser = db.entry(user.id.clone()).or_insert(user); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `new_user` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `web-AndreiCherechesu` (bin "web-AndreiCherechesu" test) due to 2 previous errors; 4 warnings emitted [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `web-AndreiCherechesu` (bin "web-AndreiCherechesu") due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b99c4a6ba65fd8d4860a40e11e5b408a6e758739afb610918c1a9b1751589c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b99c4a6ba65fd8d4860a40e11e5b408a6e758739afb610918c1a9b1751589c1f", kill_on_drop: false }` [INFO] [stdout] b99c4a6ba65fd8d4860a40e11e5b408a6e758739afb610918c1a9b1751589c1f