[INFO] cloning repository https://github.com/AlperROzkan/rustfam [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlperROzkan/rustfam" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlperROzkan%2Frustfam", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlperROzkan%2Frustfam'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 32ffcfaff87b514ee48962a66ca7acc8baeaa9e9 [INFO] checking AlperROzkan/rustfam/32ffcfaff87b514ee48962a66ca7acc8baeaa9e9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlperROzkan%2Frustfam" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AlperROzkan/rustfam on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AlperROzkan/rustfam [INFO] finished tweaking git repo https://github.com/AlperROzkan/rustfam [INFO] tweaked toml for git repo https://github.com/AlperROzkan/rustfam written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AlperROzkan/rustfam already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 834076f2653ac9cb143438bb12a187d8e850010d5c2c46d03a092cd3f886cd27 [INFO] running `Command { std: "docker" "start" "-a" "834076f2653ac9cb143438bb12a187d8e850010d5c2c46d03a092cd3f886cd27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "834076f2653ac9cb143438bb12a187d8e850010d5c2c46d03a092cd3f886cd27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "834076f2653ac9cb143438bb12a187d8e850010d5c2c46d03a092cd3f886cd27", kill_on_drop: false }` [INFO] [stdout] 834076f2653ac9cb143438bb12a187d8e850010d5c2c46d03a092cd3f886cd27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e44305baf1c68e13a8aa357082c41eb2d0610cb2875ce1ca5e005400aa561db2 [INFO] running `Command { std: "docker" "start" "-a" "e44305baf1c68e13a8aa357082c41eb2d0610cb2875ce1ca5e005400aa561db2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking serde_test v1.0.126 [INFO] [stderr] Checking FamRust v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/model/family/tree.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn node_1(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 47 | &self.node_1() [INFO] [stdout] | ------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/model/family/tree.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn node_1(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 47 | &self.node_1() [INFO] [stdout] | ------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/model/family/tree.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn node_2(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 52 | &self.node_2() [INFO] [stdout] | ------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/model/family/tree.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn node_2(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stdout] 52 | &self.node_2() [INFO] [stdout] | ------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tree` [INFO] [stdout] --> src/model/family/tree.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let tree: Tree = Tree::new(fam1, fam2, Pairing::new(&person_1, &person_2)); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tree` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/model/family/family.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl<'a> Family<'a> { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn new_existing( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 114 | pub fn add_children(&mut self, children: Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | pub fn get_family_member_firstname(&mut self, firstname: String) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | pub fn get_parent_firstname(&mut self, firstname: String) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 158 | pub fn get_child_firstname(&mut self, firstname: String) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 190 | pub fn init_1() -> Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 207 | pub fn init_2() -> Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `linked_1`, `linked_1_mut`, `linked_2`, and `linked_2_mut` are never used [INFO] [stdout] --> src/model/family/pairing.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl Pairing { [INFO] [stdout] | ------------------ associated items in this implementation [INFO] [stdout] 16 | pub fn new(linked_1: T, linked_2: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn linked_1(&self) -> &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn linked_1_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn linked_2(&self) -> &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn linked_2_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Tree` is never used [INFO] [stdout] --> src/model/family/tree.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Tree<'a> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `node_1`, and `node_2` are never used [INFO] [stdout] --> src/model/family/tree.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl<'a> Tree<'a> { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn node_1(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn node_2(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id`, `firstname`, and `lastname` are never used [INFO] [stdout] --> src/model/person.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl<'a> Person<'a> { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn id(&self) -> &u16 { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn firstname(&self) -> &'a str { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn lastname(&self) -> &'a str { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/family/family.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn read_family_from_file>(path: P) -> String { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut buf_reader; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | match File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/family/family.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn write_to_file>(self, path: P) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | // Create a file and write this family to it [INFO] [stdout] 175 | match File::create(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_children` and `get_family_member_firstname` are never used [INFO] [stdout] --> src/model/family/family.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 53 | impl<'a> Family<'a> { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 114 | pub fn add_children(&mut self, children: Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | pub fn get_family_member_firstname(&mut self, firstname: String) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `linked_1`, `linked_1_mut`, `linked_2`, and `linked_2_mut` are never used [INFO] [stdout] --> src/model/family/pairing.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 15 | impl Pairing { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn linked_1(&self) -> &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn linked_1_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn linked_2(&self) -> &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn linked_2_mut(&mut self) -> &mut T { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `node_1`, `node_2`, `linking`, and `node_3` are never read [INFO] [stdout] --> src/model/family/tree.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | Node { [INFO] [stdout] | ---- fields in this variant [INFO] [stdout] 17 | node_1: Family<'a>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 18 | node_2: Family<'a>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 19 | linking: Pairing<&'a Person<'a>>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 20 | node_3: Box>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `node_1` and `node_2` are never used [INFO] [stdout] --> src/model/family/tree.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl<'a> Tree<'a> { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn node_1(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 51 | pub fn node_2(&self) -> &'a Family<'a> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `id` and `lastname` are never used [INFO] [stdout] --> src/model/person.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl<'a> Person<'a> { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn id(&self) -> &u16 { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn lastname(&self) -> &'a str { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/family/family.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn read_family_from_file>(path: P) -> String { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut buf_reader; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | match File::open(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/family/family.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn write_to_file>(self, path: P) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | // Create a file and write this family to it [INFO] [stdout] 175 | match File::create(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/model/family/family.rs:289:17 [INFO] [stdout] | [INFO] [stdout] 289 | buf_reader.read_to_string(&mut contents); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 289 | let _ = buf_reader.read_to_string(&mut contents); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `FamRust` (bin "fam_rust") due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `FamRust` (bin "fam_rust" test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e44305baf1c68e13a8aa357082c41eb2d0610cb2875ce1ca5e005400aa561db2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e44305baf1c68e13a8aa357082c41eb2d0610cb2875ce1ca5e005400aa561db2", kill_on_drop: false }` [INFO] [stdout] e44305baf1c68e13a8aa357082c41eb2d0610cb2875ce1ca5e005400aa561db2