[INFO] cloning repository https://github.com/Alorel/fancy_constructor-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Alorel/fancy_constructor-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlorel%2Ffancy_constructor-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlorel%2Ffancy_constructor-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0abdf15a9b597cb1b5bbde976e5ac2f80d2597c8 [INFO] checking Alorel/fancy_constructor-rs/0abdf15a9b597cb1b5bbde976e5ac2f80d2597c8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlorel%2Ffancy_constructor-rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Alorel/fancy_constructor-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Alorel/fancy_constructor-rs [INFO] finished tweaking git repo https://github.com/Alorel/fancy_constructor-rs [INFO] tweaked toml for git repo https://github.com/Alorel/fancy_constructor-rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Alorel/fancy_constructor-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f202f113c6f658f8f2c5becad470d3e7aea600c21abda442799948a6a378b163 [INFO] running `Command { std: "docker" "start" "-a" "f202f113c6f658f8f2c5becad470d3e7aea600c21abda442799948a6a378b163", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f202f113c6f658f8f2c5becad470d3e7aea600c21abda442799948a6a378b163", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f202f113c6f658f8f2c5becad470d3e7aea600c21abda442799948a6a378b163", kill_on_drop: false }` [INFO] [stdout] f202f113c6f658f8f2c5becad470d3e7aea600c21abda442799948a6a378b163 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c45ea83cdd3032a8a0d4e5a08b46a7fe20a908901bb37536ba85aba906ec8528 [INFO] running `Command { std: "docker" "start" "-a" "c45ea83cdd3032a8a0d4e5a08b46a7fe20a908901bb37536ba85aba906ec8528", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.11 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling syn v2.0.30 [INFO] [stderr] Checking proc-macro2 v1.0.66 [INFO] [stderr] Checking quote v1.0.33 [INFO] [stderr] Compiling macroific_attr_parse v1.2.2 [INFO] [stderr] Compiling macroific_core v1.0.1 [INFO] [stderr] Compiling macroific_macro v1.1.0 [INFO] [stderr] Checking macroific v1.2.2 [INFO] [stderr] Checking fancy_constructor v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 257 | pub fn derive_fancy_constructor(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | / syn::parse_macro_input!(input as FancyConstructor) [INFO] [stdout] 259 | | .into_token_stream() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 17 | attrs, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | generics, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | data, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | fields: match data { [INFO] [stdout] 25 | | Data::Struct(s) => FieldsSource::Struct(s.fields.try_into()?), [INFO] [stdout] 26 | | Data::Enum(e) => { [INFO] [stdout] ... | [INFO] [stdout] 45 | | generics, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | fn create_span<'a, S>(it: impl IntoIterator) -> Span [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / it.into_iter() [INFO] [stdout] 55 | | .map(Spanned::span) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fancy_constructor` (lib) due to 8 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 64 | let iter = src_iter.map(move |(attrs, ident, ty)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | name: match ident { [INFO] [stdout] 67 | | Ok(ident) | Err(ident) => ident, [INFO] [stdout] 68 | | }, [INFO] [stdout] ... | [INFO] [stdout] 73 | | ty, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | fn fmt_named(fields: impl IntoIterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | fields.into_iter().map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 98 | fn fmt_unnamed(fields: impl IntoIterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / fields [INFO] [stdout] 100 | | .into_iter() [INFO] [stdout] 101 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | fn try_from(fields: SFields) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Ok(match fields { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | SFields::Unit => Fields::Unit, [INFO] [stdout] 139 | | SFields::Named(f) => Fields::Named(collect_fields(fmt_named(f.named))?), [INFO] [stdout] 140 | | SFields::Unnamed(f) => Fields::Unnamed(collect_fields(fmt_unnamed(f.unnamed))?), [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 257 | pub fn derive_fancy_constructor(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | / syn::parse_macro_input!(input as FancyConstructor) [INFO] [stdout] 259 | | .into_token_stream() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 17 | attrs, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | generics, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | data, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 24 | | fields: match data { [INFO] [stdout] 25 | | Data::Struct(s) => FieldsSource::Struct(s.fields.try_into()?), [INFO] [stdout] 26 | | Data::Enum(e) => { [INFO] [stdout] ... | [INFO] [stdout] 45 | | generics, [INFO] [stdout] 46 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 50 | fn create_span<'a, S>(it: impl IntoIterator) -> Span [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / it.into_iter() [INFO] [stdout] 55 | | .map(Spanned::span) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 64 | let iter = src_iter.map(move |(attrs, ident, ty)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | name: match ident { [INFO] [stdout] 67 | | Ok(ident) | Err(ident) => ident, [INFO] [stdout] 68 | | }, [INFO] [stdout] ... | [INFO] [stdout] 73 | | ty, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 83 | fn fmt_named(fields: impl IntoIterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | fields.into_iter().map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 98 | fn fmt_unnamed(fields: impl IntoIterator) -> impl Iterator { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / fields [INFO] [stdout] 100 | | .into_iter() [INFO] [stdout] 101 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 136 | fn try_from(fields: SFields) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | Ok(match fields { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | SFields::Unit => Fields::Unit, [INFO] [stdout] 139 | | SFields::Named(f) => Fields::Named(collect_fields(fmt_named(f.named))?), [INFO] [stdout] 140 | | SFields::Unnamed(f) => Fields::Unnamed(collect_fields(fmt_unnamed(f.unnamed))?), [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fancy_constructor` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "c45ea83cdd3032a8a0d4e5a08b46a7fe20a908901bb37536ba85aba906ec8528", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c45ea83cdd3032a8a0d4e5a08b46a7fe20a908901bb37536ba85aba906ec8528", kill_on_drop: false }` [INFO] [stdout] c45ea83cdd3032a8a0d4e5a08b46a7fe20a908901bb37536ba85aba906ec8528