[INFO] cloning repository https://github.com/Allen-B1/calc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Allen-B1/calc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAllen-B1%2Fcalc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAllen-B1%2Fcalc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2a9da38ed07a7f453b946001863ac6fb2a777b31 [INFO] checking Allen-B1/calc/2a9da38ed07a7f453b946001863ac6fb2a777b31 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAllen-B1%2Fcalc" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Allen-B1/calc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Allen-B1/calc [INFO] finished tweaking git repo https://github.com/Allen-B1/calc [INFO] tweaked toml for git repo https://github.com/Allen-B1/calc written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Allen-B1/calc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cded2e825ba665c5fa104f3811e8a123a49192b4d62cb9559e0cd4b4e9584c06 [INFO] running `Command { std: "docker" "start" "-a" "cded2e825ba665c5fa104f3811e8a123a49192b4d62cb9559e0cd4b4e9584c06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cded2e825ba665c5fa104f3811e8a123a49192b4d62cb9559e0cd4b4e9584c06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cded2e825ba665c5fa104f3811e8a123a49192b4d62cb9559e0cd4b4e9584c06", kill_on_drop: false }` [INFO] [stdout] cded2e825ba665c5fa104f3811e8a123a49192b4d62cb9559e0cd4b4e9584c06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 937a5fbfd4aed483cbb181c9c4fcbad384d3e6963a4a4f706de6998f077094f3 [INFO] running `Command { std: "docker" "start" "-a" "937a5fbfd4aed483cbb181c9c4fcbad384d3e6963a4a4f706de6998f077094f3", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.83 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling once_cell v1.15.0 [INFO] [stderr] Compiling bumpalo v3.11.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.83 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.83 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.83 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.83 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking calculator-2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `iter::Peekable` [INFO] [stdout] --> src/lib.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{iter::Peekable, collections::{HashMap, HashSet}}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsCast` [INFO] [stdout] --> src/lib.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | use wasm_bindgen::{prelude::*, JsCast}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Tokenizer` [INFO] [stdout] --> src/ast.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | use crate::tokenizer::{Tokenizer, Token}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::Peekable` [INFO] [stdout] --> src/ast.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | use std::iter::Peekable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/eval.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::{HashMap, HashSet}, fmt::Display}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SerializeSeq`, `SerializeTuple`, and `Serializer` [INFO] [stdout] --> src/eval.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Serialize, Serializer, ser::{SerializeTuple, SerializeSeq}, Deserialize}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokenizer::Tokenizer` [INFO] [stdout] --> src/eval.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{ast::Node, tokenizer::Tokenizer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Add` [INFO] [stdout] --> src/value/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::ops::Add; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `iter::Peekable` [INFO] [stdout] --> src/lib.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{iter::Peekable, collections::{HashMap, HashSet}}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `JsCast` [INFO] [stdout] --> src/lib.rs:4:32 [INFO] [stdout] | [INFO] [stdout] 4 | use wasm_bindgen::{prelude::*, JsCast}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Tokenizer` [INFO] [stdout] --> src/ast.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | use crate::tokenizer::{Tokenizer, Token}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::Peekable` [INFO] [stdout] --> src/ast.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | use std::iter::Peekable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TokenListRef` [INFO] [stdout] --> src/ast.rs:386:21 [INFO] [stdout] | [INFO] [stdout] 386 | use super::{TokenListRef, Cursor}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/eval.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::{HashMap, HashSet}, fmt::Display}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SerializeSeq`, `SerializeTuple`, and `Serializer` [INFO] [stdout] --> src/eval.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Serialize, Serializer, ser::{SerializeTuple, SerializeSeq}, Deserialize}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokenizer::Tokenizer` [INFO] [stdout] --> src/eval.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{ast::Node, tokenizer::Tokenizer}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Add` [INFO] [stdout] --> src/value/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::ops::Add; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tokenizer.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | let mut tok = Tokenizer::new("#xaxaxa bc sin co"); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matrix` [INFO] [stdout] --> src/ast.rs:395:17 [INFO] [stdout] | [INFO] [stdout] 395 | let matrix = parse_matrix(&tokens, &mut cur).unwrap(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_matrix` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/eval.rs:139:33 [INFO] [stdout] | [INFO] [stdout] 139 | Value::Func(params, expr) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `class` [INFO] [stdout] --> src/eval.rs:255:19 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn opaque(class: Class) -> Expr { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_class` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expr` [INFO] [stdout] --> src/eval.rs:139:33 [INFO] [stdout] | [INFO] [stdout] 139 | Value::Func(params, expr) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `class` [INFO] [stdout] --> src/eval.rs:255:19 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn opaque(class: Class) -> Expr { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_class` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | fn add(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | fn mul(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | fn div(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | fn dot(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `idx` [INFO] [stdout] --> src/lib.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | for (ident, (idx, node)) in assignments.iter() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_idx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `height` is never used [INFO] [stdout] --> src/ast.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Matrix { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 23 | pub fn height(&self) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `combine` is never used [INFO] [stdout] --> src/eval.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl Class { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 24 | pub fn combine(&self, rhs: &Class, op: char) -> Class { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `combine` is never used [INFO] [stdout] --> src/eval.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 92 | impl NumClass { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 93 | /** Returns the result type when you combine two numbers */ [INFO] [stdout] 94 | pub fn combine(self, b: NumClass) -> NumClass { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `abs`, `add`, `mul`, `div`, and `dot` are never used [INFO] [stdout] --> src/value/mod.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Value: Serialize { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 10 | fn abs(&self) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | fn add(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn mul(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 13 | fn div(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 14 | fn dot(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Matrix` is never constructed [INFO] [stdout] --> src/value/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub enum Any { [INFO] [stdout] | --- variant in this enum [INFO] [stdout] 18 | Num(num::Num), [INFO] [stdout] 19 | Matrix(Matrix) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Int` is never constructed [INFO] [stdout] --> src/value/num.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub enum Num { [INFO] [stdout] | --- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 12 | Int(BigInt) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Num` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:11 [INFO] [stdout] | [INFO] [stdout] 98 | let vec = inner(match serde_json::from_str(&input) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(v) => v, [INFO] [stdout] 100 | Err(e) => return format!("{:?}", e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match serde_json::to_string(&new_value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut assignments = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut exprs = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut mark_perm = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut mark_temp = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut exprtable = SymbolExprTable::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut symbols = SymbolTable::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut values = vec![None; input.len()]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | values.into_iter().map(|x| x.unwrap_or(Err(format!("internal error 2042")))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:48 [INFO] [stdout] | [INFO] [stdout] 95 | values.into_iter().map(|x| x.unwrap_or(Err(format!("internal error 2042")))).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 130 | let mut vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let mut current_row = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Matrix { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | entries: vec, [INFO] [stdout] 196 | | width: size.unwrap_or(1), [INFO] [stdout] 197 | | augmented: augmented.unwrap_or(false) [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 206 | let lhs = parse_mul(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let rhs = parse_add(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | [INFO] [stdout] 219 | Ok( Node::BinaryOp(Box::new(lhs), op, Box::new(rhs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 224 | let lhs = parse_unary(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let rhs = parse_mul(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | [INFO] [stdout] 237 | Ok( Node::BinaryOp(Box::new(lhs), op, Box::new(rhs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 256 | let lhs = parse_group(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | expect(r, cur, Token::LeftParen)?; [INFO] [stdout] 258 | let mut exprs= Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | Ok(Node::Call(Box::new(lhs), exprs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 279 | let lhs = parse_group(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | [INFO] [stdout] 281 | let rhs = or( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Ok(match rhs { [INFO] [stdout] | ____________^ [INFO] [stdout] 288 | | Some(rhs) => Node::BinaryOp(Box::new(lhs), '*', Box::new(rhs)), [INFO] [stdout] 289 | | None => lhs [INFO] [stdout] 290 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | |r, cur| parse_mulcat(r, cur).map(Some), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:284:23 [INFO] [stdout] | [INFO] [stdout] 284 | |_, _| Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:310:22 [INFO] [stdout] | [INFO] [stdout] 310 | |r, cur| parse_matrix(r, cur).map(Node::Matrix), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:371:12 [INFO] [stdout] | [INFO] [stdout] 365 | let expr_node = parse_expr(r, cur)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | Ok(Node::Assign(ident.clone(), params, Box::new(expr_node))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 85 | #[derive(Debug, Clone, Serialize, Deserialize, Copy, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn new_add(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Expr::Add(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:239:34 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn new_add(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Expr::Add(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_mul(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Expr::Mul(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:242:34 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_mul(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Expr::Mul(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 244 | pub fn new_sub(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | Self::new_add(lhs, [INFO] [stdout] 246 | Self::new_mul(Expr::Num(-1.0), rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | fn add(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:249:19 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new_div(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Expr::Div(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:249:34 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new_div(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Expr::Div(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | fn mul(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn new_dot(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Expr::Dot(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 13 | fn div(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:252:34 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn new_dot(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Expr::Dot(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rhs` [INFO] [stdout] --> src/value/mod.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 14 | fn dot(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rhs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:434:76 [INFO] [stdout] | [INFO] [stdout] 434 | let entries: Vec = entries.iter().map(|entry| match eval_expr(entry, symbols)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `idx` [INFO] [stdout] --> src/lib.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | for (ident, (idx, node)) in assignments.iter() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_idx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `height` is never used [INFO] [stdout] --> src/ast.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Matrix { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 23 | pub fn height(&self) -> usize { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `combine` is never used [INFO] [stdout] --> src/eval.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl Class { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 24 | pub fn combine(&self, rhs: &Class, op: char) -> Class { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `combine` is never used [INFO] [stdout] --> src/eval.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 92 | impl NumClass { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 93 | /** Returns the result type when you combine two numbers */ [INFO] [stdout] 94 | pub fn combine(self, b: NumClass) -> NumClass { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `abs`, `add`, `mul`, `div`, and `dot` are never used [INFO] [stdout] --> src/value/mod.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Value: Serialize { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 10 | fn abs(&self) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | fn add(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | fn mul(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 13 | fn div(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] 14 | fn dot(&self, rhs: Any) -> Option { None } [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Matrix` is never constructed [INFO] [stdout] --> src/value/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub enum Any { [INFO] [stdout] | --- variant in this enum [INFO] [stdout] 18 | Num(num::Num), [INFO] [stdout] 19 | Matrix(Matrix) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Int` is never constructed [INFO] [stdout] --> src/value/num.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | pub enum Num { [INFO] [stdout] | --- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 12 | Int(BigInt) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Num` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:11 [INFO] [stdout] | [INFO] [stdout] 98 | let vec = inner(match serde_json::from_str(&input) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(v) => v, [INFO] [stdout] 100 | Err(e) => return format!("{:?}", e) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match serde_json::to_string(&new_value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut assignments = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut exprs = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut mark_perm = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut mark_temp = HashSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut exprtable = SymbolExprTable::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let mut symbols = SymbolTable::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut values = vec![None; input.len()]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | values.into_iter().map(|x| x.unwrap_or(Err(format!("internal error 2042")))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:48 [INFO] [stdout] | [INFO] [stdout] 95 | values.into_iter().map(|x| x.unwrap_or(Err(format!("internal error 2042")))).collect() [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 130 | let mut vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let mut current_row = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Matrix { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | entries: vec, [INFO] [stdout] 196 | | width: size.unwrap_or(1), [INFO] [stdout] 197 | | augmented: augmented.unwrap_or(false) [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 206 | let lhs = parse_mul(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let rhs = parse_add(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | [INFO] [stdout] 219 | Ok( Node::BinaryOp(Box::new(lhs), op, Box::new(rhs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 224 | let lhs = parse_unary(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | let rhs = parse_mul(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | [INFO] [stdout] 237 | Ok( Node::BinaryOp(Box::new(lhs), op, Box::new(rhs))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:272:20 [INFO] [stdout] | [INFO] [stdout] 256 | let lhs = parse_group(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | expect(r, cur, Token::LeftParen)?; [INFO] [stdout] 258 | let mut exprs= Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | Ok(Node::Call(Box::new(lhs), exprs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 279 | let lhs = parse_group(r, cur)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | [INFO] [stdout] 281 | let rhs = or( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | Ok(match rhs { [INFO] [stdout] | ____________^ [INFO] [stdout] 288 | | Some(rhs) => Node::BinaryOp(Box::new(lhs), '*', Box::new(rhs)), [INFO] [stdout] 289 | | None => lhs [INFO] [stdout] 290 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | |r, cur| parse_mulcat(r, cur).map(Some), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:284:23 [INFO] [stdout] | [INFO] [stdout] 284 | |_, _| Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:310:22 [INFO] [stdout] | [INFO] [stdout] 310 | |r, cur| parse_matrix(r, cur).map(Node::Matrix), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast.rs:371:12 [INFO] [stdout] | [INFO] [stdout] 365 | let expr_node = parse_expr(r, cur)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | Ok(Node::Assign(ident.clone(), params, Box::new(expr_node))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator-2` (lib) due to 24 previous errors; 21 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 85 | #[derive(Debug, Clone, Serialize, Deserialize, Copy, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn new_add(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Expr::Add(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:239:34 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn new_add(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Expr::Add(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_mul(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Expr::Mul(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:242:34 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_mul(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Expr::Mul(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 244 | pub fn new_sub(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | Self::new_add(lhs, [INFO] [stdout] 246 | Self::new_mul(Expr::Num(-1.0), rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:249:19 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new_div(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Expr::Div(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:249:34 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn new_div(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Expr::Div(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:252:19 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn new_dot(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Expr::Dot(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:252:34 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn new_dot(lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | Expr::Dot(Box::new(lhs), Box::new(rhs)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:434:76 [INFO] [stdout] | [INFO] [stdout] 434 | let entries: Vec = entries.iter().map(|entry| match eval_expr(entry, symbols)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `calculator-2` (lib test) due to 24 previous errors; 24 warnings emitted [INFO] running `Command { std: "docker" "inspect" "937a5fbfd4aed483cbb181c9c4fcbad384d3e6963a4a4f706de6998f077094f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "937a5fbfd4aed483cbb181c9c4fcbad384d3e6963a4a4f706de6998f077094f3", kill_on_drop: false }` [INFO] [stdout] 937a5fbfd4aed483cbb181c9c4fcbad384d3e6963a4a4f706de6998f077094f3