[INFO] cloning repository https://github.com/Alexei-B/mc_sim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Alexei-B/mc_sim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexei-B%2Fmc_sim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexei-B%2Fmc_sim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8d391b7c25d3ef8d68ae836252feb1e16dce8f94 [INFO] checking Alexei-B/mc_sim/8d391b7c25d3ef8d68ae836252feb1e16dce8f94 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlexei-B%2Fmc_sim" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Alexei-B/mc_sim on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Alexei-B/mc_sim [INFO] finished tweaking git repo https://github.com/Alexei-B/mc_sim [INFO] tweaked toml for git repo https://github.com/Alexei-B/mc_sim written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Alexei-B/mc_sim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 00bcf08f1b4650f2e081ba366cd23476b6d285e16886122d9614af10fa1d6788 [INFO] running `Command { std: "docker" "start" "-a" "00bcf08f1b4650f2e081ba366cd23476b6d285e16886122d9614af10fa1d6788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "00bcf08f1b4650f2e081ba366cd23476b6d285e16886122d9614af10fa1d6788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "00bcf08f1b4650f2e081ba366cd23476b6d285e16886122d9614af10fa1d6788", kill_on_drop: false }` [INFO] [stdout] 00bcf08f1b4650f2e081ba366cd23476b6d285e16886122d9614af10fa1d6788 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b64c8197ad50c1e89db5fa7d12df41c4d39152dae1c2beac9b2bab75ad3549b [INFO] running `Command { std: "docker" "start" "-a" "1b64c8197ad50c1e89db5fa7d12df41c4d39152dae1c2beac9b2bab75ad3549b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.56 [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling getrandom v0.2.0 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking futures-sink v0.3.8 [INFO] [stderr] Checking futures-core v0.3.8 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-io v0.3.8 [INFO] [stderr] Checking futures-task v0.3.8 [INFO] [stderr] Compiling event-listener v2.5.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking futures-channel v0.3.8 [INFO] [stderr] Compiling cached_proc_macro_types v0.1.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling async-mutex v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking humantime v2.0.1 [INFO] [stderr] Checking quick-error v2.0.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.0 [INFO] [stderr] Checking generic-array v0.13.2 [INFO] [stderr] Checking alga v0.9.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking fraction v0.8.0 [INFO] [stderr] Checking nalgebra v0.19.0 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling pin-project-internal v1.0.2 [INFO] [stderr] Compiling futures-macro v0.3.8 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking pin-project v1.0.2 [INFO] [stderr] Checking futures-util v0.3.8 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling cached_proc_macro v0.6.0 [INFO] [stderr] Checking futures-executor v0.3.8 [INFO] [stderr] Checking futures v0.3.8 [INFO] [stderr] Checking cached v0.22.0 [INFO] [stderr] Checking statrs v0.13.0 [INFO] [stderr] Checking mc_sim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `ender_pearl_target_total` and `ender_pearl_target_per_run` are never read [INFO] [stdout] --> src/stats.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct EnderPearlDistribution { [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] 11 | ender_pearl_target_total: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | ender_pearl_target_per_run: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnderPearlDistribution` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ender_pearl_target_total` and `ender_pearl_target_per_run` are never read [INFO] [stdout] --> src/stats.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct EnderPearlDistribution { [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] 11 | ender_pearl_target_total: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | ender_pearl_target_per_run: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnderPearlDistribution` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop.rs:6:28 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Serialize, Deserialize, Copy, Clone, PartialEq, Eq, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_list.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 21 | fn new(list: Vec, distribution: Result) -> DropList { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | DropList { list, distribution: distribution.map(|d| Some(d)).unwrap_or(None) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:128:30 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | luckiest_stream: Arc::clone(&luckiest_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | simulations: Arc::clone(&simulations), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | thread: thread::Builder::new() [INFO] [stdout] | _____________________^ [INFO] [stdout] 131 | | .name(name) [INFO] [stdout] 132 | | .spawn(move || { [INFO] [stdout] 133 | | SimulationThread::run( [INFO] [stdout] ... | [INFO] [stdout] 141 | | }) [INFO] [stdout] 142 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:264:24 [INFO] [stdout] | [INFO] [stdout] 257 | let completed = Arc::new(RwLock::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | completed: Arc::clone(&completed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 257 | let completed = Arc::new(RwLock::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | workers: (0..thread_count) [INFO] [stdout] | ______________________^ [INFO] [stdout] 266 | | .map(|id| { [INFO] [stdout] 267 | | SimulationThread::new( [INFO] [stdout] 268 | | format!("Simulation Worker Thread #{}", id), [INFO] [stdout] ... | [INFO] [stdout] 274 | | }) [INFO] [stdout] 275 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop.rs:6:28 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(Debug, Serialize, Deserialize, Copy, Clone, PartialEq, Eq, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 430 | fn into_results(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | / self.workers [INFO] [stdout] 432 | | .into_iter() [INFO] [stdout] 433 | | .flat_map(|worker| worker.into_thread().join().unwrap()) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:433:32 [INFO] [stdout] | [INFO] [stdout] 433 | .flat_map(|worker| worker.into_thread().join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/drop_list.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 21 | fn new(list: Vec, distribution: Result) -> DropList { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | DropList { list, distribution: distribution.map(|d| Some(d)).unwrap_or(None) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:128:30 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | luckiest_stream: Arc::clone(&luckiest_stream), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:129:26 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | simulations: Arc::clone(&simulations), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 119 | completed: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let luckiest_stream = Arc::new(RwLock::new(None)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let simulations = Arc::new(RwLock::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | thread: thread::Builder::new() [INFO] [stdout] | _____________________^ [INFO] [stdout] 131 | | .name(name) [INFO] [stdout] 132 | | .spawn(move || { [INFO] [stdout] 133 | | SimulationThread::run( [INFO] [stdout] ... | [INFO] [stdout] 141 | | }) [INFO] [stdout] 142 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:264:24 [INFO] [stdout] | [INFO] [stdout] 257 | let completed = Arc::new(RwLock::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | completed: Arc::clone(&completed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:265:22 [INFO] [stdout] | [INFO] [stdout] 257 | let completed = Arc::new(RwLock::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | workers: (0..thread_count) [INFO] [stdout] | ______________________^ [INFO] [stdout] 266 | | .map(|id| { [INFO] [stdout] 267 | | SimulationThread::new( [INFO] [stdout] 268 | | format!("Simulation Worker Thread #{}", id), [INFO] [stdout] ... | [INFO] [stdout] 274 | | }) [INFO] [stdout] 275 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 430 | fn into_results(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | / self.workers [INFO] [stdout] 432 | | .into_iter() [INFO] [stdout] 433 | | .flat_map(|worker| worker.into_thread().join().unwrap()) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sim.rs:433:32 [INFO] [stdout] | [INFO] [stdout] 433 | .flat_map(|worker| worker.into_thread().join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mc_sim` (lib test) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `mc_sim` (lib) due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1b64c8197ad50c1e89db5fa7d12df41c4d39152dae1c2beac9b2bab75ad3549b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b64c8197ad50c1e89db5fa7d12df41c4d39152dae1c2beac9b2bab75ad3549b", kill_on_drop: false }` [INFO] [stdout] 1b64c8197ad50c1e89db5fa7d12df41c4d39152dae1c2beac9b2bab75ad3549b