[INFO] cloning repository https://github.com/AlessioZanga/sidrs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlessioZanga/sidrs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessioZanga%2Fsidrs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessioZanga%2Fsidrs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 13f16140686f6f676ee44f1ad961eb6beadfeca1 [INFO] checking AlessioZanga/sidrs/13f16140686f6f676ee44f1ad961eb6beadfeca1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlessioZanga%2Fsidrs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AlessioZanga/sidrs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AlessioZanga/sidrs [INFO] finished tweaking git repo https://github.com/AlessioZanga/sidrs [INFO] tweaked toml for git repo https://github.com/AlessioZanga/sidrs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AlessioZanga/sidrs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87b040314d6ada561804f3f3bb2247efdda665b14e60f6e64ac712db6409ff6a [INFO] running `Command { std: "docker" "start" "-a" "87b040314d6ada561804f3f3bb2247efdda665b14e60f6e64ac712db6409ff6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87b040314d6ada561804f3f3bb2247efdda665b14e60f6e64ac712db6409ff6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87b040314d6ada561804f3f3bb2247efdda665b14e60f6e64ac712db6409ff6a", kill_on_drop: false }` [INFO] [stdout] 87b040314d6ada561804f3f3bb2247efdda665b14e60f6e64ac712db6409ff6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f86d546008d2b3bdd8595d3dfb7d573176e97271171826b224e7c520ffc671c6 [INFO] running `Command { std: "docker" "start" "-a" "f86d546008d2b3bdd8595d3dfb7d573176e97271171826b224e7c520ffc671c6", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling libR-sys v0.6.0 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling extendr-api v0.6.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling extendr-macros v0.6.0 [INFO] [stderr] Checking sidrs v0.1.0 (/opt/rustwide/workdir/src/rust) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:191:47 [INFO] [stdout] | [INFO] [stdout] 187 | let h_pa_x: FxIndexSet<_> = Pa!(h, x).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | // Compute the vertices reachable from i in G via non-directed paths. [INFO] [stdout] 189 | let r = _reach_non_directed(g, x, &h_pa_x); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | // For each vertex j ... [INFO] [stdout] 191 | (0..n).into_par_iter().filter_map(move |y| { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 192 | | if x != y { [INFO] [stdout] 193 | | // Increment the SID count. [INFO] [stdout] 194 | | Some(_sid_count(x, y, &g_ch_x, &h_pa_x, p, &r)) [INFO] [stdout] ... | [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 327 | fn robj_to_array2_bool(obj: Robj) -> Array2 { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | // Invoke `as.matrix`. [INFO] [stdout] 329 | let obj = R!("as.matrix({{obj}})").expect("Failed to invoke `as.matrix` on R object"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | // Get underlying shape and data vector. [INFO] [stdout] 331 | / match obj.rtype() { [INFO] [stdout] 332 | | // RMatrix => Array2 [INFO] [stdout] 333 | | Rtype::Doubles => { [INFO] [stdout] 334 | | let obj: RMatrix = obj [INFO] [stdout] ... | [INFO] [stdout] 355 | | ), [INFO] [stdout] 356 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:364:11 [INFO] [stdout] | [INFO] [stdout] 363 | fn sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | _sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:364:36 [INFO] [stdout] | [INFO] [stdout] 363 | fn sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | _sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:371:15 [INFO] [stdout] | [INFO] [stdout] 370 | fn par_sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | _par_sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:371:40 [INFO] [stdout] | [INFO] [stdout] 370 | fn par_sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | _par_sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:191:47 [INFO] [stdout] | [INFO] [stdout] 187 | let h_pa_x: FxIndexSet<_> = Pa!(h, x).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | // Compute the vertices reachable from i in G via non-directed paths. [INFO] [stdout] 189 | let r = _reach_non_directed(g, x, &h_pa_x); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | // For each vertex j ... [INFO] [stdout] 191 | (0..n).into_par_iter().filter_map(move |y| { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 192 | | if x != y { [INFO] [stdout] 193 | | // Increment the SID count. [INFO] [stdout] 194 | | Some(_sid_count(x, y, &g_ch_x, &h_pa_x, p, &r)) [INFO] [stdout] ... | [INFO] [stdout] 197 | | } [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 327 | fn robj_to_array2_bool(obj: Robj) -> Array2 { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | // Invoke `as.matrix`. [INFO] [stdout] 329 | let obj = R!("as.matrix({{obj}})").expect("Failed to invoke `as.matrix` on R object"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | // Get underlying shape and data vector. [INFO] [stdout] 331 | / match obj.rtype() { [INFO] [stdout] 332 | | // RMatrix => Array2 [INFO] [stdout] 333 | | Rtype::Doubles => { [INFO] [stdout] 334 | | let obj: RMatrix = obj [INFO] [stdout] ... | [INFO] [stdout] 355 | | ), [INFO] [stdout] 356 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:364:11 [INFO] [stdout] | [INFO] [stdout] 363 | fn sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | _sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:364:36 [INFO] [stdout] | [INFO] [stdout] 363 | fn sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | _sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:371:15 [INFO] [stdout] | [INFO] [stdout] 370 | fn par_sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | _par_sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rust/src/lib.rs:371:40 [INFO] [stdout] | [INFO] [stdout] 370 | fn par_sid(g: Robj, h: Robj) -> usize { [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | _par_sid(&robj_to_array2_bool(g), &robj_to_array2_bool(h)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sidrs` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sidrs` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "f86d546008d2b3bdd8595d3dfb7d573176e97271171826b224e7c520ffc671c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f86d546008d2b3bdd8595d3dfb7d573176e97271171826b224e7c520ffc671c6", kill_on_drop: false }` [INFO] [stdout] f86d546008d2b3bdd8595d3dfb7d573176e97271171826b224e7c520ffc671c6