[INFO] cloning repository https://github.com/AlecDivito/kv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlecDivito/kv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecDivito%2Fkv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecDivito%2Fkv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ca687cc1a2540c216842dd364eaefd942ff8da47 [INFO] checking AlecDivito/kv/ca687cc1a2540c216842dd364eaefd942ff8da47 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlecDivito%2Fkv" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AlecDivito/kv on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AlecDivito/kv [INFO] finished tweaking git repo https://github.com/AlecDivito/kv [INFO] tweaked toml for git repo https://github.com/AlecDivito/kv written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AlecDivito/kv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a15a25345671355eaf2155eac4d055ee55dc56ea2c224b0de501e280f10dbcbf [INFO] running `Command { std: "docker" "start" "-a" "a15a25345671355eaf2155eac4d055ee55dc56ea2c224b0de501e280f10dbcbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a15a25345671355eaf2155eac4d055ee55dc56ea2c224b0de501e280f10dbcbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a15a25345671355eaf2155eac4d055ee55dc56ea2c224b0de501e280f10dbcbf", kill_on_drop: false }` [INFO] [stdout] a15a25345671355eaf2155eac4d055ee55dc56ea2c224b0de501e280f10dbcbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6feefb079d0ecfb81b5831649fe0102788cc6d36aa4140f800694fce62c9f7d8 [INFO] running `Command { std: "docker" "start" "-a" "6feefb079d0ecfb81b5831649fe0102788cc6d36aa4140f800694fce62c9f7d8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling const_fn v0.4.5 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling serde_json v1.0.62 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking crc-catalog v1.1.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.9.3 [INFO] [stderr] Checking crc v2.0.0 [INFO] [stderr] Checking sled v0.34.6 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking predicates-tree v1.0.2 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking plotters v0.3.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking predicates v2.0.2 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking panic-control v0.1.4 [INFO] [stderr] Compiling syn-mid v0.5.3 [INFO] [stderr] Compiling clap_derive-v3 v3.0.0-beta.1 [INFO] [stderr] Checking clap-v3 v3.0.0-beta.1 [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking assert_cmd v2.0.0 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.0 [INFO] [stderr] Checking criterion v0.3.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn connect(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let tcp_reader = TcpStream::connect(addr)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let tcp_writer = tcp_reader.try_clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Ok(KvClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 20 | | reader: Deserializer::from_reader(BufReader::new(tcp_reader)), [INFO] [stdout] 21 | | writer: BufWriter::new(tcp_writer), [INFO] [stdout] 22 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:13:28 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/mod.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(folder: impl Into) -> crate::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let sstable = config.restore_wal()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let levels = config.restore_levels()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | config: Arc::new(config), [INFO] [stdout] 34 | | sstable: Arc::new(RwLock::new(sstable)), [INFO] [stdout] 35 | | levels, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/mod.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 99 | let mut keys = self.levels.find(&pattern)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(keys.into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/config.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 56 | let new = SSTable::new(&self.folder)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Ok(std::mem::replace(dest, new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/level.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(directory: impl Into, level: usize) -> crate::Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let dirs = std::fs::read_dir(&directory)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let mut segments = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | inner: Arc::new(RwLock::new(Lvl { [INFO] [stdout] 91 | | dir: directory, [INFO] [stdout] 92 | | level, [INFO] [stdout] 93 | | segments, [INFO] [stdout] 94 | | })), [INFO] [stdout] 95 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/level.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn update_level(&self, next_path: impl AsRef) -> crate::Result> { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let lock = self.inner.read().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(if length > clamp(10 * level, 2) { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | let merge = self.merge(next_path)?; [INFO] [stdout] 128 | | Some(merge) [INFO] [stdout] 129 | | } else { [INFO] [stdout] 130 | | None [INFO] [stdout] 131 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/level.rs:185:29 [INFO] [stdout] | [INFO] [stdout] 185 | .filter_map(|s| SegmentReader::new(s).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/level.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 223 | pub fn new(directory: impl Into) -> crate::Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let mut levels = vec![Level::new(&directory, 1)?]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 237 | | inner: Arc::new(RwLock::new(levels)), [INFO] [stdout] 238 | | directory: Arc::new(RwLock::new(directory)), [INFO] [stdout] 239 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 149 | fn drain_to_segment(&self, path: impl AsRef) -> crate::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let mut writer = BufWriter::new(File::create(path.as_ref())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let table = self.inner.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Segment::new(index, path.as_ref(), size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn new(directory: impl AsRef) -> crate::Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let writer = BufWriter::new(File::create(path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 203 | | inner: MemoryTable::new(), [INFO] [stdout] 204 | | write_ahead_log: Arc::new(Mutex::new(writer)), [INFO] [stdout] 205 | | write_ahead_log_path: directory.as_ref().to_path_buf(), [INFO] [stdout] 206 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn from_write_ahead_log(path: impl AsRef) -> crate::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | info!("Restoring SSTable from: {:?}", path.as_ref()); [INFO] [stdout] 212 | let inner = MemoryTable::from_write_ahead_log(path.as_ref())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | let writer = BufWriter::new(File::create(path.as_ref())?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | [INFO] [stdout] 215 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | inner, [INFO] [stdout] 217 | | write_ahead_log: Arc::new(Mutex::new(writer)), [INFO] [stdout] 218 | | write_ahead_log_path: path.as_ref().to_path_buf(), [INFO] [stdout] 219 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:498:20 [INFO] [stdout] | [INFO] [stdout] 494 | pub fn new(index: Index, segment_path: impl Into, size: usize) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | index: Pin::new(Box::new(index)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:500:19 [INFO] [stdout] | [INFO] [stdout] 494 | pub fn new(index: Index, segment_path: impl Into, size: usize) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | size: Pin::new(Box::new(size)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:501:28 [INFO] [stdout] | [INFO] [stdout] 494 | pub fn new(index: Index, segment_path: impl Into, size: usize) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | should_remove: Pin::new(Box::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:518:12 [INFO] [stdout] | [INFO] [stdout] 505 | pub fn from_log(path: impl Into) -> crate::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 508 | let mut reader = BufReader::new(File::open(&segment_path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | Ok(Self::new(index, segment_path, block_start)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:579:12 [INFO] [stdout] | [INFO] [stdout] 522 | path: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 523 | mut readers: Vec, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | let mut writer = BufWriter::new(File::create(&segment_path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 579 | Ok(Segment::new(index, segment_path, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/sstable.rs:666:12 [INFO] [stdout] | [INFO] [stdout] 662 | let mut reader = BufReader::new(File::open(&path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 666 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 667 | | path, [INFO] [stdout] 668 | | reader, [INFO] [stdout] 669 | | elements, [INFO] [stdout] 670 | | value: None, [INFO] [stdout] 671 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/memory.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 30 | fn restore(_: impl Into) -> crate::Result [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | map: Arc::new(RwLock::new(Default::default())), [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 12 | fn restore(folder: impl Into) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(SledKvsEngine(open(folder.into())?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 25 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6feefb079d0ecfb81b5831649fe0102788cc6d36aa4140f800694fce62c9f7d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6feefb079d0ecfb81b5831649fe0102788cc6d36aa4140f800694fce62c9f7d8", kill_on_drop: false }` [INFO] [stdout] 6feefb079d0ecfb81b5831649fe0102788cc6d36aa4140f800694fce62c9f7d8