[INFO] cloning repository https://github.com/AlcaYezz/pong_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AlcaYezz/pong_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlcaYezz%2Fpong_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlcaYezz%2Fpong_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8181cbd1d13f674dcbb6ffb4f3444f03143d28ce [INFO] checking AlcaYezz/pong_rust/8181cbd1d13f674dcbb6ffb4f3444f03143d28ce against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAlcaYezz%2Fpong_rust" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AlcaYezz/pong_rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AlcaYezz/pong_rust [INFO] finished tweaking git repo https://github.com/AlcaYezz/pong_rust [INFO] tweaked toml for git repo https://github.com/AlcaYezz/pong_rust written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AlcaYezz/pong_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75a2d6026bed909bb9107aacec8489e8d35d047af236abbee49c73ace8a04d68 [INFO] running `Command { std: "docker" "start" "-a" "75a2d6026bed909bb9107aacec8489e8d35d047af236abbee49c73ace8a04d68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75a2d6026bed909bb9107aacec8489e8d35d047af236abbee49c73ace8a04d68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75a2d6026bed909bb9107aacec8489e8d35d047af236abbee49c73ace8a04d68", kill_on_drop: false }` [INFO] [stdout] 75a2d6026bed909bb9107aacec8489e8d35d047af236abbee49c73ace8a04d68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 690ec0089516342d2dae196050a766de66a91cf328e59370f56c58c4fe54b518 [INFO] running `Command { std: "docker" "start" "-a" "690ec0089516342d2dae196050a766de66a91cf328e59370f56c58c4fe54b518", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking lazy_static v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Compiling proc-macro2 v0.4.9 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking byteorder v1.2.4 [INFO] [stderr] Checking piston-float v0.3.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling quote v0.6.4 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking piston-viewport v0.3.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling either v1.5.0 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling rayon v1.0.2 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking token_store v0.1.2 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking shader_version v0.3.0 [INFO] [stderr] Compiling pkg-config v0.3.12 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling x11-dl v2.18.2 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking inflate v0.4.3 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking remove_dir_all v0.5.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking piston-texture v0.6.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking vecmath v0.3.1 [INFO] [stderr] Checking read_color v1.0.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking interpolation v0.1.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking piston-shaders_graphics2d v0.3.1 [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking rusty v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/models/mod.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | ((MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - ((MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER) [INFO] [stdout] 67 + (MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/models/mod.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | ((MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - ((MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY) [INFO] [stdout] 69 + (MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/models/mod.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | ((MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - ((MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER) [INFO] [stdout] 67 + (MAX_ANG_PLAYER - MIN_ANG_PLAYER) * normalize + MIN_ANG_PLAYER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/models/mod.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | ((MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - ((MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY) [INFO] [stdout] 69 + (MAX_ANG_ENEMY - MIN_ANG_ENEMY) * normalize + MIN_ANG_ENEMY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(opengl: OpenGL, glyphs: GlyphCache<'a>) -> App<'a> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | App { [INFO] [stdout] 20 | gl: GlGraphics::new(opengl), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty` (bin "rusty" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(opengl: OpenGL, glyphs: GlyphCache<'a>) -> App<'a> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | App { [INFO] [stdout] 20 | gl: GlGraphics::new(opengl), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty` (bin "rusty") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "690ec0089516342d2dae196050a766de66a91cf328e59370f56c58c4fe54b518", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "690ec0089516342d2dae196050a766de66a91cf328e59370f56c58c4fe54b518", kill_on_drop: false }` [INFO] [stdout] 690ec0089516342d2dae196050a766de66a91cf328e59370f56c58c4fe54b518