[INFO] cloning repository https://github.com/Al3x-G/rustlings [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Al3x-G/rustlings" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAl3x-G%2Frustlings", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAl3x-G%2Frustlings'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5116a812fbcdf8662934ef35e5d6d0d0794a5d47 [INFO] checking Al3x-G/rustlings/5116a812fbcdf8662934ef35e5d6d0d0794a5d47 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAl3x-G%2Frustlings" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Al3x-G/rustlings on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Al3x-G/rustlings [INFO] finished tweaking git repo https://github.com/Al3x-G/rustlings [INFO] tweaked toml for git repo https://github.com/Al3x-G/rustlings written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Al3x-G/rustlings already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ffb55ec28fe61501ab3a9275a7b2be8175dbea22ab16b303e799d6e158ccf40 [INFO] running `Command { std: "docker" "start" "-a" "1ffb55ec28fe61501ab3a9275a7b2be8175dbea22ab16b303e799d6e158ccf40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ffb55ec28fe61501ab3a9275a7b2be8175dbea22ab16b303e799d6e158ccf40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ffb55ec28fe61501ab3a9275a7b2be8175dbea22ab16b303e799d6e158ccf40", kill_on_drop: false }` [INFO] [stdout] 1ffb55ec28fe61501ab3a9275a7b2be8175dbea22ab16b303e799d6e158ccf40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 966573c02dac938acde4e8b6c7eaf438303e20368e26e231d05c80d08ea8fffc [INFO] running `Command { std: "docker" "start" "-a" "966573c02dac938acde4e8b6c7eaf438303e20368e26e231d05c80d08ea8fffc", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking libc v0.2.155 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking winnow v0.6.14 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking notify-debouncer-mini v0.4.1 [INFO] [stderr] Checking os_pipe v1.2.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.27.0 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking rustlings-macros v6.1.0 (/opt/rustwide/workdir/rustlings-macros) [INFO] [stderr] Checking rustlings v6.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / serde_json::de::from_slice::(&metadata_output) [INFO] [stdout] 58 | | .context("Failed to read the field `target_directory` from the `cargo metadata` output") [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn run_cmd(mut cmd: Command, description: &str, output: &mut Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let (mut reader, writer) = os_pipe::pipe() [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let writer_clone = writer.try_clone().with_context(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let mut handle = cmd [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / handle [INFO] [stdout] 30 | | .wait() [INFO] [stdout] 31 | | .with_context(|| format!("Failed to wait on the command `{description}` to exit")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embedded.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 20 | let file = match self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / file.with_context(|| format!("Failed to open the file `{path}` in write mode"))? [INFO] [stdout] 30 | | .write_all(content) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | terminal.draw(|frame| ui_state.draw(frame).unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / serde_json::de::from_slice::(&metadata_output) [INFO] [stdout] 58 | | .context("Failed to read the field `target_directory` from the `cargo metadata` output") [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn run_cmd(mut cmd: Command, description: &str, output: &mut Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | let (mut reader, writer) = os_pipe::pipe() [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let writer_clone = writer.try_clone().with_context(|| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let mut handle = cmd [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / handle [INFO] [stdout] 30 | | .wait() [INFO] [stdout] 31 | | .with_context(|| format!("Failed to wait on the command `{description}` to exit")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/embedded.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 20 | let file = match self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / file.with_context(|| format!("Failed to open the file `{path}` in write mode"))? [INFO] [stdout] 30 | | .write_all(content) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | terminal.draw(|frame| ui_state.draw(frame).unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustlings` (bin "rustlings" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustlings` (bin "rustlings") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "966573c02dac938acde4e8b6c7eaf438303e20368e26e231d05c80d08ea8fffc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "966573c02dac938acde4e8b6c7eaf438303e20368e26e231d05c80d08ea8fffc", kill_on_drop: false }` [INFO] [stdout] 966573c02dac938acde4e8b6c7eaf438303e20368e26e231d05c80d08ea8fffc