[INFO] cloning repository https://github.com/AgustinCB/soccer-data [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/AgustinCB/soccer-data" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAgustinCB%2Fsoccer-data", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAgustinCB%2Fsoccer-data'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6c56d2b5efee6437e3e52389866d87f9dc388f72 [INFO] checking AgustinCB/soccer-data/6c56d2b5efee6437e3e52389866d87f9dc388f72 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAgustinCB%2Fsoccer-data" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/AgustinCB/soccer-data on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/AgustinCB/soccer-data [INFO] finished tweaking git repo https://github.com/AgustinCB/soccer-data [INFO] tweaked toml for git repo https://github.com/AgustinCB/soccer-data written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/AgustinCB/soccer-data already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e724fa17c5839d62f72cc45bd7c385b226984307af471072dbfe1aa9a0f0b940 [INFO] running `Command { std: "docker" "start" "-a" "e724fa17c5839d62f72cc45bd7c385b226984307af471072dbfe1aa9a0f0b940", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e724fa17c5839d62f72cc45bd7c385b226984307af471072dbfe1aa9a0f0b940", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e724fa17c5839d62f72cc45bd7c385b226984307af471072dbfe1aa9a0f0b940", kill_on_drop: false }` [INFO] [stdout] e724fa17c5839d62f72cc45bd7c385b226984307af471072dbfe1aa9a0f0b940 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a002f59dab6bf49f217a1bdd59ddc0458b478ee11385ddc3116efcad7c97e086 [INFO] running `Command { std: "docker" "start" "-a" "a002f59dab6bf49f217a1bdd59ddc0458b478ee11385ddc3116efcad7c97e086", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking byteorder v1.1.0 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking futures v0.1.16 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking log v0.3.8 [INFO] [stderr] Checking lazycell v0.5.1 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking scoped-tls v0.1.0 [INFO] [stderr] Checking smallvec v0.2.1 [INFO] [stderr] Checking take v0.1.0 [INFO] [stderr] Checking safemem v0.2.0 [INFO] [stderr] Checking serde v1.0.15 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Checking httparse v1.2.3 [INFO] [stderr] Checking either v1.3.0 [INFO] [stderr] Checking itoa v0.3.4 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking percent-encoding v1.0.0 [INFO] [stderr] Checking itertools v0.7.1 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Compiling unicase v2.0.0 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Checking mime v0.3.4 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking afa-scrapper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::serde_json::Value` [INFO] [stdout] --> src/match_manager/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | use self::serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::MatchManager` [INFO] [stdout] --> src/match_manager/mod.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | use super::MatchManager; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/loader/mod.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | matches: RefCell>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | matches: RefCell>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/loader/mod.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | matches: RefCell>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | matches: RefCell>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/loader/mod.rs:25:37 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(matches: RefCell>, max_tries: Option) -> AfaLoader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(matches: RefCell>, max_tries: Option) -> AfaLoader { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/loader/mod.rs:25:37 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(matches: RefCell>, max_tries: Option) -> AfaLoader { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(matches: RefCell>, max_tries: Option) -> AfaLoader { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `matches` [INFO] [stdout] --> src/match_manager/mod.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn save(self, matches: Vec) -> fmt::Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `MatchGetter` is never used [INFO] [stdout] --> src/api/mod.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait MatchGetter { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AfaApi` is never constructed [INFO] [stdout] --> src/api/mod.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | struct AfaApi { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_match_uri` is never used [INFO] [stdout] --> src/api/mod.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn get_match_uri(id: i64) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MatchInterval` is never used [INFO] [stdout] --> src/loader/mod.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | pub enum MatchInterval { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Loader` is never used [INFO] [stdout] --> src/loader/mod.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | pub trait Loader { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AfaLoader` is never constructed [INFO] [stdout] --> src/loader/mod.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | struct AfaLoader { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `value_to_match`, `get_next_valid_match`, `is_no_revision_error`, and `process_interval` are never used [INFO] [stdout] --> src/loader/mod.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl AfaLoader { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] 25 | pub fn new(matches: RefCell>, max_tries: Option) -> AfaLoader { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | fn value_to_match(v: Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | fn get_next_valid_match(&self, id: i64) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | fn is_no_revision_error(match_attempt: &Result) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn process_interval(&self, from: i64, max_steps: Option) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `data` are never used [INFO] [stdout] --> src/match_manager/mod.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Match { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | pub fn new(id: i64) -> Match { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub fn data(mut self, data: Value) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MatchManager` is never constructed [INFO] [stdout] --> src/match_manager/mod.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct MatchManager { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `history`, and `save` are never used [INFO] [stdout] --> src/match_manager/mod.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl MatchManager { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] 26 | pub fn new(path: &'static str) -> MatchManager { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn history(self) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn save(self, matches: Vec) -> fmt::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 37 | .and_then(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | body.concat2().map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | serde_json::from_slice(&body).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `afa-scrapper` (bin "afa-scrapper") due to 3 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `matches` [INFO] [stdout] --> src/match_manager/mod.rs:34:23 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn save(self, matches: Vec) -> fmt::Result { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_matches` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MatchManager` is never constructed [INFO] [stdout] --> src/match_manager/mod.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct MatchManager { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `history`, and `save` are never used [INFO] [stdout] --> src/match_manager/mod.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl MatchManager { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] 26 | pub fn new(path: &'static str) -> MatchManager { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn history(self) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | pub fn save(self, matches: Vec) -> fmt::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 37 | .and_then(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | body.concat2().map_err(|err| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|body| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | serde_json::from_slice(&body).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `afa-scrapper` (bin "afa-scrapper" test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a002f59dab6bf49f217a1bdd59ddc0458b478ee11385ddc3116efcad7c97e086", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a002f59dab6bf49f217a1bdd59ddc0458b478ee11385ddc3116efcad7c97e086", kill_on_drop: false }` [INFO] [stdout] a002f59dab6bf49f217a1bdd59ddc0458b478ee11385ddc3116efcad7c97e086