[INFO] cloning repository https://github.com/Addisonbean/gcmod [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Addisonbean/gcmod" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAddisonbean%2Fgcmod", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAddisonbean%2Fgcmod'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ad10d98fa76df2ecbcce5682ea983ebf7de39ee0 [INFO] checking Addisonbean/gcmod/ad10d98fa76df2ecbcce5682ea983ebf7de39ee0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAddisonbean%2Fgcmod" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Addisonbean/gcmod on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Addisonbean/gcmod [INFO] finished tweaking git repo https://github.com/Addisonbean/gcmod [INFO] tweaked toml for git repo https://github.com/Addisonbean/gcmod written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Addisonbean/gcmod already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fa872b9bd7403c53d46bb265433263ff88a2175d0d3befebe5f2df9178aa82a [INFO] running `Command { std: "docker" "start" "-a" "8fa872b9bd7403c53d46bb265433263ff88a2175d0d3befebe5f2df9178aa82a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fa872b9bd7403c53d46bb265433263ff88a2175d0d3befebe5f2df9178aa82a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fa872b9bd7403c53d46bb265433263ff88a2175d0d3befebe5f2df9178aa82a", kill_on_drop: false }` [INFO] [stdout] 8fa872b9bd7403c53d46bb265433263ff88a2175d0d3befebe5f2df9178aa82a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 114ed42d77fb0eeb6480e0c988d147e67d2cd37e8b551d336c879931a19ccd29 [INFO] running `Command { std: "docker" "start" "-a" "114ed42d77fb0eeb6480e0c988d147e67d2cd37e8b551d336c879931a19ccd29", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling regex v1.0.1 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking regex-syntax v0.6.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking aho-corasick v0.6.5 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking gcmod v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/sections/dol/segment.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / lazy_static! { [INFO] [stdout] 65 | | static ref SEG_NAME_REGEX: Regex = [INFO] [stdout] 66 | | Regex::new(r"^\.?(text|data)(\d+)$").unwrap(); [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/rom_rebuilder.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | / lazy_static! { [INFO] [stdout] 391 | | static ref ZEROS: Mutex> = Mutex::new(vec![]); [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/sections/dol/segment.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / lazy_static! { [INFO] [stdout] 65 | | static ref SEG_NAME_REGEX: Regex = [INFO] [stdout] 66 | | Regex::new(r"^\.?(text|data)(\d+)$").unwrap(); [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/rom_rebuilder.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | / lazy_static! { [INFO] [stdout] 391 | | static ref ZEROS: Mutex> = Mutex::new(vec![]); [INFO] [stdout] 392 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APPLOADER_ENTRY_POINT_ADDR` is never used [INFO] [stdout] --> src/sections/apploader.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const APPLOADER_ENTRY_POINT_ADDR: u64 = 0x2450; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APPLOADER_ENTRY_POINT_SIZE` is never used [INFO] [stdout] --> src/sections/apploader.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | const APPLOADER_ENTRY_POINT_SIZE: u64 = 0xA0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APPLOADER_ENTRY_POINT_ADDR` is never used [INFO] [stdout] --> src/sections/apploader.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | const APPLOADER_ENTRY_POINT_ADDR: u64 = 0x2450; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `APPLOADER_ENTRY_POINT_SIZE` is never used [INFO] [stdout] --> src/sections/apploader.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | const APPLOADER_ENTRY_POINT_SIZE: u64 = 0xA0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:74:11 [INFO] [stdout] | [INFO] [stdout] 34 | let app = clap_app!(app => [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | match app.get_matches().subcommand() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 111 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | file_in_iso: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let (mut game, mut iso) = try_to_open_game(input.as_ref(), 0)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | game.extract(&mut iso, output).map_err(|_| AppError::new("Failed to write files.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn try_to_open_game

(path: P, offset: u64) -> Result<(Game, BufReader), AppError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let iso = File::open(path).expect("Couldn't open file"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | let mut iso = BufReader::new(iso); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | / Game::open(&mut iso, offset) [INFO] [stdout] 307 | | .map(|game| (game, iso)) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:74:11 [INFO] [stdout] | [INFO] [stdout] 34 | let app = clap_app!(app => [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | match app.get_matches().subcommand() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 111 | input: impl AsRef, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | output: impl AsRef, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | file_in_iso: Option>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let (mut game, mut iso) = try_to_open_game(input.as_ref(), 0)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | game.extract(&mut iso, output).map_err(|_| AppError::new("Failed to write files.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 295 | fn try_to_open_game

(path: P, offset: u64) -> Result<(Game, BufReader), AppError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let iso = File::open(path).expect("Couldn't open file"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | let mut iso = BufReader::new(iso); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | / Game::open(&mut iso, offset) [INFO] [stdout] 307 | | .map(|game| (game, iso)) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gcmod` (bin "gcmod") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gcmod` (bin "gcmod" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "114ed42d77fb0eeb6480e0c988d147e67d2cd37e8b551d336c879931a19ccd29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "114ed42d77fb0eeb6480e0c988d147e67d2cd37e8b551d336c879931a19ccd29", kill_on_drop: false }` [INFO] [stdout] 114ed42d77fb0eeb6480e0c988d147e67d2cd37e8b551d336c879931a19ccd29