[INFO] cloning repository https://github.com/Aborgen/ugit_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Aborgen/ugit_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAborgen%2Fugit_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAborgen%2Fugit_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8dbd1be275f8a456d928bf5bf924d971b9815d39 [INFO] checking Aborgen/ugit_rust/8dbd1be275f8a456d928bf5bf924d971b9815d39 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FAborgen%2Fugit_rust" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Aborgen/ugit_rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Aborgen/ugit_rust [INFO] finished tweaking git repo https://github.com/Aborgen/ugit_rust [INFO] tweaked toml for git repo https://github.com/Aborgen/ugit_rust written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Aborgen/ugit_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52d1667c66d168ad12750585e016a3157de0c0cab592d8618feb82361636f849 [INFO] running `Command { std: "docker" "start" "-a" "52d1667c66d168ad12750585e016a3157de0c0cab592d8618feb82361636f849", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52d1667c66d168ad12750585e016a3157de0c0cab592d8618feb82361636f849", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52d1667c66d168ad12750585e016a3157de0c0cab592d8618feb82361636f849", kill_on_drop: false }` [INFO] [stdout] 52d1667c66d168ad12750585e016a3157de0c0cab592d8618feb82361636f849 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73282ff3c575d301c2e23945461405a22f4406b0c6c42c308abf75e921f096e3 [INFO] running `Command { std: "docker" "start" "-a" "73282ff3c575d301c2e23945461405a22f4406b0c6c42c308abf75e921f096e3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.70 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking lock_api v0.4.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.3 [INFO] [stderr] Checking ugit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/data.rs:123:67 [INFO] [stdout] | [INFO] [stdout] 123 | None => Ok(RefValue { symbolic: false, value: None, path: path.clone().to_path_buf() }) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 123 - None => Ok(RefValue { symbolic: false, value: None, path: path.clone().to_path_buf() }) [INFO] [stdout] 123 + None => Ok(RefValue { symbolic: false, value: None, path: path.to_path_buf() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 139 | Err(err) => return Some(Err(Error::new(err.kind(), format!("Error when getting contents of HEAD -- {}", err)))) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | match get_ref_file(&path, false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 167 | Err(err) => return Some(Err(err)) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Some(Ok(ref_value)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/data.rs:171:70 [INFO] [stdout] | [INFO] [stdout] 171 | let ref_value = RefValue { symbolic, value: Some(value), path: path.clone().to_path_buf() }; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 171 - let ref_value = RefValue { symbolic, value: Some(value), path: path.clone().to_path_buf() }; [INFO] [stdout] 171 + let ref_value = RefValue { symbolic, value: Some(value), path: path.to_path_buf() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:249:72 [INFO] [stdout] | [INFO] [stdout] 249 | let get_ref_from_variant = |path_variant: PathVariant| get_ref_file(&generate_path(path_variant).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/data.rs:386:24 [INFO] [stdout] | [INFO] [stdout] 386 | let mut path = path.clone().to_path_buf(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 386 - let mut path = path.clone().to_path_buf(); [INFO] [stdout] 386 + let mut path = path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ugit` (bin "ugit") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "73282ff3c575d301c2e23945461405a22f4406b0c6c42c308abf75e921f096e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73282ff3c575d301c2e23945461405a22f4406b0c6c42c308abf75e921f096e3", kill_on_drop: false }` [INFO] [stdout] 73282ff3c575d301c2e23945461405a22f4406b0c6c42c308abf75e921f096e3