[INFO] cloning repository https://github.com/ANtlord/system_ladder [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ANtlord/system_ladder" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FANtlord%2Fsystem_ladder", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FANtlord%2Fsystem_ladder'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 44b3e901bcfed342ce69b974defef244f8170d6d [INFO] checking ANtlord/system_ladder/44b3e901bcfed342ce69b974defef244f8170d6d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FANtlord%2Fsystem_ladder" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ANtlord/system_ladder on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ANtlord/system_ladder [INFO] finished tweaking git repo https://github.com/ANtlord/system_ladder [INFO] tweaked toml for git repo https://github.com/ANtlord/system_ladder written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ANtlord/system_ladder already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2cc6adea3e6884882498c48269392fd4125800746d6153bb60fc9c4637de1f1 [INFO] running `Command { std: "docker" "start" "-a" "a2cc6adea3e6884882498c48269392fd4125800746d6153bb60fc9c4637de1f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2cc6adea3e6884882498c48269392fd4125800746d6153bb60fc9c4637de1f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2cc6adea3e6884882498c48269392fd4125800746d6153bb60fc9c4637de1f1", kill_on_drop: false }` [INFO] [stdout] a2cc6adea3e6884882498c48269392fd4125800746d6153bb60fc9c4637de1f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a3a9c789309ef8f7908e6ea5ce979aaedbcc6b2054d8bdade40935278aad6ff [INFO] running `Command { std: "docker" "start" "-a" "0a3a9c789309ef8f7908e6ea5ce979aaedbcc6b2054d8bdade40935278aad6ff", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Checking system_ladder v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/item.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Link(Cell::new( [INFO] [stdout] 13 | Box::into_raw(Box::new(Item::new(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 77 | let iter = getpwent().map_err(|x| PasswdError::IO(x))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Err(PasswdError::DoesNotExist) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process/mod.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 51 | let file_descriptors_dir_reading = process_file_desctriptors_path.as_path().read_dir().unwrap(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let file_descriptors_dir_entries = file_descriptors_dir_reading.filter_map(|x| x.ok()); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let process_opened_files = file_descriptors_dir_entries.map(|x| x.path()).map(|x| fs::read_link(x)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | process_opened_files.filter_map(|x| x.ok()).filter(|x| x.is_file()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/mod.rs:78:55 [INFO] [stdout] | [INFO] [stdout] 78 | nodes.map(|(mut x, mut y)| mem::swap(&mut x.as_mut().payload, &mut y.as_mut().payload)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/mod.rs:78:80 [INFO] [stdout] | [INFO] [stdout] 78 | nodes.map(|(mut x, mut y)| mem::swap(&mut x.as_mut().payload, &mut y.as_mut().payload)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn head(value: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 109 | | parent: zero_node_ptr(), [INFO] [stdout] 110 | | left: zero_node_ptr(), [INFO] [stdout] 111 | | right: zero_node_ptr(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | payload, [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn black(value: NonNull, parent: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 120 | | left: zero_node_ptr(), [INFO] [stdout] 121 | | right: zero_node_ptr(), [INFO] [stdout] 122 | | color: Color::Black, [INFO] [stdout] ... | [INFO] [stdout] 125 | | payload, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 129 | fn red(value: NonNull, parent: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 131 | | left: zero_node_ptr(), [INFO] [stdout] 132 | | right: zero_node_ptr(), [INFO] [stdout] 133 | | color: Color::Red, [INFO] [stdout] ... | [INFO] [stdout] 136 | | payload, [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/mod.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(predicate: FnBox) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self{ [INFO] [stdout] 85 | data: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/mod.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(predicate: FnBox) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | sw: SwimSink(predicate), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/indexed_heap.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(predicate: FnBox>) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | heap: Heap{ [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | data: Vec::new(), [INFO] [stdout] 72 | | sw: SwimSink(predicate, Box::new(move |left: &Pair, right: &Pair| { [INFO] [stdout] 73 | | dbg!(&left.1, &right.1); [INFO] [stdout] 74 | | tree_clone.borrow_mut().swap(&left.1, &right.1); [INFO] [stdout] 75 | | })), [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/indexed_heap.rs:99:14 [INFO] [stdout] | [INFO] [stdout] 91 | let pair: Pair = self.heap.pop()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let value = match Rc::try_unwrap(pair.1) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Err(e) => panic!("fail popping from indexed binary heap. Popped item has {} references", Rc::strong_count(&e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Some((pair.0, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/container/heap/indexed_heap.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | drop(index); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `usize` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 93 - drop(index); [INFO] [stdout] 93 + let _ = index; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/shortest_path/monotonic.rs:68:45 [INFO] [stdout] | [INFO] [stdout] 68 | graph.adj(0).for_each(|x| heap.push(EdgeLink{ edge: x, previous: None, distance: x.weight })); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | let dump_to = fs::OpenOptions::new().write(true).create(true).open(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { dump_to }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str/suffixtree.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 71 | fn from(n: Node<'a>) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Self(Some(Box::new(n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str/kmp.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 97 | fn in_stream>(text: impl Iterator, pattern: &str) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut dfa = build_state_machine(pattern); [INFO] [stdout] 99 | / text.enumerate() [INFO] [stdout] 100 | | .find(|(_, byte)| dfa.next(*byte.borrow())) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `system_ladder` (bin "system_ladder") due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/item.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Link(Cell::new( [INFO] [stdout] 13 | Box::into_raw(Box::new(Item::new(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 77 | let iter = getpwent().map_err(|x| PasswdError::IO(x))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Err(PasswdError::DoesNotExist) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process/mod.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 51 | let file_descriptors_dir_reading = process_file_desctriptors_path.as_path().read_dir().unwrap(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let file_descriptors_dir_entries = file_descriptors_dir_reading.filter_map(|x| x.ok()); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let process_opened_files = file_descriptors_dir_entries.map(|x| x.path()).map(|x| fs::read_link(x)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | process_opened_files.filter_map(|x| x.ok()).filter(|x| x.is_file()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/fs/mod.rs:198:28 [INFO] [stdout] | [INFO] [stdout] 198 | panic!(e); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 198 | panic!("{}", e); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 198 | std::panic::panic_any(e); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/mod.rs:78:55 [INFO] [stdout] | [INFO] [stdout] 78 | nodes.map(|(mut x, mut y)| mem::swap(&mut x.as_mut().payload, &mut y.as_mut().payload)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/mod.rs:78:80 [INFO] [stdout] | [INFO] [stdout] 78 | nodes.map(|(mut x, mut y)| mem::swap(&mut x.as_mut().payload, &mut y.as_mut().payload)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn head(value: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 109 | | parent: zero_node_ptr(), [INFO] [stdout] 110 | | left: zero_node_ptr(), [INFO] [stdout] 111 | | right: zero_node_ptr(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | payload, [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 118 | fn black(value: NonNull, parent: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 120 | | left: zero_node_ptr(), [INFO] [stdout] 121 | | right: zero_node_ptr(), [INFO] [stdout] 122 | | color: Color::Black, [INFO] [stdout] ... | [INFO] [stdout] 125 | | payload, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/rbtree/node/mod.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 129 | fn red(value: NonNull, parent: NonNull, payload: P) -> NonNull { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | to_heap(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 131 | | left: zero_node_ptr(), [INFO] [stdout] 132 | | right: zero_node_ptr(), [INFO] [stdout] 133 | | color: Color::Red, [INFO] [stdout] ... | [INFO] [stdout] 136 | | payload, [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/mod.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(predicate: FnBox) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Self{ [INFO] [stdout] 85 | data: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/mod.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn new(predicate: FnBox) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | sw: SwimSink(predicate), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/indexed_heap.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(predicate: FnBox>) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | heap: Heap{ [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | data: Vec::new(), [INFO] [stdout] 72 | | sw: SwimSink(predicate, Box::new(move |left: &Pair, right: &Pair| { [INFO] [stdout] 73 | | dbg!(&left.1, &right.1); [INFO] [stdout] 74 | | tree_clone.borrow_mut().swap(&left.1, &right.1); [INFO] [stdout] 75 | | })), [INFO] [stdout] 76 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/indexed_heap.rs:99:14 [INFO] [stdout] | [INFO] [stdout] 91 | let pair: Pair = self.heap.pop()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let value = match Rc::try_unwrap(pair.1) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | Ok(x) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Err(e) => panic!("fail popping from indexed binary heap. Popped item has {} references", Rc::strong_count(&e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Some((pair.0, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/container/heap/indexed_heap.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | drop(index); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `usize` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 93 - drop(index); [INFO] [stdout] 93 + let _ = index; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/tests.rs:108:62 [INFO] [stdout] | [INFO] [stdout] 107 | let dt = Rc::clone(&data); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut ret = Heap::new(Box::new(move |x, y| dt.borrow()[*x] < dt.borrow()[*y])); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/tests.rs:108:80 [INFO] [stdout] | [INFO] [stdout] 107 | let dt = Rc::clone(&data); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut ret = Heap::new(Box::new(move |x, y| dt.borrow()[*x] < dt.borrow()[*y])); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/tests.rs:115:62 [INFO] [stdout] | [INFO] [stdout] 114 | let dt = Rc::clone(&data); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let mut ret = Heap::new(Box::new(move |x, y| dt.borrow()[*x] > dt.borrow()[*y])); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container/heap/tests.rs:115:80 [INFO] [stdout] | [INFO] [stdout] 114 | let dt = Rc::clone(&data); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let mut ret = Heap::new(Box::new(move |x, y| dt.borrow()[*x] > dt.borrow()[*y])); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/graph/shortest_path/dijkstra.rs:80:40 [INFO] [stdout] | [INFO] [stdout] 80 | assert!(shortest_path.is_ok(), shortest_path.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 80 | assert!(shortest_path.is_ok(), "{}", shortest_path.err().unwrap()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/graph/shortest_path/dijkstra.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | assert!(shortest_path.is_ok(), shortest_path.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 96 | assert!(shortest_path.is_ok(), "{}", shortest_path.err().unwrap()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/shortest_path/dijkstra.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 118 | let mut di = Box::new(Digraph::new(edges.len())); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Ok(Self { di, sp, source }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/graph/shortest_path/dijkstra.rs:161:40 [INFO] [stdout] | [INFO] [stdout] 161 | assert!(!program.is_err(), program.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 161 | assert!(!program.is_err(), "{}", program.err().unwrap()); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/shortest_path/monotonic.rs:68:45 [INFO] [stdout] | [INFO] [stdout] 68 | graph.adj(0).for_each(|x| heap.push(EdgeLink{ edge: x, previous: None, distance: x.weight })); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/maxflow/mod.rs:305:13 [INFO] [stdout] | [INFO] [stdout] 304 | fn apply_mask<'a, 'b: 'a, T>(iter: impl Iterator + 'a, mask: &'b [bool]) -> impl Iterator + 'a { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | iter.enumerate().filter(move |(i, _)| mask[*i]).map(|(_, x)| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trace.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | let dump_to = fs::OpenOptions::new().write(true).create(true).open(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Ok(Self { dump_to }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str/suffixtree.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 71 | fn from(n: Node<'a>) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Self(Some(Box::new(n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str/kmp.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 97 | fn in_stream>(text: impl Iterator, pattern: &str) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut dfa = build_state_machine(pattern); [INFO] [stdout] 99 | / text.enumerate() [INFO] [stdout] 100 | | .find(|(_, byte)| dfa.next(*byte.borrow())) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `system_ladder` (bin "system_ladder" test) due to 23 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0a3a9c789309ef8f7908e6ea5ce979aaedbcc6b2054d8bdade40935278aad6ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a3a9c789309ef8f7908e6ea5ce979aaedbcc6b2054d8bdade40935278aad6ff", kill_on_drop: false }` [INFO] [stdout] 0a3a9c789309ef8f7908e6ea5ce979aaedbcc6b2054d8bdade40935278aad6ff