[INFO] cloning repository https://github.com/911code/netcat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/911code/netcat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F911code%2Fnetcat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F911code%2Fnetcat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 96e85471dd3a64f5ed35249177be1f77dbf2b60e [INFO] checking 911code/netcat/96e85471dd3a64f5ed35249177be1f77dbf2b60e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F911code%2Fnetcat" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/911code/netcat on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/911code/netcat [INFO] finished tweaking git repo https://github.com/911code/netcat [INFO] tweaked toml for git repo https://github.com/911code/netcat written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/911code/netcat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b94b601ca9b06b7d3308dafd08ed71e2b265f77956447e15859a56168c6d341 [INFO] running `Command { std: "docker" "start" "-a" "4b94b601ca9b06b7d3308dafd08ed71e2b265f77956447e15859a56168c6d341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b94b601ca9b06b7d3308dafd08ed71e2b265f77956447e15859a56168c6d341", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b94b601ca9b06b7d3308dafd08ed71e2b265f77956447e15859a56168c6d341", kill_on_drop: false }` [INFO] [stdout] 4b94b601ca9b06b7d3308dafd08ed71e2b265f77956447e15859a56168c6d341 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 827a62dce5ac81c6ca1ce44ca06c350baed520d6690056fd8c280b38370c6fbb [INFO] running `Command { std: "docker" "start" "-a" "827a62dce5ac81c6ca1ce44ca06c350baed520d6690056fd8c280b38370c6fbb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking xcursor v0.3.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking gethostname v0.2.3 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling is-terminal v0.4.12 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling is_ci v1.2.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling r3bl_ansi_color v0.6.9 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking x11rb-protocol v0.10.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling r3bl_simple_logger v0.1.3 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling copypasta-ext v0.4.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling get-size v0.1.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking csscolorparser v0.6.2 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking x11rb v0.10.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap_builder v4.5.14 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking smithay-clipboard v0.6.6 [INFO] [stderr] Checking x11-clipboard v0.7.1 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking copypasta v0.8.2 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking r3bl_rs_utils_core v0.9.13 [INFO] [stderr] Checking syntect v5.2.0 [INFO] [stderr] Checking colorgrad v0.6.2 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling r3bl_rs_utils_macro v0.9.9 [INFO] [stderr] Checking clap v4.5.14 [INFO] [stderr] Checking r3bl_tui v0.5.6 [INFO] [stderr] Checking netcat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused logical operation that must be used [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | incoming.len() == 0 && break; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the logical operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 83 | let _ = incoming.len() == 0 && break; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:36 [INFO] [stdout] | [INFO] [stdout] 118 | let (tcp_stream, ..) = tcp_listener.accept()?; // This is a blocking call. [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | [INFO] [stdout] 120 | thread::spawn(|| match handle_connection(tcp_stream) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused logical operation that must be used [INFO] [stdout] --> src/main.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | num_bytes_read == 0 && break; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the logical operation produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = num_bytes_read == 0 && break; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netcat` (bin "netcat") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused logical operation that must be used [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | incoming.len() == 0 && break; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the logical operation produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 83 | let _ = incoming.len() == 0 && break; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:120:36 [INFO] [stdout] | [INFO] [stdout] 118 | let (tcp_stream, ..) = tcp_listener.accept()?; // This is a blocking call. [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | [INFO] [stdout] 120 | thread::spawn(|| match handle_connection(tcp_stream) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused logical operation that must be used [INFO] [stdout] --> src/main.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | num_bytes_read == 0 && break; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the logical operation produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = num_bytes_read == 0 && break; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netcat` (bin "netcat" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "827a62dce5ac81c6ca1ce44ca06c350baed520d6690056fd8c280b38370c6fbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "827a62dce5ac81c6ca1ce44ca06c350baed520d6690056fd8c280b38370c6fbb", kill_on_drop: false }` [INFO] [stdout] 827a62dce5ac81c6ca1ce44ca06c350baed520d6690056fd8c280b38370c6fbb