[INFO] updating cached repository https://github.com/5225225/snapcd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] db134f03f44d96b2771415f572cb60ef3a8d9103 [INFO] checking 5225225/snapcd/db134f03f44d96b2771415f572cb60ef3a8d9103 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F5225225%2Fsnapcd" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/5225225/snapcd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/5225225/snapcd [INFO] finished tweaking git repo https://github.com/5225225/snapcd [INFO] tweaked toml for git repo https://github.com/5225225/snapcd written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/5225225/snapcd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6dd8efa3a7638478c6dbd93a30cb7daddd0f54e5fbecda9a99f9f107e5ced67d [INFO] running `Command { std: "docker" "start" "-a" "6dd8efa3a7638478c6dbd93a30cb7daddd0f54e5fbecda9a99f9f107e5ced67d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6dd8efa3a7638478c6dbd93a30cb7daddd0f54e5fbecda9a99f9f107e5ced67d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6dd8efa3a7638478c6dbd93a30cb7daddd0f54e5fbecda9a99f9f107e5ced67d", kill_on_drop: false }` [INFO] [stdout] 6dd8efa3a7638478c6dbd93a30cb7daddd0f54e5fbecda9a99f9f107e5ced67d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d61d847ef0b8aaf554045da91ed674e5241e807c792d4d2e9bc96637bcba687f [INFO] running `Command { std: "docker" "start" "-a" "d61d847ef0b8aaf554045da91ed674e5241e807c792d4d2e9bc96637bcba687f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.15 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling rustversion v1.0.2 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking nom v4.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling libsqlite3-sys v0.17.1 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling anyhow v1.0.26 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking bytecount v0.3.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling blake3 v0.2.1 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking half v1.4.1 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking bitvec v0.17.2 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking rusqlite v0.21.0 [INFO] [stderr] Checking nom_locate v0.3.1 [INFO] [stderr] Checking colored v1.9.2 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking gearhash v0.1.2 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking bit-vec v0.5.1 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking criterion-plot v0.4.1 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking plotters v0.2.12 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Checking bit-set v0.5.1 [INFO] [stderr] Checking simplelog v0.7.4 [INFO] [stderr] Checking patch v0.5.0 [INFO] [stderr] Checking proptest v0.9.5 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling thiserror-impl v1.0.11 [INFO] [stderr] Compiling proc-macro-error v0.4.9 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.9 [INFO] [stderr] Checking thiserror v1.0.11 [INFO] [stderr] Compiling structopt-derive v0.4.2 [INFO] [stderr] Compiling proptest-derive v0.1.2 [INFO] [stderr] Checking structopt v0.3.9 [INFO] [stderr] Checking bstr v0.2.11 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking serde_bytes v0.11.3 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking globset v0.4.4 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking snapcd v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Checking criterion v0.3.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let conn = rusqlite::Connection::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Self { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 86 | let item: serde_cbor::Value = serde_cbor::from_slice(&self.data())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | [INFO] [stdout] 88 | let attrs: CommitAttrs = serde_cbor::value::from_value(item)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(Commit { [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | tree: tree.into(), [INFO] [stdout] 102 | | parents: new_parents, [INFO] [stdout] 103 | | attrs, [INFO] [stdout] 104 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/diff.rs:105:46 [INFO] [stdout] | [INFO] [stdout] 105 | ... Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 105 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 105 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:25:35 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | Err(HashFsItemError::NonFileError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:443:9 [INFO] [stdout] | [INFO] [stdout] 443 | Err(WalkRealFsItemsError::UnimplementedFileTypeFound) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ds/sqlite.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new>(path: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let conn = rusqlite::Connection::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { conn }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 14 | let excl_globset = excl_globs.build().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | [INFO] [stdout] 16 | Box::new(move |direntry: &DirEntry| -> bool { [INFO] [stdout] | ______________^ [INFO] [stdout] 17 | | let path = direntry.path(); [INFO] [stdout] 18 | | [INFO] [stdout] 19 | | let canon_path = std::fs::canonicalize(&path).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 32 | | !excl_globset.is_match(normalised_path) [INFO] [stdout] 33 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:4:43 [INFO] [stdout] | [INFO] [stdout] 4 | Debug, Clone, Copy, serde::Serialize, serde::Deserialize, PartialEq, Eq, PartialOrd, Ord, Hash, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:11:48 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Clone, Copy, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snapcd` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d61d847ef0b8aaf554045da91ed674e5241e807c792d4d2e9bc96637bcba687f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d61d847ef0b8aaf554045da91ed674e5241e807c792d4d2e9bc96637bcba687f", kill_on_drop: false }` [INFO] [stdout] d61d847ef0b8aaf554045da91ed674e5241e807c792d4d2e9bc96637bcba687f