[INFO] cloning repository https://github.com/4zv4l/rustchat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/4zv4l/rustchat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4zv4l%2Frustchat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4zv4l%2Frustchat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 59e9bc242b7ac0cf9c396908ade9394db4a9f45d [INFO] checking 4zv4l/rustchat/59e9bc242b7ac0cf9c396908ade9394db4a9f45d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4zv4l%2Frustchat" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/4zv4l/rustchat on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/4zv4l/rustchat [INFO] finished tweaking git repo https://github.com/4zv4l/rustchat [INFO] tweaked toml for git repo https://github.com/4zv4l/rustchat written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/4zv4l/rustchat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41fe15d6bb06002973413beb7faba839acf5feaa83f52bdf396cdaa776565b33 [INFO] running `Command { std: "docker" "start" "-a" "41fe15d6bb06002973413beb7faba839acf5feaa83f52bdf396cdaa776565b33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41fe15d6bb06002973413beb7faba839acf5feaa83f52bdf396cdaa776565b33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41fe15d6bb06002973413beb7faba839acf5feaa83f52bdf396cdaa776565b33", kill_on_drop: false }` [INFO] [stdout] 41fe15d6bb06002973413beb7faba839acf5feaa83f52bdf396cdaa776565b33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a55e26b6bbe0af3cb1b224df79e18dd511c0c7d9eb914b8251c578be3bc6cc43 [INFO] running `Command { std: "docker" "start" "-a" "a55e26b6bbe0af3cb1b224df79e18dd511c0c7d9eb914b8251c578be3bc6cc43", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Checking crypto v0.1.0 (/opt/rustwide/workdir/crypto) [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking netlib v0.1.0 (/opt/rustwide/workdir/netlib) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn accept(listener: TcpListener) -> TcpStream { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | match listener.accept() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 193 | let mut reader = BufReader::new(client); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | data.clear(); [INFO] [stdout] 195 | reader.read_line(data).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:253:19 [INFO] [stdout] | [INFO] [stdout] 251 | let client_write = client_write.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let key = key.to_string(); [INFO] [stdout] 253 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 254 | | loop { [INFO] [stdout] 255 | | // ask for a string to send [INFO] [stdout] 256 | | let data = ask_string(); [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 297 | let client_read = client_read.try_clone().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let key = key.to_string(); [INFO] [stdout] 299 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 300 | | // create the variable to store de write/send data [INFO] [stdout] 301 | | let mut data = String::new(); [INFO] [stdout] 302 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 325 | | } [INFO] [stdout] 326 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:371:11 [INFO] [stdout] | [INFO] [stdout] 355 | let mut f = match OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(f) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | match f.write_all(key.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netlib` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn accept(listener: TcpListener) -> TcpStream { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | match listener.accept() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 193 | let mut reader = BufReader::new(client); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | data.clear(); [INFO] [stdout] 195 | reader.read_line(data).unwrap_or(0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:253:19 [INFO] [stdout] | [INFO] [stdout] 251 | let client_write = client_write.try_clone().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let key = key.to_string(); [INFO] [stdout] 253 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 254 | | loop { [INFO] [stdout] 255 | | // ask for a string to send [INFO] [stdout] 256 | | let data = ask_string(); [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 297 | let client_read = client_read.try_clone().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | let key = key.to_string(); [INFO] [stdout] 299 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 300 | | // create the variable to store de write/send data [INFO] [stdout] 301 | | let mut data = String::new(); [INFO] [stdout] 302 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 325 | | } [INFO] [stdout] 326 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> netlib/src/lib.rs:371:11 [INFO] [stdout] | [INFO] [stdout] 355 | let mut f = match OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok(f) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | match f.write_all(key.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netlib` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "a55e26b6bbe0af3cb1b224df79e18dd511c0c7d9eb914b8251c578be3bc6cc43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a55e26b6bbe0af3cb1b224df79e18dd511c0c7d9eb914b8251c578be3bc6cc43", kill_on_drop: false }` [INFO] [stdout] a55e26b6bbe0af3cb1b224df79e18dd511c0c7d9eb914b8251c578be3bc6cc43