[INFO] cloning repository https://github.com/4t145/rahjong [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/4t145/rahjong" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4t145%2Frahjong", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4t145%2Frahjong'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 857fabbe4272337f16c9b0b2c11e17d8cb3926c5 [INFO] checking 4t145/rahjong/857fabbe4272337f16c9b0b2c11e17d8cb3926c5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4t145%2Frahjong" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/4t145/rahjong on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/4t145/rahjong [INFO] finished tweaking git repo https://github.com/4t145/rahjong [INFO] tweaked toml for git repo https://github.com/4t145/rahjong written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/4t145/rahjong already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 224f2268759dd33b6f0de4186b9a5b4b27f42cd78c3ca326091544c57eb56a6f [INFO] running `Command { std: "docker" "start" "-a" "224f2268759dd33b6f0de4186b9a5b4b27f42cd78c3ca326091544c57eb56a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "224f2268759dd33b6f0de4186b9a5b4b27f42cd78c3ca326091544c57eb56a6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "224f2268759dd33b6f0de4186b9a5b4b27f42cd78c3ca326091544c57eb56a6f", kill_on_drop: false }` [INFO] [stdout] 224f2268759dd33b6f0de4186b9a5b4b27f42cd78c3ca326091544c57eb56a6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 085167eb2c6bddf54fb68fa27f4fe4d9e84d15faed7c21910ab96642c4988789 [INFO] running `Command { std: "docker" "start" "-a" "085167eb2c6bddf54fb68fa27f4fe4d9e84d15faed7c21910ab96642c4988789", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.199 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Checking rahjong v0.1.0 (/opt/rustwide/workdir/lib/rahjong) [INFO] [stdout] warning: unused import: `SeedableRng` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:1:35 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::{seq::SliceRandom, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Win` [INFO] [stdout] --> lib/rahjong/src/rules/jp/round.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | win::{Chankan, Ron, Tsumo, Win}, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hand::Deck` [INFO] [stdout] --> lib/rahjong/src/rules/jp/win.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{draw::Draw, hand::Deck, player::Player, tile::TileId}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Dragon`, `Honer`, `Num`, `SuitKind`, `Suit`, and `tile_set::TileSet` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | self, tile_set::TileSet, Dragon, Honer, Num, Suit, SuitKind, TileFace, TileId, TileIndex, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^ ^^^^^ ^^^ ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SeedableRng` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:1:35 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::{seq::SliceRandom, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Win` [INFO] [stdout] --> lib/rahjong/src/rules/jp/round.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | win::{Chankan, Ron, Tsumo, Win}, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hand::Deck` [INFO] [stdout] --> lib/rahjong/src/rules/jp/win.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{draw::Draw, hand::Deck, player::Player, tile::TileId}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Dragon` and `tile_set::TileSet` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | self, tile_set::TileSet, Dragon, Honer, Num, Suit, SuitKind, TileFace, TileId, TileIndex, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hands` [INFO] [stdout] --> lib/rahjong/src/game.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let hands = self.wall().draw_next_n::<13>().await?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_hands` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hands` [INFO] [stdout] --> lib/rahjong/src/game.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let hands = self.wall().draw_next_n::<13>().await?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_hands` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `seq::SliceRandom` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::{seq::SliceRandom, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gang` [INFO] [stdout] --> lib/rahjong/src/hand.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn gang(&mut self, gang: Gang) -> Result<(), Gang> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_gang` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> lib/rahjong/src/rules/jp/round.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | if let Some(next) = self.draw { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `player` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:187:30 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn operations(&self, player: Wind) -> Vec { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_player` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `seq::SliceRandom` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::{seq::SliceRandom, Rng, SeedableRng}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gang` [INFO] [stdout] --> lib/rahjong/src/hand.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn gang(&mut self, gang: Gang) -> Result<(), Gang> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_gang` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/rahjong/src/hand.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(iter: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Hand { [INFO] [stdout] 83 | tiles: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> lib/rahjong/src/game.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | async fn round(&mut self) -> Result<(), Box> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 32 ~ fn round(&mut self) -> impl std::future::Future>> + Send {async { [INFO] [stdout] 33 | let hands = self.wall().draw_next_n::<13>().await?; [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(()) [INFO] [stdout] 36 ~ } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> lib/rahjong/src/rules/jp/round.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | if let Some(next) = self.draw { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `player` [INFO] [stdout] --> lib/rahjong/src/rules/jp.rs:187:30 [INFO] [stdout] | [INFO] [stdout] 187 | pub fn operations(&self, player: Wind) -> Vec { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_player` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rahjong` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/rahjong/src/hand.rs:83:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(iter: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Hand { [INFO] [stdout] 83 | tiles: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified [INFO] [stdout] --> lib/rahjong/src/game.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | async fn round(&mut self) -> Result<(), Box> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future` [INFO] [stdout] = note: `#[warn(async_fn_in_trait)]` on by default [INFO] [stdout] help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change [INFO] [stdout] | [INFO] [stdout] 32 ~ fn round(&mut self) -> impl std::future::Future>> + Send {async { [INFO] [stdout] 33 | let hands = self.wall().draw_next_n::<13>().await?; [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(()) [INFO] [stdout] 36 ~ } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rahjong` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "085167eb2c6bddf54fb68fa27f4fe4d9e84d15faed7c21910ab96642c4988789", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "085167eb2c6bddf54fb68fa27f4fe4d9e84d15faed7c21910ab96642c4988789", kill_on_drop: false }` [INFO] [stdout] 085167eb2c6bddf54fb68fa27f4fe4d9e84d15faed7c21910ab96642c4988789