[INFO] cloning repository https://github.com/4molybdenum2/safe-rlu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/4molybdenum2/safe-rlu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4molybdenum2%2Fsafe-rlu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4molybdenum2%2Fsafe-rlu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 314c926a8b8dafbd2eff9dbb379203e3eb05bcb1 [INFO] checking 4molybdenum2/safe-rlu/314c926a8b8dafbd2eff9dbb379203e3eb05bcb1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F4molybdenum2%2Fsafe-rlu" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/4molybdenum2/safe-rlu on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/4molybdenum2/safe-rlu [INFO] finished tweaking git repo https://github.com/4molybdenum2/safe-rlu [INFO] tweaked toml for git repo https://github.com/4molybdenum2/safe-rlu written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/4molybdenum2/safe-rlu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7faaf8b12e00b9377917466b4677bbe0777287049bd6e538d25075a37436456 [INFO] running `Command { std: "docker" "start" "-a" "f7faaf8b12e00b9377917466b4677bbe0777287049bd6e538d25075a37436456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7faaf8b12e00b9377917466b4677bbe0777287049bd6e538d25075a37436456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7faaf8b12e00b9377917466b4677bbe0777287049bd6e538d25075a37436456", kill_on_drop: false }` [INFO] [stdout] f7faaf8b12e00b9377917466b4677bbe0777287049bd6e538d25075a37436456 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3436cd6ec428aea5046acfbfd5d834c92fa798f710f0da187178e42bb61815b7 [INFO] running `Command { std: "docker" "start" "-a" "3436cd6ec428aea5046acfbfd5d834c92fa798f710f0da187178e42bb61815b7", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling test-log-macros v0.2.15 [INFO] [stderr] Checking test-log v0.2.15 [INFO] [stderr] Checking rlu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `RluThreadData` and `self` [INFO] [stdout] --> src/rlu_set.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | self, Rlu, RluGlobal, RluThreadData [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RluThreadData` and `self` [INFO] [stdout] --> src/rlu_set.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | self, Rlu, RluGlobal, RluThreadData [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PhantomData` [INFO] [stdout] --> src/rlu_set.rs:7:26 [INFO] [stdout] | [INFO] [stdout] 7 | use std::marker::{Unpin, PhantomData}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem::MaybeUninit` [INFO] [stdout] --> src/rlu_set.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::mem::MaybeUninit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicPtr` and `Ordering` [INFO] [stdout] --> src/rlu_set.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | use std::sync::atomic::{AtomicPtr, Ordering}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PhantomData` [INFO] [stdout] --> src/rlu_set.rs:7:26 [INFO] [stdout] | [INFO] [stdout] 7 | use std::marker::{Unpin, PhantomData}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::mem::MaybeUninit` [INFO] [stdout] --> src/rlu_set.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::mem::MaybeUninit; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AtomicPtr` and `Ordering` [INFO] [stdout] --> src/rlu_set.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | use std::sync::atomic::{AtomicPtr, Ordering}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/rlu_set.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | elem: unsafe{ mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/rlu_set.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | elem: unsafe{ mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/rlu.rs:302:44 [INFO] [stdout] | [INFO] [stdout] 302 | let prev = actual_obj.copy.compare_and_swap(ptr::null_mut(), copy_obj, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/rlu.rs:302:44 [INFO] [stdout] | [INFO] [stdout] 302 | let prev = actual_obj.copy.compare_and_swap(ptr::null_mut(), copy_obj, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rlu_set.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut node = rlu_dereference(self.rlu_global, self.thread_id, node_ptr); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `node` is never read [INFO] [stdout] --> src/rlu_set.rs:154:15 [INFO] [stdout] | [INFO] [stdout] 154 | let mut node = rlu_dereference(self.rlu_global, self.thread_id, node_ptr); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/rlu_set.rs:301:15 [INFO] [stdout] | [INFO] [stdout] 301 | let mut next = rlu_dereference(self.rlu_global, self.thread_id, next_ptr); // ptr to next ptr to prev [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/rlu_set.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rlu_set.rs:301:11 [INFO] [stdout] | [INFO] [stdout] 301 | let mut next = rlu_dereference(self.rlu_global, self.thread_id, next_ptr); // ptr to next ptr to prev [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rlu_set.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut node = rlu_dereference(self.rlu_global, self.thread_id, node_ptr); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `node` is never read [INFO] [stdout] --> src/rlu_set.rs:154:15 [INFO] [stdout] | [INFO] [stdout] 154 | let mut node = rlu_dereference(self.rlu_global, self.thread_id, node_ptr); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[ObjCopy; 128]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:81:26 [INFO] [stdout] | [INFO] [stdout] 81 | log: unsafe{ MaybeUninit::uninit().assume_init() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/rlu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | thread_id : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[Rlu; 100]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | free_nodes: unsafe{MaybeUninit::uninit().assume_init()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: raw pointers must be initialized (in this struct field) [INFO] [stdout] --> src/rlu.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | *mut ObjOriginal [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[RluThreadData; 32]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:138:30 [INFO] [stdout] | [INFO] [stdout] 138 | threads: unsafe {MaybeUninit::uninit().assume_init()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] note: booleans must be either `true` or `false` (in this struct field) [INFO] [stdout] --> src/rlu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | is_writer : bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next` [INFO] [stdout] --> src/rlu_set.rs:301:15 [INFO] [stdout] | [INFO] [stdout] 301 | let mut next = rlu_dereference(self.rlu_global, self.thread_id, next_ptr); // ptr to next ptr to prev [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_next` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rlu.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn alloc(&self, data : T) -> Rlu { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / Box::new(ObjOriginal { [INFO] [stdout] 151 | | copy: AtomicPtr::new(ptr::null_mut()), [INFO] [stdout] 152 | | data, [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/rlu.rs:497:13 [INFO] [stdout] | [INFO] [stdout] 497 | Box::from_raw(thread_data.free_nodes[i].0); //deallocate memory - hack [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 497 | let _ = Box::from_raw(thread_data.free_nodes[i].0); //deallocate memory - hack [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | fn contains(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.0.read().unwrap().contains(&value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/rlu_set.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | fn insert(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.0.write().unwrap().insert(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn delete(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.0.write().unwrap().remove(&value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rlu_set.rs:301:11 [INFO] [stdout] | [INFO] [stdout] 301 | let mut next = rlu_dereference(self.rlu_global, self.thread_id, next_ptr); // ptr to next ptr to prev [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[ObjCopy; 128]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:81:26 [INFO] [stdout] | [INFO] [stdout] 81 | log: unsafe{ MaybeUninit::uninit().assume_init() }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/rlu.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | thread_id : usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[Rlu; 100]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:109:32 [INFO] [stdout] | [INFO] [stdout] 109 | free_nodes: unsafe{MaybeUninit::uninit().assume_init()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: raw pointers must be initialized (in this struct field) [INFO] [stdout] --> src/rlu.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | *mut ObjOriginal [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[RluThreadData; 32]` does not permit being left uninitialized [INFO] [stdout] --> src/rlu.rs:138:30 [INFO] [stdout] | [INFO] [stdout] 138 | threads: unsafe {MaybeUninit::uninit().assume_init()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] note: booleans must be either `true` or `false` (in this struct field) [INFO] [stdout] --> src/rlu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | is_writer : bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rlu.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn alloc(&self, data : T) -> Rlu { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / Box::new(ObjOriginal { [INFO] [stdout] 151 | | copy: AtomicPtr::new(ptr::null_mut()), [INFO] [stdout] 152 | | data, [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | ) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/rlu.rs:497:13 [INFO] [stdout] | [INFO] [stdout] 497 | Box::from_raw(thread_data.free_nodes[i].0); //deallocate memory - hack [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 497 | let _ = Box::from_raw(thread_data.free_nodes[i].0); //deallocate memory - hack [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | fn contains(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.0.read().unwrap().contains(&value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | fn insert(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.0.write().unwrap().insert(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/btree_set.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | fn delete(&self, value: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.0.write().unwrap().remove(&value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlu` (lib test) due to 5 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlu` (lib) due to 5 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3436cd6ec428aea5046acfbfd5d834c92fa798f710f0da187178e42bb61815b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3436cd6ec428aea5046acfbfd5d834c92fa798f710f0da187178e42bb61815b7", kill_on_drop: false }` [INFO] [stdout] 3436cd6ec428aea5046acfbfd5d834c92fa798f710f0da187178e42bb61815b7