[INFO] cloning repository https://github.com/2xsaiko/udptun [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/2xsaiko/udptun" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2xsaiko%2Fudptun", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2xsaiko%2Fudptun'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e36690c058211cd3394cd468691aa0282cb42336 [INFO] checking 2xsaiko/udptun/e36690c058211cd3394cd468691aa0282cb42336 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F2xsaiko%2Fudptun" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/2xsaiko/udptun on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/2xsaiko/udptun [INFO] finished tweaking git repo https://github.com/2xsaiko/udptun [INFO] tweaked toml for git repo https://github.com/2xsaiko/udptun written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/2xsaiko/udptun already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a54946ec1becfcaa39e28d2eefb60d3f4cdbe0f76a4fd73ac1214484b248b5b5 [INFO] running `Command { std: "docker" "start" "-a" "a54946ec1becfcaa39e28d2eefb60d3f4cdbe0f76a4fd73ac1214484b248b5b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a54946ec1becfcaa39e28d2eefb60d3f4cdbe0f76a4fd73ac1214484b248b5b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a54946ec1becfcaa39e28d2eefb60d3f4cdbe0f76a4fd73ac1214484b248b5b5", kill_on_drop: false }` [INFO] [stdout] a54946ec1becfcaa39e28d2eefb60d3f4cdbe0f76a4fd73ac1214484b248b5b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58a831711450c208bba2b676f30d047ddff49c588c3bb4143c0e164137a948a1 [INFO] running `Command { std: "docker" "start" "-a" "58a831711450c208bba2b676f30d047ddff49c588c3bb4143c0e164137a948a1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling proc-macro2 v1.0.17 [INFO] [stderr] Compiling syn v1.0.25 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking arc-swap v0.4.6 [INFO] [stderr] Checking os_str_bytes v2.3.1 [INFO] [stderr] Checking pin-project-lite v0.1.5 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Checking tokio v0.2.21 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.1 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Checking clap v3.0.0-beta.1 [INFO] [stderr] Checking udptun v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Add` [INFO] [stdout] --> src/sourcefmt.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Add; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Add` [INFO] [stdout] --> src/sourcefmt.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::ops::Add; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/sourcefmt.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/sourcefmt.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | fn from_str(s: &str) -> Result { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verbosity` [INFO] [stdout] --> src/main.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | let verbosity = matches.occurrences_of("verbose"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbosity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `verbosity` [INFO] [stdout] --> src/main.rs:52:7 [INFO] [stdout] | [INFO] [stdout] 52 | let verbosity = matches.occurrences_of("verbose"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_verbosity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `print_data_buffer` is never read [INFO] [stdout] --> src/server.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ServerParams<'a, T, U, V> [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | pub print_data_buffer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `print_data_buffer` is never read [INFO] [stdout] --> src/client.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct ClientParams<'a, T, U, V> [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub print_data_buffer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `into_inner` is never used [INFO] [stdout] --> src/common.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl HexFormat { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] 61 | pub fn into_inner(self) -> T { self.0 } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `format_row` is never used [INFO] [stdout] --> src/output.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 16 | / impl TableFormat [INFO] [stdout] 17 | | where T: Column + Copy { [INFO] [stdout] | |__________________________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn format_row(&self, row: &D) -> String { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:93:85 [INFO] [stdout] | [INFO] [stdout] 93 | ... tunnel_socket: cache.get_by_id_mut(id).and_then(|s| s.socket.local_addr().ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:102:55 [INFO] [stdout] | [INFO] [stdout] 102 | sockets.iter().filter_map(|(dir, sock)| match sock.poll_recv_from(cx, buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_cache.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn insert(&mut self, id: ConnId, socket: UdpSocket) -> &mut CacheEntry { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let data = CacheEntry { id, socket }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let entry = CacheEntryOuter { last_access: Cell::new(now), data }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.by_id.insert(id, entry); [INFO] [stdout] 40 | &mut self.by_id.get_mut(&id).unwrap().data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `print_data_buffer` is never read [INFO] [stdout] --> src/server.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ServerParams<'a, T, U, V> [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | pub print_data_buffer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `print_data_buffer` is never read [INFO] [stdout] --> src/client.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct ClientParams<'a, T, U, V> [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub print_data_buffer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `into_inner` is never used [INFO] [stdout] --> src/common.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 60 | impl HexFormat { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] 61 | pub fn into_inner(self) -> T { self.0 } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `format_row` is never used [INFO] [stdout] --> src/output.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 16 | / impl TableFormat [INFO] [stdout] 17 | | where T: Column + Copy { [INFO] [stdout] | |__________________________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn format_row(&self, row: &D) -> String { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:93:85 [INFO] [stdout] | [INFO] [stdout] 93 | ... tunnel_socket: cache.get_by_id_mut(id).and_then(|s| s.socket.local_addr().ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:102:55 [INFO] [stdout] | [INFO] [stdout] 102 | sockets.iter().filter_map(|(dir, sock)| match sock.poll_recv_from(cx, buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_cache.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn insert(&mut self, id: ConnId, socket: UdpSocket) -> &mut CacheEntry { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let data = CacheEntry { id, socket }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let entry = CacheEntryOuter { last_access: Cell::new(now), data }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.by_id.insert(id, entry); [INFO] [stdout] 40 | &mut self.by_id.get_mut(&id).unwrap().data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `udptun` (bin "udptun") due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `udptun` (bin "udptun" test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "58a831711450c208bba2b676f30d047ddff49c588c3bb4143c0e164137a948a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58a831711450c208bba2b676f30d047ddff49c588c3bb4143c0e164137a948a1", kill_on_drop: false }` [INFO] [stdout] 58a831711450c208bba2b676f30d047ddff49c588c3bb4143c0e164137a948a1